675723 - Extensions not compat bumped for ff7 and no email about it sent

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P1)

Description

[Atte Kemppilä [:atte]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

2/4 of my extensions compat bumped for ff 7.*. I got emails (2) about those that were bumped, but no emails about those that weren't (listed below).

https://addons.mozilla.org/en-US/firefox/addon/thumbsdown/
https://addons.mozilla.org/en-US/firefox/addon/saved-from-url/

I had similar issue earlier when ff5 bump was done (bug 658944). Bump for ff6 worked ok for all my extensions.

Comment 1

[Kumar McMillan [:kumar]]

We have better logging since bug 658944; I'll investigate.  The bump that should have caught these was FF 6.* -> 7.* (job #26 on 7/29/2011)

Latest versions:
https://addons.mozilla.org/en-US/firefox/addon/thumbsdown/versions/?page=1#version-0.18
https://addons.mozilla.org/en-US/firefox/addon/saved-from-url/versions/?page=1#version-1.4.20110629

I quickly checked the logs for thumbsdown and didn't see any messages.

Comment 2

[Atte Kemppilä [:atte]]

Manually bumped the maxVersions to 7.* just now.

Did the logs reveal any reason for this bug?

Comment 3

[Kumar McMillan [:kumar]]

This might be related to bug 677721 but I have a few other things in the queue before I can verify either one.

Comment 4

[Atte Kemppilä [:atte]]

ff7 -> ff8 compat bump: 3/4 of my extensions were bumped. This wasn't:

https://addons.mozilla.org/en-US/firefox/addon/saved-from-url/

I got emails (3) for those that were bumped, but no email for the one that wasn't.

Comment 5

[Wil Clouser [:clouserw]]

The logs say it was run on your add-on.  Did you check your junk mail folder?

Comment 6

[Atte Kemppilä [:atte]]

Nothing in spam folder.

Does the log say whether or not the extension was ok'ed for bump? And if not, what was the reason?

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

I see Saved From URL 1.4.20110629 in the success email log. The email address in the log matches your Bugzilla address exactly, so there's no error there. These are the validation results:

https://addons.mozilla.org/developers/addon/saved-from-url/validation-result/66719

However, it's odd that you didn't get the message for that particular add-on out of 4, and I also notice that there's no maxVersion changes in the Recent History (https://addons.mozilla.org/en-US/developers/feed/saved-from-url), and the maxVersion for this version is still 7.*

This is a big problem. I think we need better logs to see how many add-ons we are losing at every step of the bulk validation.

Comment 10

[Kumar McMillan [:kumar]]

Current status: saved-from-url appears to have been bumped and the author emailed according to the dry-run log.  However, the actual production log has no indication of this whatsoever nor does it indicate any catastrophic exceptions, nor was the actual extension bumped.  I've asked IT to look into the state of syslog at this time and everything was stable.  One possible conclusion is that either RabbitMQ or Celery dropped our tasks and never ran them.  I'll scan the changelogs in those libs if there were any obvious bug fixes.

Bug 688314 provides another chance to follow the logging trail but since these logs are old I've had to request them from IT (bug 688586)

Comment 11

[Kumar McMillan [:kumar]]

Uh-oh, we have a problem with our logs. bug 690448.

Comment 12

[Atte Kemppilä [:atte]]

Manually bumped the maxVersion to 8.*.

Comment 13

[Kumar McMillan [:kumar]]

There's not a whole lot left to do on this but we caught two major bugs which have been deployed: bug 690975 and bug 691984.  I can't actually verify whether or not those bugs are causing the problem on saved-from-url but I have a hunch that they were.  In the future I will be able to verify such a thing, thanks to logging added in bug 690124.

I'm closing this for now but please report back if saved-from-url does *not* get bumped on the next run which is probably in two weeks.  Thanks for your patience and help on this.