683093 - Drag Attachments to a Finder-Window isnt working

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Martin Mueller]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/14.0.835.109 Safari/535.1

Steps to reproduce:

I drag an Attachment from the "preview"-section to a MacOS X 10.7.1-Finder-Window.


Actual results:

I drag an Attachment from the "preview"-section to a MacOS X 10.7.1-Finder-Window. Instead of the right file, I get a file called "undefined". The filesize is of "undefined" is exactly the right size of the droped file. 

If i look with text-wrangler into the file, the data are the requested. TB doesnt name the dragged file correctly.


Expected results:

The file appears in the finder-window, but the filename isnt given correctly.

Comment 1

[Ludovic Hirlimann [:Usul]]

xref 515164

Error console is empty when this happens. Confirming with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:8.0a2) Gecko/20110926 Thunderbird/8.0a2 - I didn't find duplicates.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

This fixes it for me - there's an error on the text console with javascript strict mode on staying that attachment.displayName is undefined.

If you look at the CreateAttachmentTransferData this is using name || displayName as well.

Comment 3

[Jim Porter (:squib)]

Comment on attachment 563339 [details] [diff] [review]
The fix

Review of attachment 563339 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you've tested that this works (I build on Linux where drag-and-drop to the desktop is broken at a much lower level), it looks good to me.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/c24fbeb1f0d4

Comment 7

[Mark Banner (:standard8)]

Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/98b40acdbdea
http://hg.mozilla.org/releases/comm-beta/rev/bd34f5b021b2