Drag Attachments to a Finder-Window isnt working

RESOLVED FIXED in Thunderbird 10.0

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: schickher, Assigned: standard8)

Tracking

Trunk
Thunderbird 10.0
x86
macOS

Thunderbird Tracking Flags

(thunderbird8+ fixed, thunderbird9+ fixed)

Details

Attachments

(1 attachment)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_1) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/14.0.835.109 Safari/535.1

Steps to reproduce:

I drag an Attachment from the "preview"-section to a MacOS X 10.7.1-Finder-Window.


Actual results:

I drag an Attachment from the "preview"-section to a MacOS X 10.7.1-Finder-Window. Instead of the right file, I get a file called "undefined". The filesize is of "undefined" is exactly the right size of the droped file. 

If i look with text-wrangler into the file, the data are the requested. TB doesnt name the dragged file correctly.


Expected results:

The file appears in the finder-window, but the filename isnt given correctly.
xref 515164

Error console is empty when this happens. Confirming with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:8.0a2) Gecko/20110926 Thunderbird/8.0a2 - I didn't find duplicates.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: 7 → Trunk
Posted patch The fixSplinter Review
This fixes it for me - there's an error on the text console with javascript strict mode on staying that attachment.displayName is undefined.

If you look at the CreateAttachmentTransferData this is using name || displayName as well.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #563339 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 563339 [details] [diff] [review]
The fix

Review of attachment 563339 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming you've tested that this works (I build on Linux where drag-and-drop to the desktop is broken at a much lower level), it looks good to me.
Attachment #563339 - Flags: review?(squibblyflabbetydoo) → review+
Duplicate of this bug: 690743
Duplicate of this bug: 690403
Checked in: http://hg.mozilla.org/comm-central/rev/c24fbeb1f0d4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
Attachment #563339 - Flags: approval-comm-beta+
Attachment #563339 - Flags: approval-comm-aurora+
Duplicate of this bug: 694569
Duplicate of this bug: 691269
Duplicate of this bug: 692390
Duplicate of this bug: 699455
You need to log in before you can comment on or make changes to this bug.