Closed Bug 690267 Opened 9 years ago Closed 9 years ago

Insert|Insert Characters and symbols not working - no options in drop-downs.

Categories

(Thunderbird :: Message Compose Window, defect)

7 Branch
defect
Not set
normal

Tracking

(thunderbird7 fixed, thunderbird8 fixed, thunderbird9 fixed)

VERIFIED FIXED
Thunderbird 10.0
Tracking Status
thunderbird7 --- fixed
thunderbird8 --- fixed
thunderbird9 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

(Keywords: regression, Whiteboard: [gs])

Attachments

(1 file)

If you go to the compose window, and select Insert -> Characters and Symbols then you'll find that the drop-down boxes have no symbols in them.

This appears to be a regression in 7.

A quick look at the error console reveals:

Error: malformed Unicode character escape sequence
Source File: chrome://editor/content/EdInsertChars.js
Line: 416, Column: 2
Source Code:
  "\u00f2\u00f3\u00f4\u00f5\u00f6\u014d\u014f\u0151\u01d2\u01eb\u01ed\u020d\u020e\u022b\u22d\u022f\u0231\u1e4d\u1e4f\u1e51\u1e53\u1ecd\u1ecf\u1ed1\u1ed3\u1ed5\u1ed7\u1ed9\u1edb\u1edd\u1edf\u1ee1\u1ee3", 

The "\u22d" bit seems to be the error - even my emacs picks that up as wrong. My guess is that something has got a bit stricter in 7, causing this to now be an error.
Attached patch One-byte fixSplinter Review
Attachment #563337 - Flags: review?(neil)
Comment on attachment 563337 [details] [diff] [review]
One-byte fix

Sorry, get the right Neil.
Attachment #563337 - Flags: review?(neil) → review?(neil)
Attachment #563337 - Flags: review?(neil) → review+
Blocks: 663300
Attachment #563337 - Flags: approval-comm-release+
Attachment #563337 - Flags: approval-comm-beta+
Attachment #563337 - Flags: approval-comm-aurora+
> My guess is that something has got a bit stricter in 7, causing this to now be an
> error.

Bug 663300: If \u is not followed by four hex characters it must be a
syntax error (mutatis mutandis for \x)
Checked in and transplanted:

http://hg.mozilla.org/comm-central/rev/6a05eb45b0a7
http://hg.mozilla.org/releases/comm-aurora/rev/59498d666732
http://hg.mozilla.org/releases/comm-beta/rev/3f18b245fd12
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
> status-thunderbird7: --- ➔ fixed

Does this mean this will be fixed in the upcoming 7.0.1 release?
Verified fixed Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 (thus the answer to comment #5 is yes).

Note that SeaMonkey 2.4.1 didn't pick up that fix (spun too early).
Status: RESOLVED → VERIFIED
Duplicate of this bug: 691158
Duplicate of this bug: 695037
Duplicate of this bug: 695391
You need to log in before you can comment on or make changes to this bug.