71137 - need CVS commit account for [e-mail]

Status: RESOLVED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[Masaki Katakai]

I have been working on bugfixes around I18N but just provided patches.
But I'd like to start hacking Mozilla.

I already submitted many bugs around widget/src/gtk I18N and applied
the patches, e.g. bug 53990 and bug 68317, I have already got r= and
sr= for these bugs.

I also have completed CVS contributor form and got an account for
Mozilla.org from [e-mail].

Thanks.

Comment 1

[Marcia Knous [:marcia]]

Masaki:  Please visit http://mozilla.org/hacking/getting-cvs-write-access.html 
and read about what you have to do to get your account activated.  You need to 
get a voucher, as well as 3 Super-Reviewers.

Comment 2

[Frank Tang]

add [e-mail],[e-mail],[e-mail] to the cc list.

Comment 3

[Masaki Katakai]

want sr=. Any comments?

Comment 4

[Masaki Katakai]

I got sr=hyatt in bug 54998 for my patch.

Comment 5

[Christopher Blizzard (:blizzard)]

Two of these patches are one liners.  Generally when we are going to give out
cvs access we like to see a little more depth in the patches that we are looking
at.  The XIM patch does show a good understanding of the gtk widget code and XIM
which is impressive.  I would rather wait a bit, though to give out access.

Comment 6

[Frank Tang]

voucher for katakai

patch submit by katakai
74088 34397 60954 55021 60826 61108 66951 74670 25452 33847 50130 52310 53989 
71199 75930 60714

Comment 7

[Frank Tang]

There are more patches. I am too lazy to find them since bugzilla do not have 
such feature - search by sumbit attachment.

There are totally 124 bugs which have katakai's comments. just search katakai as 
"add comments" and you can find them. He submit patches for at least 20 % of 
them. 

Comment 8

[Christopher Blizzard (:blizzard)]

From reviewing his changes over the last couple of months I think he should be
given access.  sr=blizzard

Comment 9

[Conrad Carlen (not reading bugmail)]

Although I can't give an sr=, I'll give an r= for what it's worth. Katakai-san
has made big improvements to profile mgr localization. See bug 80230 in particular.

Comment 10

[tor]

sr=tor for checkin access.  One minor thing I noticed reading through past
bugs is that many of the diffs weren't in unified format.  Please remember
to use -u in the future.  Thanks.

Comment 11

[kinmoz]

sr=[e-mail] for checkin access ... I'm actually surprised that 
Katakai-san wasn't given access a while ago. :-)

Comment 12

[Christopher Blizzard (:blizzard)]

OK, that's three super-reviews.  We should be all set to go.

Comment 13

[Marcia Knous [:marcia]]

okay, I am ready to flip the switch, but I still need a CVS Contributor Form 
from Masaki.  As soon as I receive the fax, I will activate his account. 

Comment 14

[Marcia Knous [:marcia]]

Please disregard my previous message regarding the form. activating account. 

Comment 15

[Masaki Katakai]

Thank you very much everyone,

I've verified my account now can be used.

Comment 16

[Dave Miller [:justdave]]

Received key via email intended for this account.  After a bounce-back verification, your CVS ssh account has been created.  Your CVSROOT should be:

   [e-mail]:/cvsroot

Don't forget to set your CVS_RSH environment variable to 'ssh'.

If you have any problems connecting, let me know.