72279 - Need visual indicators for Watched, Killed threads

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[esther]

Using perf build 3-12-01 on windows (mac and linux still need to be tested)
Need visual indicators for Watched, Killed threads 
Steps to be added soon.

Comment 1

[scottputterman]

reassigning to hangas and cc'ing jglick.  these are a couple of the icons we
talked about over email.

Comment 2

[hangas]

Sending to Marlon, these are icons from the list you just received.

Comment 3

[laurel]

*** Bug 80259 has been marked as a duplicate of this bug. ***

Comment 4

[laurel]

No target milestone set for this, I can't tell when we intend to have this in.

Comment 5

[Peter Lairo]

can we have a keyword milestone on this (milestone0.9.2)?

Comment 6

[Matthew T (active 1999-2002)]

Peter, if you're going to fix this bug yourself you can set it to any milestone 
you like. Otherwise, shush.

Comment 7

[Peter Lairo]

I was suggesting a "keyword", not a "milestone". Keywords can be set by "normal"
bug reportes and do not obligate the programmer - shhhhhhh ;)

Comment 8

[hangas]

Marking 0.9.3, please try to get this into a limbo build.

Comment 9

[Blake Ross]

Missed 0.9.3.

Comment 10

[Ben Bucksch (:BenB)]

From memory (might be wrong):

We have an active keyboard shortcut for Kill Thread, which makes the thread
invisible in the thread pane. There once was a hard-to-track-down bug about msg
dataloss, which essentially rooted in this behaviour. And it *is* dataloss for
the user.

Adding dataloss keyword, assuming I am right. Please correct me, if not.

Comment 11

[laurel]

*** Bug 94588 has been marked as a duplicate of this bug. ***

Comment 12

[Brian Rogers]

Shouldn't this have 4xp?

Comment 13

[Jacek Piskozub]

You're right! It should. Marking 4xp.

Comment 14

[marlon bishop]

this week

Comment 15

[marlon bishop]

does "killed" thread mean ignored?

Comment 16

[Jacek Piskozub]

Yes. That's probably why the keyboard shortcut for Ignore Thread is "K".

Comment 17

[marlon bishop]

moving to 0.9.5

Comment 18

[R.K.Aa.]

*** Bug 100041 has been marked as a duplicate of this bug. ***

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

Weren't recently some icons checked in for watched/ignored Newsgroup
Messages/Threads, so that this should be rather easy to fix?

Comment 20

[marlon bishop]

not that i know of.  moving to 0.9.6

Comment 21

[Brian Rogers]

How about breaking this into two bugs?
One to make the icons, and one to implement the use of them.
It might get done faster.

Comment 22

[marlon bishop]

ok i finally got to this.  waiting for Jglick approval.  reassigning to shuehan for implementation

Comment 23

[Alfonso Martinez]

*** Bug 107863 has been marked as a duplicate of this bug. ***

Comment 24

[Joe Hewitt (gone)]

Attachment: patch to set watch and ignore properties on outliner cells

Comment 25

[shliang]

Attachment: watch/ignore thread icons for classic

Comment 26

[shliang]

Attachment: watch/ignore thread icons for modern

Comment 27

[shliang]

Attachment: patch

Comment 28

[Joe Hewitt (gone)]

Comment on attachment 56370 [details] [diff] [review]
patch

sr=hewitt

Comment 29

[andreww]

Comment on attachment 56370 [details] [diff] [review]
patch

r=andreww

Comment 30

[Christian :Biesinger (don't email me, ping me on IRC)]

Has this already been checked in? If not, could it be checked in? The patch
already has r= and sr=.

Comment 31

[shliang]

moving this - joe's patch needs to be checked in first

Comment 32

[Jonas Jørgensen]

*** Bug 117616 has been marked as a duplicate of this bug. ***

Comment 33

[laurel]

*** Bug 117616 has been marked as a duplicate of this bug. ***

Comment 34

[Vidar B. Haarr (old account)]

This bug has a fix, and needs to be checked in.

putterman, could you review patch 56178 (patch to set watch and ignore
properties on outliner cells) ? it needs both r= and sr=.

Comment 35

[Håkan Waara]

Attachment: Patch v2

Hewitt's patch leaks; here's a non-leaky patch.  

Now all we need is r/sr on this one, and all of the patches are ready to be
checked in for this bug to get fixed.

Comment 36

[(not reading, please use [e-mail] instead)]

Comment on attachment 66640 [details] [diff] [review]
Patch v2

r=sspitzer

Comment 37

[(not reading, please use [e-mail] instead)]

about the css rules in
(http://bugzilla.mozilla.org/attachment.cgi?id=56370&action=view)

all these rules are specific to news items, right?

would it improve thread pane performance (for imap and local mail) to add "news"
to the rules?

+outlinerbody:-moz-outliner-image(news, threadCol, container, ignore, open) {
+  list-style-image: url("chrome://messenger/skin/thread-open-kill.gif");
+}

Comment 38

[(not reading, please use [e-mail] instead)]

Comment on attachment 56370 [details] [diff] [review]
patch

marking as needs work, I think we should add "news" to all these rules.

Comment 39

[Håkan Waara]

->me

Comment 40

[Håkan Waara]

Attachment: themes patch

Here's all the CSS changes.

I'll do extensive testing tomorrow. In the meantime, I'm seeking reviews...
Seth / Hewitt?

Comment 41

[David :Bienvenu]

Comment on attachment 66640 [details] [diff] [review]
Patch v2

sr=bienvenu

Comment 42

[Joe Hewitt (gone)]

Comment on attachment 66827 [details] [diff] [review]
themes patch

outlinerbody has been replaced by outlinerchildren

Comment 43

[[e-mail]]

Any chance of -moz-image-region instead of tons of extra images?

Comment 44

[Håkan Waara]

Neil, I don't want to delay these patches further, but feel free to file a bug
on yourself and fix it once this is checked in.

Comment 45

[Håkan Waara]

Attachment: Fix with hewitt's suggestion

I changed outlinerbody to outlinerchildren.  I also got a chance to test this
today, and the icons displayed fine when they should.  However, I couldn't get
watching threads working reliably - but this is not a visual problem - AFAIK,
the backend for watched threads have never been quite complete.

I'll go log a bug for that problem before I check this in.

Comment 46

[Håkan Waara]

Since this is a themes-only patch, can I get andreww / hewitt to review it?

Comment 47

[Joe Hewitt (gone)]

Comment on attachment 66915 [details] [diff] [review]
Fix with hewitt's suggestion

sr=hewitt

Comment 48

[andreww]

Comment on attachment 66915 [details] [diff] [review]
Fix with hewitt's suggestion

r=andreww

Comment 49

[Håkan Waara]

Spun off bug #122478 for ignore thread not working.

I checked these fixes into the trunk.

Comment 50

[laurel]

I see watch and ignore icons appearing in modern theme, but can't ever see any
watch or ignore icons in classic theme using hjan30 commercial trunk.

Was fix applied so both should be working -- and should I log a separate bug?

Comment 51

[laurel]

The other thing is -- the watched thread icon looks pretty strange, hard to tell
it's an eye.  Graphic looks a little like it's clipped, but it's probably just
because it's small and indistinguishable.

Comment 52

[laurel]

Logged separate bug for the classic theme problem... see bug 122688.
Will mark this one verified.
Icons appearing for watched or ignored threads, problems found with
display/removal of icons have been and will be logged separately.
OK using jan30 commercial trunk build: win98, linux rh6.2, mac OS 10.1

Comment 53

[Phil "clef" Sweeney]

Is this supposed to work when killing a single post (with no replies) ?

You can kill them, but the indicator icon doesn't show up.. is there a separate
bug on this?

Comment 54

[Håkan Waara]

yes, that's bug 122640.

there are a couple of new bugs opened on remaining issues, please file new bugs
for issues you find - this bug is fixed.