Closed Bug 727515 Opened 12 years ago Closed 6 years ago

Clobber Firefox's Inspector shortcut conditionally

Categories

(Other Applications :: DOM Inspector, defect)

Product:
Other Applications
Component:
DOM Inspector
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: zpao, Unassigned)

Details

Bug 569054 changed it so DOMi clobbers unconditionally, but in bug 689924, the shortcut for Firefox's inspector was changed to cmd+alt+I on OS X.

So I think it would make sense to only disable if the shortcuts conflict.
In current Nightly (and I guess in Aurora), the built-in Inspect functionality is broken when DOMi is installed as DOMi removes key_inspect, which the built-in Inspect item needs to work.

Would the solution here also fix that or should that be a different bug report?
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #1)
> Would the solution here also fix that or should that be a different bug
> report?

Yes, but that's not really the answer to that issue. Colby linked to the bug on Firefox side where that needs to be fixed.

(In reply to Colby Russell :crussell from comment #2)
> bug 688183.

I understand the reasoning behind WONTFIXing that and I agree there. But I think it makes sense that when the keys don't actually overlap, we don't clobber.
Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Bulk close. This component is no longer supported or maintained.

https://bugzilla.mozilla.org/show_bug.cgi?id=1499023
You need to log in before you can comment on or make changes to this bug.