747412 - Installing Favimon does not show the right parenthesis on the desktop shortcut or start menu

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Jason Smith [:jsmith]]

Steps:

1. Go to https://apps.mozillalabs.com/appdir/
2. Install Favimon

Expected:

The application should be installed natively. The desktop shortcut and the item in the start menu should be Favimon (beta).

Actual:

The application is installed natively. However, the desktop shortcut and the item in the start menu is listed as Favimon (beta.

Comment 1

[Jason Smith [:jsmith]]

Attachment: Favimon Parentheses Issue

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

This is related to the sanitization code in bug 704574.

Comment 4

[Ed Lee :Mardak]

The trailing ) is removed by WebappsInstaller.jsm's stripStringForFilename:

  let stripBackRE = new RegExp("\\W*$","gi");

Comment 5

[Ed Lee :Mardak]

felipe, any particular reason trailing characters need to be stripped? Stripping from the beginning makes more sense if the first character must be alphanumeric, but usually there's no requirement for non-first characters.. ?

Comment 6

[Ed Lee :Mardak]

This also affects os x in /Applications and Launcher.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Nope, the original idea was to strip blank/invisible characters, but this ended up to be too aggressive

Comment 8

[Ed Lee :Mardak]

So probably just change it to stripping \s ?

Comment 9

[Ed Lee :Mardak]

Attachment: v1

Comment 10

[Jason Smith [:jsmith]]

(In reply to Edward Lee :Mardak from comment #9)
> Created attachment 618859 [details] [diff] [review]
> v1

FYI - Looking at the patch comment:

//strip everything from the front up to the first [0-9a-zA-Z]

This isn't localized to languages outside of the united states. This explains why bug 733482 might be happening. This needs to be localized, along with other regex expressions used for manifest parsing.

Comment 11

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/mozilla-inbound/rev/add831dc812e

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/add831dc812e