Closed Bug 747412 Opened 10 years ago Closed 10 years ago
Installing Favimon does not show the right parenthesis on the desktop shortcut or start menu
Steps: 1. Go to https://apps.mozillalabs.com/appdir/ 2. Install Favimon Expected: The application should be installed natively. The desktop shortcut and the item in the start menu should be Favimon (beta). Actual: The application is installed natively. However, the desktop shortcut and the item in the start menu is listed as Favimon (beta.
Whiteboard: [marketplace-beta-] → [marketplace-beta=]
The trailing ) is removed by WebappsInstaller.jsm's stripStringForFilename: let stripBackRE = new RegExp("\\W*$","gi");
felipe, any particular reason trailing characters need to be stripped? Stripping from the beginning makes more sense if the first character must be alphanumeric, but usually there's no requirement for non-first characters.. ?
This also affects os x in /Applications and Launcher.
OS: Windows 7 → All
Hardware: x86_64 → All
Nope, the original idea was to strip blank/invisible characters, but this ended up to be too aggressive
So probably just change it to stripping \s ?
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #618859 - Flags: review?(felipc)
Attachment #618859 - Flags: review?(felipc) → review+
(In reply to Edward Lee :Mardak from comment #9) > Created attachment 618859 [details] [diff] [review] > v1 FYI - Looking at the patch comment: //strip everything from the front up to the first [0-9a-zA-Z] This isn't localized to languages outside of the united states. This explains why bug 733482 might be happening. This needs to be localized, along with other regex expressions used for manifest parsing.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.