775232 - Set up build configs in order to produce ARMv6 builds on mozilla-beta (Firefox 16)

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Comment 1

[[e-mail] (:bhearsum)]

Armen, you set these up originally, did we forget to do something when the merged happened on Monday?

Comment 2

[Armen [:armenzg]]

They got enabled up to FF16 (m-a).
We can enabled them on m-b if blassey thinks that we're good.

Enabling them on mozilla-beta does *not* mean we will be doing betas for it... yet.

Comment 3

[Armen [:armenzg]]

Attachment: add armv6 builds on checkin for mozilla-beta

We can enable builds on check-in but asking for armv6 builds to be part of the "betas" is another story that needs someone to be pulled out to do a staging release.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 643567 [details] [diff] [review]
add armv6 builds on checkin for mozilla-beta

r=me if you s,FF17,FF15,

Comment 5

[Armen [:armenzg]]

Comment on attachment 643567 [details] [diff] [review]
add armv6 builds on checkin for mozilla-beta

This should go in tomorrow's reconfig:
http://hg.mozilla.org/build/buildbot-configs/rev/1d9ccb639b45

Comment 6

[Rail Aliiev [:rail]]

In production

Comment 7

[Aki Sasaki (not active)]

These builds are currently en-US only.
I'll proceed with en-US for the first beta.
Multilocale and/or single locale repacks will take further configuration, and we should turn that on in nightlies first.

Comment 8

[Aki Sasaki (not active)]

With the branding as-is, this will have to be published into the same app (org.mozilla.firefox_beta).  That means our manifest has to be set correctly, and we will probably require the same ugly versionCode increment dance that we currently have for android-xul.

Comment 9

[Aki Sasaki (not active)]

Attachment: armv6 beta branding on m-b

Without this, automated tests we run will be perma-broken.

Comment 10

[Aki Sasaki (not active)]

Attachment: aurora branding for m-a

Comment 11

[Aki Sasaki (not active)]

Currently sign_android.py assumes that all platforms will have the same apk_base_name.
The apk name of android-armv6 apks is different (fennec-version.locale.android-arm-armv6.apk).  We'll either need 2 sets of config files + 2 passes of signing, or we need to add per-platform apk_base_name support (and per-platform locale support, while we're at it).

Comment 12

[Aki Sasaki (not active)]

Attachment: (needs testing) [configs] armv6 beta release configs, en-US only

Passes checkconfig; haven't seen it build.

Comment 13

[Aki Sasaki (not active)]

Attachment: (needs testing) [configs] armv6 beta release configs, en-US only, with fixed mozconfig path

Comment 14

[Aki Sasaki (not active)]

Added android-armv6 branding changes to https://wiki.mozilla.org/Release_Management/Merge_Documentation for both aurora and beta.

Comment 15

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #8)
> With the branding as-is, this will have to be published into the same app
> (org.mozilla.firefox_beta).  That means our manifest has to be set
> correctly, and we will probably require the same ugly versionCode increment
> dance that we currently have for android-xul.

From Blassey:
"The package name being the same is exactly what we need. The only over requirement is that the ARMv6 build id be at least one less than the ARMv7 build."

We have a hack in embedding/android/Makefile.in to automatically increment the ANDROID_VERSION_CODE.

I can't currently find a corresponding hack to automatically decrement the ANDROID_VERSION_CODE for armv6.

This means we can't actually build armv6 at the same time as armv7; we have to build it in the previous hour.  This will be a pretty large sticking point.

While we're in here mucking with this stuff, this should be based on the buildid that we pass in instead of just basing off of the machine time, otherwise we're going to hit issues where a delay makes the versionCode overlap the wrong way.

The above blocks our ability to ship armv6 beta builds.

Comment 16

[Aki Sasaki (not active)]

Attachment: (needs testing) [mozharness] android-armv6 signing

This is the quick n ugly fix, where I have a 2nd set of config files and we have to sign twice.

The other fix would be having per-platform locales and apk names, but would be a much larger patch.

Comment 17

[Armen [:armenzg]]

FTR the packaging patches that landed on mozilla-aurora have not been ported to mozilla-beta.
Candidates for this porting are bug 757909, bug 761454, bug 766664, bug 767864 and bug 768386.

blassey ^

Comment 18

[Brad Lassey [:blassey] (use needinfo?)]

requested approval to land all 4 of those bugs (5 patches total) on beta

Comment 19

[Aki Sasaki (not active)]

Comment on attachment 644470 [details] [diff] [review]
armv6 beta branding on m-b

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Turning on armv6 builds where there were none before.

User impact if declined: 

Automated tests will all be broken.

Testing completed (on m-c, etc.): 

None.

Risk to taking this patch (and alternatives if risky): 

Low.

String or UUID changes made by this patch: 

None.

Comment 20

[Aki Sasaki (not active)]

Comment on attachment 644477 [details] [diff] [review]
aurora branding for m-a

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Turning on armv6 builds on aurora, not noticing they were nightly-branded.

User impact if declined: 

Automated tests will all be broken.

Testing completed (on m-c, etc.): 

None.

Risk to taking this patch (and alternatives if risky): 

Low.

String or UUID changes made by this patch: 

None.

Comment 21

[Alex Keybl [:akeybl]]

Comment on attachment 644470 [details] [diff] [review]
armv6 beta branding on m-b

[Triage Comment]
Approving for Beta as well, assuming that this is NPOTB (since we're not yet building ARMv6 on Beta).

Comment 22

[Aki Sasaki (not active)]

(In reply to Alex Keybl [:akeybl] from comment #21)
> Comment on attachment 644470 [details] [diff] [review]
> armv6 beta branding on m-b
> 
> [Triage Comment]
> Approving for Beta as well, assuming that this is NPOTB (since we're not yet
> building ARMv6 on Beta).

We are actually building armv6 on beta, once https://bugzilla.mozilla.org/attachment.cgi?id=643567 landed and buildbot reconfiged.  We turned it on since there's a push to build armv6 in Fx15.0b2.

It's perma-red, however, due to comment 17.
https://tbpl.mozilla.org/?tree=Mozilla-Beta&noignore=1

Comment 23

[Aki Sasaki (not active)]

Comment on attachment 644547 [details] [diff] [review]
(needs testing) [mozharness] android-armv6 signing

Hoping to use the patch in https://bugzilla.mozilla.org/show_bug.cgi?id=750976 instead.

Comment 24

[Armen [:armenzg]]

Moved to Firefox 16.

Comment 25

[Rail Aliiev [:rail]]

Attachment: [configs] armv6 beta release configs, en-US only, with fixed mozconfig path

Refreshed patch tested in staging

Comment 26

[lord.dhruv]

Hi guys any news on when these fix reach firefox beta on the google play store ?

Comment 27

[[e-mail] (:bhearsum)]

(In reply to lord.dhruv from comment #26)
> Hi guys any news on when these fix reach firefox beta on the google play
> store ?

This is probably a question better asked on the dev.apps.firefox newsgroup (https://groups.google.com/forum/?fromgroups#!forum/mozilla.dev.apps.firefox), but Firefox for Armv6 is scheduled to ship with 16, which will be released on October 9th.

Comment 28

[Aki Sasaki (not active)]

Attachment: rail's configs, unbitrotted

Comment 29

[Aki Sasaki (not active)]

Comment on attachment 655747 [details] [diff] [review]
rail's configs, unbitrotted

http://hg.mozilla.org/build/buildbot-configs/rev/5f955db73ffa

Comment 30

[Aki Sasaki (not active)]

Branding appears correct.  Resolving.