787612 - Port |Bug 596234 - Body of RSS feeds won't print or print preview| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Philip Chee]

From Bug 596234 comment 0:
> When printing RSS "messages" from craigslist in "News and Blogs" section of 
> Thunderbird, only the message header and footer print, the body is blank.  The 
> body and images ARE visible on the screen.  Email messages (as opposed to News 
> and Blogs messages) with HTML print properly.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. Subscribe to a craigslist RSS feed in "News and Blogs" such as 
> <http://sfbay.craigslist.org/search/boa?query=catalina
> +27&catAbbreviation=boa&minAsk=min&maxAsk=max&format=rss>
> 2.When you get a new message for this feed, click on the message
> 3.Choose Print or Print Preview.  You will notice that there is not message body 
> printed, only the header and footer.
> Actual Results:  
> Message printed with header and footer visible, no body is visible.
> 
> Expected Results:  
> I expected the whole message to print, header, body, and footer (WYSIWYG).  
> Tbird V2 worked properly.
> 
> The reason this is a "Major" bug is, because of the fleeting nature of news 
> feeds, I like to archive important ones by printing to a PDF file.  If I can't 
> print from Tbird, I'll have to use a different RSS reader.

Comment 1

[Philip Chee]

Should port followup bug as well:
Bug 793838 - Feed body AppMenu items are not working anymore

Comment 2

[Ian Neal]

Port the following:
Bug 596234 - Body of RSS feeds won't print or print preview
Bug 793838 - Feed body AppMenu items are not working anymore
Bug 866498 - Radio group for Main Menu Bar->View->Feed Message Body As not working correctly
Bug 1025548 - Preliminary perf/code org tweaks for Bug 257037 - Part 4

Comment 3

[Ian Neal]

Attachment: RSS Feeds Printing fix

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Cannot print / preview RSS feed items
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 4

[Ian Neal]

Attachment: RSS Feeds Printing fix v1.1

Replaced some single quotes for double quotes in the code being changed.

Comment 5

[Ian Neal]

Attachment: RSS Feeds Printing fix v1.2

Now includes ports of part of:

• Bug 1151497 - Web site from RSS feed not rendered correctly (due to noscript tags) - tab part

This fixes the issue with message pane only ever showing the summary rather than following what was selected under View > Feed Body As

Print only ever shows Summary

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9092861 [details] [diff] [review]
RSS Feeds Printing fix v1.2

lgtm. r/a+

A bit confusing because the message is always displayed as a web page and the menu options only affect the preview in the 3pane but it is exactly as TB handles it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c2a54bcf5083
Port Bug 596234 "Body of RSS feeds won't print or print preview| to SeaMonkey". r=frg

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/6078db5cb2520750c3e369e74719597aa837c7c9

Comment 9

[Frank-Rainer Grahl (:frg)]

Fixed 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b409fd7e8f1068e2a384d1927daf6d8ba4afb46a