806432 - SVG filter region sometimes clipped when viewBox and opacity properties used.

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Carlo Cannas]

Attachment: Example that shows the bug

When an SVG image with viewBox property applied to the root SVG element (may be also another, no tested) has an element with opacity less than 1 and a filter directly applied to it, the filter region is clipped (see attachment).
On Firefox 16 was all fine, on 17 beta the bug showed up.
The clipped filter region is not fixed, it changes as the viewport is resized.

Comment 1

[Alice0775 White]

Seting svg.display-lists.painting.enabled = false helps

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/688734575830
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120802041638
Bad:
http://hg.mozilla.org/mozilla-central/rev/074fb996dfd7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120802062038
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=688734575830&tochange=074fb996dfd7

Regression window(m-c)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a799b5bff84c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120801155239
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b077c43a4306
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120801163038
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a799b5bff84c&tochange=b077c43a4306
Suspected : Bug 776054

Comment 2

[Alex Keybl [:akeybl]]

(In reply to cannas carlo from comment #0)
> Created attachment 676207 [details]
> Example that shows the bug
> 
> When an SVG image with viewBox property applied to the root SVG element (may
> be also another, no tested) has an element with opacity less than 1 and a
> filter directly applied to it, the filter region is clipped (see attachment).
> On Firefox 16 was all fine, on 17 beta the bug showed up.
> The clipped filter region is not fixed, it changes as the viewport is
> resized.

What web property or application is affected? Was this found through testing or while surfing? Thanks in advance!

Comment 3

[Carlo Cannas]

(In reply to Alex Keybl [:akeybl] from comment #2)
> (In reply to cannas carlo from comment #0)
> > Created attachment 676207 [details]
> > Example that shows the bug
> > 
> > When an SVG image with viewBox property applied to the root SVG element (may
> > be also another, no tested) has an element with opacity less than 1 and a
> > filter directly applied to it, the filter region is clipped (see attachment).
> > On Firefox 16 was all fine, on 17 beta the bug showed up.
> > The clipped filter region is not fixed, it changes as the viewport is
> > resized.
> 
> What web property or application is affected? Was this found through testing
> or while surfing? Thanks in advance!
I found it while testing.

Comment 4

[Alex Keybl [:akeybl]]

(In reply to cannas carlo from comment #3)
> (In reply to Alex Keybl [:akeybl] from comment #2)
> > (In reply to cannas carlo from comment #0)
> > > Created attachment 676207 [details]
> > > Example that shows the bug
> > > 
> > > When an SVG image with viewBox property applied to the root SVG element (may
> > > be also another, no tested) has an element with opacity less than 1 and a
> > > filter directly applied to it, the filter region is clipped (see attachment).
> > > On Firefox 16 was all fine, on 17 beta the bug showed up.
> > > The clipped filter region is not fixed, it changes as the viewport is
> > > resized.
> > 
> > What web property or application is affected? Was this found through testing
> > or while surfing? Thanks in advance!
> I found it while testing.

Given that, jwatt - do you have a feel for whether this bug will be prevalent post-release?

Comment 5

[Fabian Steffen]

We also got the report of this bug through our customers. Users which upgraded to V16 has this problem, V15 was ok. I will attach an example which shows this problem. If you remove the opacity-flag everything works fine.

Comment 6

[Fabian Steffen]

Attachment: Example SVG

Comment 7

[Jonathan Watt [:jwatt]]

Not much chance of fixing this for 17.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Marking wontfix for 17 then, but let's try for 18.

Comment 9

[Fabian Steffen]

It seems as this bug has been fixed already for V17. Thanks alot.

Comment 10

[Fabian Steffen]

I'm sorry for my earlier comment. It seems that the problem reported by myself and demonstrated in attachment 678314 [details] "Example SVG" is fixed in V17, but the problem in attachment 676207 [details] "Example that shows the bug" still remains. Therefor the original bug is still available.

Comment 11

[Jonathan Watt [:jwatt]]

I should be able to start looking at this next week.

Comment 12

[Alex Keybl [:akeybl]]

This was not a major issue post-release for FF17. We'll take a low risk uplift if found before beta 4 goes to build Tuesday.

Comment 13

[Jet Villegas (inactive)]

(In reply to Jonathan Watt [:jwatt] from comment #11)
> I should be able to start looking at this next week.

Any update here?

Comment 14

[Jonathan Watt [:jwatt]]

This was untracked, so I'm focusing on the tracking bugs right now.

Comment 15

[Jonathan Watt [:jwatt]]

Attachment: patch

The nsDisplayTransform that is created for the transformed frame has already accounted for the transform by multiplying it onto the gfxContext. Therefore we need to use the untransformed visual overflow region when clipping to create the offscreen surface for group opacity/mask/non-trivial-clipPath.

Comment 16

[Jonathan Watt [:jwatt]]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/5cb54f5fa690

Comment 17

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/5cb54f5fa690

Comment 18

[Jonathan Watt [:jwatt]]

Comment on attachment 694898 [details] [diff] [review]
patch

This fixes bug 780354, bug 782972, bug 815462, bug 818841 and bug 821152 too.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 776054
User impact if declined: quite a number of SVGs broken
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: none

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 694898 [details] [diff] [review]
patch

Approving on aurora as its low risk and helps fix a lot of SVG regressions.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f61cbb4e348b

Comment 21

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 19b4 Win 7, Ubuntu 12.04 and Mac OS X 10.7.5

Comment 22

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 20RC Win 7, Ubuntu 12.04 and Mac OS X 10.7.5