Closed Bug 776054 Opened 12 years ago Closed 12 years ago

Enable SVG display lists

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jwatt, Assigned: jwatt)

References

(Depends on 4 open bugs, Blocks 2 open bugs)

Details

Attachments

(1 file)

Splitting this out from bug 614732. The plan is to land the patches to implement SVG display lists in bug 614732, and then enable SVG display lists in this bug after the patches for bug 755084 have landed and have been enabled.
Depends on: 777430
Off-main-thread-animations are going to cause problems wherever we've got an nsDisplayTransform that combines a transform due to CSS styling with another transform (e.g. a transform imposed by SVG viewbox or 'transform' attribute). A CSS animation on such an element will modify the layer's transform directly, wiping out any modifications made by SVG.

To fix this, we should ensure that CSS transforms aren't mixed with other transforms in the same nsDisplayTransform. We may need to create multiple nsDisplayTransforms for the same element. That's OK as long as they always have different display-item-keys.
Depends on: 778995
Depends on: 779514
Depends on: 614732
As discussed with jet and roc, I've pushed the patch to enable SDL without addressing comment 1 yet. This is in order to gather info on any regressions as early as possible, and to maxixmize our chances of fixing them before the next uplift.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b077c43a4306
Target Milestone: --- → mozilla17
Blocks: 779683
Blocks: 779685
Whether or not this sticks, I've spun comment 1 out into bug 779683 to address it there.
https://hg.mozilla.org/mozilla-central/rev/b077c43a4306
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I've been looking through the Talos data since I pushed this. We got both wins and losses.

We got tscrollr wins on three platforms:

Linux:   http://goo.gl/0kBVd
Linux64: http://goo.gl/CHQGY
WinXP:   http://goo.gl/jcoZU

And tsvgr_opacity regression on three platforms:

WinXP:   http://goo.gl/1I2Ig
OSX10.7: http://goo.gl/prrp6
OSX64:   http://goo.gl/viosq

I don't think the tsvgr_opacity regressions are worth backing out for. I'd rather keep this enabled and get eyes on any functional regressions.
I'll work on figuring out and fixing the tsvgr_opacity regressions on Tuesday when I'm back online.
Depends on: 779893
Depends on: 780354
Apologies - wrong bug.
Depends on: 786894
Depends on: 800198
No longer depends on: 800198
Depends on: 801949
Depends on: 806432
Depends on: 815462
Depends on: 818841
Depends on: 820506
Depends on: 821152
Depends on: 820061
Depends on: 823179
Depends on: 782972
Depends on: 797507
No longer depends on: 755084
Depends on: 828286
Depends on: 836768
Depends on: 840503
Depends on: 852101
Depends on: 860192
Depends on: 873401
Depends on: 875329
Depends on: 891074
No longer depends on: 891074
Depends on: 895245
Depends on: 948567
Depends on: 956498
Depends on: 812795
Depends on: 987590
Depends on: 1066435
Depends on: 1126940
Depends on: 1310625
Depends on: 1349824
Depends on: 1141098
Depends on: 1343544
You need to log in before you can comment on or make changes to this bug.