823508 - Indicate progress state when setting Call Forwarding

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[David Scravaglieri [:scravag]]

As a secondary priority, in Call Forwarding, we should also indicate progress state when a setting is toggled since these types of network features take time to set.

Split of bug 823506

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github WIP branch: https://github.com/jaoo/gaia/tree/823508

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7819

Kaze, this PR is about showing some info after setting up call forwarding. Right now there is no feedback at all. Here we also deal with an important issue which is the operator might not support disabling call forwarding for some reasons such as 'mobile busy', unanswered and 'no reachable'. In that case we show the corresponding alert to the user.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 706999 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7819

Vivien, Kaze is PTO. Could you take a look at this PR please?. See comment #2 for more information. Thx!

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 706999 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7819

Kaze will be back on monday so hopefully this bug will finally be reviewed!

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 706999 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7819

Arthur, this PR is about showing some info after setting up call forwarding. Right now there is no feedback at all. Here we also deal with an important issue which is the operator might not support disabling call forwarding for some reasons such as 'mobile busy', unanswered and 'no reachable'. In that case we show the corresponding alert to the user. I'm requesting review at you since you're so familiar with CF code ;).

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

There is an extra call to 'getCallForwardingOption' with this change. In 'updateCallForwardingSubpanels' we can also get the needed information. Is it possible to do the check and display alerts in that function? Then we can save one lengthy function call.

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #6)
> There is an extra call to 'getCallForwardingOption' with this change. In
> 'updateCallForwardingSubpanels' we can also get the needed information. Is
> it possible to do the check and display alerts in that function? Then we can
> save one lengthy function call.

Good suggestion. Done, take a look again please? Thx!

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 706999 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7819

r=me. Thanks for the work!

Comment 9

[José Antonio Olivera Ortega [:jaoo]]

https://github.com/mozilla-b2g/gaia/commit/8bff7dfcfcdd7165c605c98c70cf69d5cc8828d2

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Noming for tef+, it blocks bug 857691.

Comment 11

[James Lal [:lightsofapollo]]

This bug was partially uplifted.

Uplifted 8bff7dfcfcdd7165c605c98c70cf69d5cc8828d2 to:
v1-train: 34531cbc88eaee06aa57878669a074fee84632e0

Commit 8bff7dfcfcdd7165c605c98c70cf69d5cc8828d2 didn't uplift to branch v1.0.1

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

James, I'll uplift this bug once all the dependencies reach the corresponding branches/release repos. James, I'll contact you in case of I need help. Thanks a lot for your support in previous upliftings.

Comment 13

[José Antonio Olivera Ortega [:jaoo]]

v1.0.1: 052253176f3ad495a1086e47a28fffbf07613388

Comment 15

[Sarah Parsons]

Verified fixed on Unagi Build ID: 20130430070204

Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8ca8149ce236
Gaia: b525c25063d33d2e073d9f3e1e1164fadefec998

Also verified fixed on Inari Build ID: 20130430070201

Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: de0f1fc6c58616b8a33fca482f1f8684d4e74e9e

Call forwarding can be enabled.

Comment 16

[John Hammink]

Khepera_43949 depends on this bug, but is no longer blocked.

Comment 17

[Axel Hecht [:Pike]]

I got a question from a localizer, and I don't have an answer:

What does "Operation successfully set" mean. Is that just "Operation succeeded"?

Should we have a bug on a better wording then?

Comment 18

[Francesco Lodolo [:flod]]

(In reply to Axel Hecht [:Pike] from comment #17)
> What does "Operation successfully set" mean. Is that just "Operation
> succeeded"?

Maybe "Option successfully set", but I translated it exactly as "Operation succeeded". I guess a better wording would help.

Comment 19

[Niko Višnjić]

(In reply to Francesco Lodolo [:flod] from comment #18)
> 
> Maybe "Option successfully set", but I translated it exactly as "Operation
> succeeded". I guess a better wording would help.

Thanks Francesco, that makes more sense. Can we be more specific in the translation (and probably in the en-US original)? Since it's an indicator if the Call Forwarding operation did it's job, is "Call was forwarded successfully" adequate for positive feedback and analogously for the negative?

Comment 20

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Axel Hecht [:Pike] from comment #17)
> I got a question from a localizer, and I don't have an answer:
> 
> What does "Operation successfully set" mean. Is that just "Operation
> succeeded"?

Yes, it is.

> Should we have a bug on a better wording then?

"Operation succeeded" sounds fine IHMO.

Comment 21

[Axel Hecht [:Pike]]

Filed bug 893793.