850530 - B2G MMS: Use the same attribute name for delivery (s/state/delivery) like SMS

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

Please see the IDL proposal at Bug 760065. We need to s/delivery/state in nsIDOMMozSmsMessage, which sounds a better name and can be consistent with nsIDOMMozMmsMessage.

Comment 1

[Gene Lian (I already quit Mozilla)]

Currently, for reading a message's delivery state (ex, sent, sending, received... etc), we have to do something ugly like:

  if (message.type == "sms") {
    // read |message.delivery|
  } else if (message.type == "mms") {
    // read |message.state|
  }

because the new nsIDOMMozMmsMessage structure decided to use a better name |.state| instead of the nsIDOMMozSmsMessage's |.delivery|. If we also s/delivery/state in the nsIDOMMozSmsMessage, that will break the current Message App for reading SMS. However, the benefit is the Gaia codes don't need to consider different branches based on the message type.

Jonas and Mounir, may I have your preference regarding this issue? To do the renaming or not to do?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

make mms use the same name as SMS is for now

Comment 3

[Gene Lian (I already quit Mozilla)]

Got it. Thanks Jonas!

Comment 4

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Hi Jonas and Mounir,

This is a simple change. Let's use the same attribute name |.delivery| for MMS, which is compatible with SMS for now. Need super-review since it touches IDL. Thanks for your time.

Comment 5

[Gene Lian (I already quit Mozilla)]

This is a follow-up fix for bug 844431. Let's mark leo+ for this also.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Though in general you didn't need to make such a large change here. Simply changing the name of the API as exposed to JS would have been enough. I.e. a simple change in the .idl and the C++ functions would have been enough.

Comment 7

[Gene Lian (I already quit Mozilla)]

No worries. It doesn't bother. Just hoping to make sure the terminologies consistent with SMS for now as possible as we can to prevent others from getting confused between |delivery| and |state|.

Will land this later.

Comment 8

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/279b55d18083

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/279b55d18083

Comment 10

[Gene Lian (I already quit Mozilla)]

Attachment: [b2g18] Patch

Comment 11

[Gene Lian (I already quit Mozilla)]

Attachment: [b2g18] Patch

Comment 12

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/da47922ec8e5

Comment 13

[Gene Lian (I already quit Mozilla)]

Added [NO_UPLIFT] per recent commercial RIL compatibility issue. Waiting on further decision to keep the patch in b2g18 or to back it out.

------------------------------
If we really want to back them out, backing the following MMS bugs should be enough to make the commercial RIL compatible:

Bug 854422 - B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643)
Bug 850680 - B2G MMS: broadcast "sms-received" and "sms-sent" system messages
Bug 850530 - B2G MMS: Use the same attribute name for delivery (s/state/delivery) like SMS
Bug 852911 - B2G MMS: fail to expose correct nsIDOMMozMmsMessage.attachments.
Bug 853725 - B2G MMS: fail to read nsIDOMMozMmsMessage.receivers for a received MMS (a follow-up of bug 849741).
Bug 853329 - B2G MMS: other Android phones cannot read attachments sent from FFOS
Bug 852471 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) (follow-up fix)
Bug 852460 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event (follow-up fix)
Bug 849741 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event
Bug 847756 - B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead().
Bug 847736 - B2G MMS: provide nsIDOMMobileMessageManager.delete().
Bug 847738 - B2G MMS: provide nsIDOMMobileMessageManager.getMessage(). 
Bug 844431 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first)
Bug 845643 - B2G MMS: Save retrieved MMS into database.

Comment 14

[Gene Lian (I already quit Mozilla)]

Following the previous comment, some more needs to back out:

Bug 792321 - Check max values of MMS parameters in sendRequest.
Bug 833291 - B2G SMS & MMS: getMessages it's not working with PhoneNumberJS
Bug 844429 - B2G SMS & MMS: move SMS codes into dom/mobilemessage to make it generic for MMS
Bug 839436 - B2G MMS: make DB be able to save MMS messages.

Comment 15

[Gene Lian (I already quit Mozilla)]

Confirming with Michael to see we should back out to Bug 839436 or just Bug 844431 (if we eventually decide to back out). Please see Bug 857632, comment #17.

Comment 16

[Gene Lian (I already quit Mozilla)]

Per off-line discussion with Michael, we decided not to back out the MMS bugs that have already been in mozilla-b2g18. Removing [NO_UPLIFT] to make the check-in status sync'ed.