852471 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) (follow-up fix)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gene Lian (I already quit Mozilla)]

+++ This bug was initially created as a clone of Bug #844431 +++

Discovered some potential bugs when having integration with the Gaia end. Let's provide a follow-up fix.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 2

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee6267f0a9d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9ee6267f0a9d

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

(In reply to Gene Lian [:gene] from comment #1)
> Created attachment 726572 [details] [diff] [review]
> Patch

Do you want to deal with smil part in PDU header in other bug?
I mean....
"content-type":{"media":"application/vnd.wap.multipart.related","params":{"type":"application/smil","start":"<smil>"}}}

Comment 5

[Gene Lian (I already quit Mozilla)]

(In reply to Chia-hung Tai [:ctai :ctai_mozilla :cht] from comment #4)
> (In reply to Gene Lian [:gene] from comment #1)
> > Created attachment 726572 [details] [diff] [review]
> > Patch
> 
> Do you want to deal with smil part in PDU header in other bug?

Per off-line discussion, we've done that somewhere below in the SendTransaction() constructor so don't need to do that. ;)

Comment 6

[Gene Lian (I already quit Mozilla)]

This is a follow-up fix for bug 844431 which is also a leo+. Btw, it shocks me that we can clone the bug carrying on the leo+ but I believe it's illegal. Should let PMs to decide it again.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Ya the carrying forward of the blocking status is a pain - this doesn't in itself block we can track and take an uplift if low risk.

Comment 8

[Gene Lian (I already quit Mozilla)]

Comment on attachment 726572 [details] [diff] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 844431
User impact if declined: without this, the SMIL value isn't correctly wrapped for sending an MMS message. That is, the receiver would fail to interpret the SMIL sent from our FFOS phone.
Testing completed: yes
Risk to taking this patch (and alternatives if risky): no
String or UUID changes made by this patch: no

Note: this is just a simple follow-up for bug 844431 to correct some internal logic within the MMS module only, which doesn't touch other modules at all, so I believe this is pretty safe to land.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 726572 [details] [diff] [review]
Patch

Self-contained, low risk - approving for uplift.

Comment 10

[Gene Lian (I already quit Mozilla)]

Attachment: [b2g18] Patch

Comment 11

[Gene Lian (I already quit Mozilla)]

Attachment: [b2g18] Patch

Comment 12

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/48a62afa46c1

Comment 13

[Gene Lian (I already quit Mozilla)]

Added [NO_UPLIFT] per recent commercial RIL compatibility issue. Waiting on further decision to keep the patch in b2g18 or to back it out.

------------------------------
If we really want to back them out, backing the following MMS bugs should be enough to make the commercial RIL compatible:

Bug 854422 - B2G MMS: should call .NotifyResponseTransaction() with MMS_PDU_STATUS_RETRIEVED after an MMS is retrieved under the RETRIEVAL_MODE_AUTOMATIC mode (a follow-up for bug 845643)
Bug 850680 - B2G MMS: broadcast "sms-received" and "sms-sent" system messages
Bug 850530 - B2G MMS: Use the same attribute name for delivery (s/state/delivery) like SMS
Bug 852911 - B2G MMS: fail to expose correct nsIDOMMozMmsMessage.attachments.
Bug 853725 - B2G MMS: fail to read nsIDOMMozMmsMessage.receivers for a received MMS (a follow-up of bug 849741).
Bug 853329 - B2G MMS: other Android phones cannot read attachments sent from FFOS
Bug 852471 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first) (follow-up fix)
Bug 852460 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event (follow-up fix)
Bug 849741 - B2G MMS: provide nsIDOMMobileMessageManager.onreceived event
Bug 847756 - B2G MMS: provide nsIDOMMobileMessageManager.markMessageRead().
Bug 847736 - B2G MMS: provide nsIDOMMobileMessageManager.delete().
Bug 847738 - B2G MMS: provide nsIDOMMobileMessageManager.getMessage(). 
Bug 844431 - B2G MMS: provide nsIDOMMobileMessageManager interface (with sendMMS() first)
Bug 845643 - B2G MMS: Save retrieved MMS into database.

Comment 14

[Gene Lian (I already quit Mozilla)]

Following the previous comment, some more needs to back out:

Bug 792321 - Check max values of MMS parameters in sendRequest.
Bug 833291 - B2G SMS & MMS: getMessages it's not working with PhoneNumberJS
Bug 844429 - B2G SMS & MMS: move SMS codes into dom/mobilemessage to make it generic for MMS
Bug 839436 - B2G MMS: make DB be able to save MMS messages.

Comment 15

[Gene Lian (I already quit Mozilla)]

Confirming with Michael to see we should back out to Bug 839436 or just Bug 844431 (if we eventually decide to back out). Please see Bug 857632, comment #17.

Comment 16

[Gene Lian (I already quit Mozilla)]

Per off-line discussion with Michael, we decided not to back out the MMS bugs that have already been in mozilla-b2g18. Removing [NO_UPLIFT] to make the check-in status sync'ed.