854253 - Valgrind buildbot builds are burning due to absence of mozcrash

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

+++ This bug was initially created as a clone of Bug #844387 +++

+++ This bug was initially created as a clone of Bug #837754 +++

Valgrind builds are burning again, this time with:

Traceback (most recent call last):
  File "_profile/pgo/profileserver.py", line 18, in <module>
    from automation import Automation
  File "/builds/slave/m-cen-l64-valgrind-00000000000/objdir/_profile/pgo/automation.py", line 35, in <module>
    import mozcrash
ImportError: No module named mozcrash

Full 64-bit log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=21029440&tree=Firefox&full=1

Regression window:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1d6fe70c79c5&tochange=0e9badd3cf39

Either bug 827446 or bug 853219 might have broken this.

Comment 1

[(not currently active) Ted Mielczarek]

This was bug 827446. You can use the same fix we used for the profile runs, which is to invoke "make -C $(OBJDIR) pgo-profile-run" (bug 852509).

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> This was bug 827446. You can use the same fix we used for the profile runs,
> which is to invoke "make -C $(OBJDIR) pgo-profile-run" (bug 852509).

You mean run that instead of:

python _profile/pgo/profileserver.py --debugger=valgrind --debugger-args="$debugger_args" || exit 1

from http://hg.mozilla.org/build/tools/file/default/scripts/valgrind/valgrind.sh ?

How does one pass in the "--debugger=valgrind --debugger-args="$debugger_args" || exit 1" arguments into the make command?

Comment 3

[(not currently active) Ted Mielczarek]

Yes, instead of invoking the Python script directly. You can pass extra arguments in EXTRA_TEST_ARGS, like:
make pgo-profile-run EXTRA_TEST_ARGS='--debugger=valgrind --debugger-args="$debugger_args"'

(The quoting there probably isn't exactly right with the variable interpolation.)

http://mxr.mozilla.org/mozilla-central/source/testing/testsuite-targets.mk#375

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

As suggested.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 728824 [details] [diff] [review]
patch v1

Review of attachment 728824 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/valgrind/valgrind.sh
@@ +79,5 @@
>  
>  export OBJDIR=.
>  export JARLOG_FILE=./jarlog/en-US.log
>  export XPCOM_CC_RUN_DURING_SHUTDOWN=1
> +make pgo-profile-run EXTRA_TEST_ARGS="--debugger=valgrind --debugger-args=$debugger_args" || exit 1

Not totally sure if you need to double-quote the $debugger_args bit here. Have you tried running this on a local build just to be sure?

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Ted, you're right, I need to add another set of quotes, and the following works:

$ make pgo-profile-run EXTRA_TEST_ARGS="--debugger=valgrind --debugger-args='$debugger_args'"

expands to:

</snip> ./_profile/pgo/profileserver.py --debugger=valgrind --debugger-args='--error-exitcode=1 --smc-check=all-non-file --gen-suppressions=all --leak-check=full --num-callers=50 --show-possibly-lost=no --track-origins=yes'

Comment 7

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v2

Bringing over r+.

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

http://hg.mozilla.org/build/tools/rev/cfea27f9d7d5