874870 - Search plugins using POST broken in Firefox 23 Aurora, Firefox Nightly since 2013-05-17

Status: RESOLVED DUPLICATE of bug 873857

(Firefox :: Search, defect)

Description

[nemo]

I noticed that recently on my Nightly profile, DDG searches from the search bar were no longer being run.  Instead I was being sent to the main search page where I had to retype my search.

Reinstalling DDG search did not help.

After investigating in separate clean profiles, I found that if I visited https://duckduckgo.com/html/ and added the OpenSearch, the search worked fine in Firefox Stable, failed in Firefox Nightly.

Inspector network activity reported a normal POST of the search in Stable, but a GET with no parameters in Nightly.

Conclusion, someone broke search. ☹

Comment 1

[nemo]

Not an install problem, since profile where search was installed from stable still failed in nightly, while the search installed in nightly, still worked in stable.

Also diff of search.json and searchplugins xml seemed basically identical in both for the DDG entries.

Comment 2

[nemo]

Firefox Beta works correctly
Firefox Aurora is also broken

Comment 3

[nemo]

2013-05-16 works   (http://hg.mozilla.org/mozilla-central/rev/cc139752bed4)
2013-05-17 broken  (http://hg.mozilla.org/mozilla-central/rev/ea767da526ff)

No idea what would have caused it but:
changeset:   132074:8b36d359f889
user:        Mike de Boer <[e-mail]>
date:        Wed May 01 13:04:21 2013 +0200
summary:     Bug 862401: make sure nsDefaultURIFixup::KeywordToURI propagates POST data. sr=bz, r=gavin

Appears to be in that range and dealing w/ POST :)

I'll give bisecting further on local M-C clone a shot.

Comment 4

[Noah (NoahSUMO/SolidSnake) [:Noah]]

This is also affecting the Startpage search as well:
https://support.mozilla.org/en-US/questions/960009

Comment 5

[:Gijs (he/him)]

Related to bug 873857?

Comment 6

[nemo]

Hey. Same suspected culprit in bug comments. :)

Comment 8

[nemo]

$ hg log -r 'bisect(untested)' --template "{node} {desc|firstline}\n" 
c7df35aa72e16657a929f8442ed7810d442bad2b Merge m-c to fx-team
ed2c321c9bf68f5c3c36a1d3b472c8caba97b652 Bug 868806 - Handle OMXCodec's error. r=doublec
f2fcb63f7b91d6db1ebad89a478d29ab1e2ba3bc Bug 871853 - runapp.js: Don't call Services.obs.removeObserver with undefined. r=fabrice
814c3f4e202dd12326ac7b86e76102d522df97c4 Bug 872146 - Remove obsolete files. r=mdas
d7598c9a2708e301331ee4b122019e1ac1673a20 Bug 872852 - Turn on contacts mochitests on b2g. r=reuben
7c96200710881e6b40f351482ce54bbcd9af1ed5 Bug 849725: remove RIL.iccInfoPrivate.SPN.spn. r=allstars.chh
1e5c4b1cd4c4f8001507ecd5680440733f8ff3f1 Bug 872428 - Fix missing setForceUse to BT SCO for audio path, r=mwu
e4f4691407c2e3ca1dbf84261b0093dc22de6f55 Bug 871905 - Fix build error on android platform. r=vicamo
60f269b3934788b603409f229f1a021ce5f5da23 Merge m-c to birch.
a6ef5c1c61352c8fd95b1160374996ff9f5c24ec Bug 868932 - All channel volume is not updated. r=mwu
feccfce43b59135148e1185f78adb315c15ef982 Bug 860546 - Ignore content changes caused by key events. r=fabrice
c10b15688d5e50d01463121e8608cddad17f0816 Bug 873216 - Fixed a typo in `./mach help`; r=gps
8b36d359f8896b7d5fbbaafcc189e52eb808dfec Bug 862401: make sure nsDefaultURIFixup::KeywordToURI propagates POST data. sr=bz, r=gavin
1bfbe665c4e4bcee54a46afd71ebb9a3a7516ee2 Bug 873065 - Use DEVICESTORAGE_SDCARD for unknown file types. r=dhylands
f35b9c00f84b6cfee80e2f5b17958d75ad9f5269 Bug 872800 - Remove extraneous printfs added from Bug 858416. r=mchen
9d8ea345be128a69eb0aa9079b44a1f29038b6a3 Bug 872800 - Fix volume availability notifications for composite storage areas. r=mchen
77336d1d37f67757ad595e18ed1db0b6fd8931f9 Bug 872170 - Fix camera file saving with composite device storage. r=mikeh
b865c805fd5943c47f40fb4536081054a8d910b3 Bug 871510 - Some event handlers appear as undefined, hiding the appropriate null values in the prototype; r=msucan

Still running the bisect. Builds take a while and I have limited time for this.  But.  Note that that POST is in the list.  I think that pretty much confirms this is same culprit as was fingered in bug 873857

Comment 9

[nemo]

Er. Sorry for that prior pointless bug spam because... that last build took way less time :D
I forget that less and less changes as you bisect.

The first bad revision is:
changeset:   132074:8b36d359f889
user:        Mike de Boer <[e-mail]>
date:        Wed May 01 13:04:21 2013 +0200
summary:     Bug 862401: make sure nsDefaultURIFixup::KeywordToURI propagates POST data. sr=bz, r=gavin

CONFIRMED :D

Comment 10

[nemo]

Made description a bit more generic.

Comment 12

[Manuela Muntean [Away]]

- on an Ubuntu 12.10 32bit machine:

I wasn't able to reproduce this issue, neither with Nightly from 2013-05-17 or 2013-05-18, nor with Aurora 2013-05-22. The search performed from the search bar, after DDG was installed, works as expected.

With Firefox 23 beta 9 (build ID: 20130725195523), everything seems to work as expected also.

Does anyone have any thoughts/suggestions?

Comment 13

[nemo]

Manuela, you're probably not using the  non-JS DDG search.
That is, the one from:
https://duckduckgo.com/html/

Which I use 'cause of NoScript and no particular desire to whitelist 'em.

Comment 14

[nemo]

*sigh* Always reread *before* pressing the submit button, not *while* pressing it.

Well, let's try putting a bit more content anyway.
That is, please try removing the DDG addon, and installing the one from the link given.
You should see:
Add DuckDuckGo (HTML)

And once added the search in selection should say DuckDuckGo HTML

Comment 15

[Manuela Muntean [Away]]

Verified as fixed with Firefox 23 beta 9, build ID: 20130725195523, on: Ubuntu 12.10  32bit, Mac OSX 10.7.5 and Windows 8 32bit.

Thanks nemo! :)

Comment 16

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Verified as fixed on Firefox 24 beta 2 on Mac OS X 10.8.4, Ubuntu 13.04 32-bit and Win 7 64-bit.

Build ID: 20130812173056
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0