Closed Bug 881588 Opened 6 years ago Closed 6 years ago

message header is read-only when compose window is reused

Categories

(Thunderbird :: Message Compose Window, defect, major)

defect
Not set
major

Tracking

(thunderbird23 unaffected, thunderbird24+ fixed, thunderbird25 fixed)

RESOLVED FIXED
Thunderbird 25.0
Tracking Status
thunderbird23 --- unaffected
thunderbird24 + fixed
thunderbird25 --- fixed

People

(Reporter: jik, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

With current trunk, just pulled and rebuilt less than an hour ago, if I reply to a message and then reply to another message, thus reusing the compose window from the previous reply, then the message header (addresses, subject) is read-only in the second reply.
Keywords: regression
Confirmed in Tb/24.0a1 (Application Build ID : 20130610030658) on Win-XP.
- if mail.compose.max_recycled_windows=0, no problem.
- Reply/Reply All only problem. No problem in new mail, forward.
- When problem occurred, "Shift+Reply" + "immediate window close"
  + "Reply/Replay All again" (open/close with different mode once)
  is a simple recovery procedure.
Possibly due to bug 880595 - at least i don't see it with spellchecking diabled, and see it when it's on.
OS: Linux → All
Hardware: x86_64 → All
Depends on: 880595
(In reply to Magnus Melin from comment #2)
> Possibly due to bug 880595 - at least i don't see it with spellchecking
> diabled, and see it when it's on.

Same time frame for the regression - making bug depedant.
I confirm turning spell check off so far has made the problem go away. It was pretty bad - sometimes the 'send' button was not clickable even.
Depends on: 887010
Duplicate of this bug: 887323
Duplicate of this bug: 887458
Confirm the comment from Gene C - including the "Send" button being greyed out.
The comment #4 at https://bugzilla.mozilla.org/show_bug.cgi?id=880595 will hopefully mean that this associated bug will be closed at the same time when and if the patch referred to is confirmed to fix this problem?
See Also: → 889882
Duplicate of this bug: 890603
COnfirming - I'm seeing this pretty much continually, (Reported in duplicate Bug#890603) and Send is always disabled which makes it impossible to reply. 

For anyone caught by it ... the work around is 
Reply - get unusable window, but you won't notice till you look for Send.
Copy the message you just typed
Go back to message - 
hit Reply again - get usable window
Past message into it.
Hit Send
Close orginal window without saving Draft. 

You have to do it in this order or mostly it just reuses the screwed up window again. 

If someone wants help tracking it let me know - otherwise I'm going to have to do a reinstall to see if that makes it go away.
Reinstallation won't help. Go into the Config Editor (that's in the Options or Preferences menu item in the [≡] application button on the right-hand side of the main toolbar, then the Advanced > General tab, click Config Editor there).

Per comment #1, enter or copy-paste mail.compose.max_recycled_windows into the search bar and double-click on the entry that remains to change it to 0.
I'm seeing the Send problem even with max_recycled_windows at 0.  The way I work around it is to save and close the draft, then go to my Drafts mailbox, open the message again, and send it.
max_recycled_windows at 0 resolves it so far for me.
Is it known yet whether  attachment 773324 [details] [diff] [review] of bug 880595 resolves this?
Attached patch Proposed patch (obsolete) — Splinter Review
Since I couldn't work out how bug 887010 was going to help us, I took a different approach. Note: I tested the code in SeaMonkey and then ported it without testing on Thunderbird. Thus this patch also fixes bug 889882.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #778041 - Flags: review?(mbanner)
Tested on a local build:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Thunderbird/25.0a1 ID:20130718210143 CSet: d7237cd27263 
Built from http://hg.mozilla.org/mozilla-central/rev/0d0263a58f06
After importing this patch, it seemed to take care of the message header greyed out problem, but the inline spellcheck problem is still there when
mail.compose.max_recycled_windows=1
(but maybe this patch wasn't intended to address that issue)
(In reply to Joe Sabash from comment #15)
> the inline spellcheck problem is still there when
> mail.compose.max_recycled_windows=1
> (but maybe this patch wasn't intended to address that issue)

That's attachment 773324 [details] [diff] [review] in bug 880595.
Attached patch Alternative approaches (obsolete) — Splinter Review
This demonstrates two alternative uses of the spellCheckPending property although I haven't actually tested this version yet.
Attachment #779118 - Flags: feedback?(mbanner)
Comment on attachment 779118 [details] [diff] [review]
Alternative approaches

Review of attachment 779118 [details] [diff] [review]:
-----------------------------------------------------------------

I think I prefer this version best. It seems more deterministic.

::: mail/components/compose/content/MsgComposeCommands.js
@@ +3145,5 @@
>    if (gSpellChecker.enabled)
>    {
> +    if (gSpellChecker.mInlineSpellChecker.spellCheckPending)
> +    {
> +      setTimeout(addRecipientsToIgnoreList, 100, aAdressesToAdd);

I think I'd prefer this to use the observer method as you have done further down.
Attachment #779118 - Flags: feedback?(mbanner) → feedback+
Attachment #778041 - Flags: review?(mbanner) → review-
Duplicate of this bug: 897644
Attachment #778041 - Attachment is obsolete: true
Attachment #779118 - Attachment is obsolete: true
Attachment #781120 - Flags: review?(mbanner)
Comment on attachment 781120 [details] [diff] [review]
Alternative patch

Review of attachment 781120 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r+a=me for the CLOSED TREE and for aurora.

Thanks.
Attachment #781120 - Flags: review?(mbanner)
Attachment #781120 - Flags: review+
Attachment #781120 - Flags: approval-comm-aurora+
Pushed comm-central changeset 55edd6e9957e.
Pushed comm-aurora changeset d4eb28c60ab5, but I typo'd the bug#. Oops!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Duplicate of this bug: 896191
Duplicate of this bug: 889882
You need to log in before you can comment on or make changes to this bug.