891376 - Submitting an app using a locale not in the manifest results in a nameless app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Mathieu Pillard [:mat]]

Steps to reproduce:
- Create a new test app using http://testpackagedapp.appspot.com/
- Verify that the manifest inside the .zip file has translations for the name 
  of the app in a couple languages but not for the 'fr' locale.
- Using the developer pages in 'fr' (add ?lang=fr or change your browser
  settings to prefer french), submit your app.
- Notice that the app has no name in the submission process, the developer pages once the submission is done, and the reviewer pages, as long as you stay in french
- Once you switch to english everything works fine.

Initial investigation results: It's NOT bug 836147 (the locale is supported), not bug 888831 (We don't use the call_unless_empty macro here) and not bug 835407 either.

Looking in the database, I can only find an 'en-US' Translation for the name, and that's it. I expected to find a Translation for 'fr' with an empty string (which would have been a bug too, just a different kind :) but no. Even weirder is the fact that the Translations in other languages specified in the manifest aren't present either!

You can see the nameless app in action on -dev : https://marketplace-dev.allizom.org/developers/app/trapourin-bagrar-broardbasp/edit

Comment 1

[Andrew Williamson [:eviljeff]]

in the test app I note that the 'default locale' setting for the app is French.  Although the manifest itself mentions French no-where.

Comment 2

[Mathieu Pillard [:mat]]

So, here is what happens:
- The default_locale is used as the fallback. Because I was submitting in french, the default_locale we store in the marketplace gets set to french. This causes the nameless part because it has no 'fr' translation.

- The fact that there was only one translation in the db for the name is caused by a different issue, that's tracked in bug 893855

Comment 3

[Mathieu Pillard [:mat]]

Setting the default_locale for an app follows an interesting path:
- When submitting, we parse the manifest. This happens in files/utils.py, in WebAppParser.parse().
- This picks up the default_locale from the manifest, with a fallback on translation.get_language()
- But then, in addons/models.py, if the locale we picked up is the same as settings.LANGUAGE_CODE (i.e., it's 'en-US'), default_locale is overridden with translation.get_language() again!

Comment 4

[Mathieu Pillard [:mat]]

This is fixed in https://github.com/mozilla/zamboni/commit/0afc211cee97e07a7b7aa43c534817f5405c9385

See initial description for STR for testing on -dev. It's important to make sure the site is translated in any language not present in the manifest for the whole duration of the submission. To verify it's FIXED, in the details step, instead of noticing your app is nameless, you should see a name :-)

Comment 5

[Victor Carciu]

Verified as fixed : http://screencast.com/t/UuVe8xGKB3fb