History sidebar/Library scrolls to top when selected history entry is revisited

NEW
Unassigned

Status

()

defect
P3
normal
6 years ago
a year ago

People

(Reporter: alice0775, Unassigned)

Tracking

({regression})

22 Branch
x86_64
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox22 affected, firefox23- affected, firefox24- affected, firefox25- affected)

Details

Reporter

Description

6 years ago
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/04d8c309fe72
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130710 Firefox/25.0 ID:20130710030205

Steps To Reproduce:
1. Open History Sidebar and Change mode to "By Last Visited"
2. Scroll sidebar tree
3. Click any link(history, bookmark or link in page)

Actual Results:
History sidebar scrolls to top

Expected Results:
Scroll position of the tree should not lost
Reporter

Comment 1

6 years ago
Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/8b1bfcf0ce6e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130602 Firefox/24.0 ID:20130603074139
Bad:
http://hg.mozilla.org/mozilla-central/rev/e8a328c3e5bb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130603 Firefox/24.0 ID:20130603125714
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8b1bfcf0ce6e&tochange=e8a328c3e5bb


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2ff8cbefdf10
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130603 Firefox/24.0 ID:20130603075740
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d8cfe163b77d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130603 Firefox/24.0 ID:20130603081941
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2ff8cbefdf10&tochange=d8cfe163b77d

Regressed by:
d8cfe163b77d	Marco Bonardo — Bug 874407 - new visits are inserted incorrectly in the Library and the sidebar treeviews. r=Mano


This is a recent regression! 
Should not remove tracking flag.
Reporter

Updated

6 years ago
OS: Windows 7 → All
I think what happens is that the node is moved, and thus we move the view to its new position to ensure it's visible.
Not critical enough to track for upcoming releases. Would consider a low risk fix.
Reporter

Updated

6 years ago
Summary: History sidebar scrolls to top when a history entry added → History sidebar scrolls to top when a history entry clicked
Reporter

Updated

6 years ago
Summary: History sidebar scrolls to top when a history entry clicked → History sidebar/Library scrolls to top when a history entry clicked
Reporter

Updated

6 years ago
Duplicate of this bug: 900525
Reporter

Updated

6 years ago
Duplicate of this bug: 907403

Comment 6

6 years ago
Not to be unpolite,but this has surfaced in Firefox 22 and it's still there in Firefox 25 and all the pre-release versions that I've tried so far:and it's a very annoying bug,frankly.

Comment 7

5 years ago
i'd say, one of the majors browser option msth lol
firefox v27, with all v28 beta releases still already available &:

unfixed.

Comment 8

5 years ago
A temporary fix that's not perfect:

https://addons.mozilla.org/firefox/addon/bug892485_preventscrollonhi/

The addon has 3 other bugs:

1) if i make a search "by last visited", it disabled the addon, the scrollbar sends me back to the top.
2) if i try to click on the scrollbar arrow to slowly move up or down while a page is loading, the scrollbar sends me back to the top again .. .
3)  when i click on a link, the next link that's focused shouldn't be the one above, but always the "previous one", since i always revisit links from the last page accessed
in a specific position of the list .. .


This bug was introduced by:

Firefox Setup 22.0b4.exe

Comment 9

5 years ago
& every ten minutes or so, it scrolls back to top, it's free ))

Comment 10

5 years ago
This is so weird,we have to rely on an addon to restore the proper functionality of the browser's history?
I mean,this bug has been around for quite a while now,and while a lot of effort is going into questionable non-core features like social integration or sponsored tiles,the browser's history correct behavior has to be fixed by an addon?
Thanks a lot to the addon author,it's not the first time he has to fix some weird stuff,but shouldn't this be addressed where it belongs?
Resources with knowledge of the history code are reduced, the team that is working on what you define "questionable features" would not work on this code regardless.
So, please be patient, or investigate the cause and post a patch here.

Moreover the behavior here is still undefined, when you click on a history link, in a unique-uri list, that link gets moved up into the list (the view doesn't allow duplicates and you are viewing by-last-visited), after it moves it gets reselected and correctly the code scrolls to it, otherwise you would have a selection out of the view.
the alternative is to select the next entry in the list, while that may be correct for this specific view, it may be wrong for many others. So it's possible we need options to define the selection behavior for each specific view, that makes the fix non-trivial.
New addon update available:
https://addons.mozilla.org/firefox/addon/bug892485_preventscrollonhi/
Now 1.1 .. . author's pretention: fixes autoscroll

Result on ff 27.0.1 (stable release):

totally uneffective addon/"fix".

Comment 13

5 years ago
(In reply to Marco Bonardo [:mak] from comment #11)
> Resources with knowledge of the history code are reduced, the team that is
> working on what you define "questionable features" would not work on this
> code regardless.
> So, please be patient, or investigate the cause and post a patch here.

Sorry,it was not my intention to harass the people working on this specific issue:it just looked strange to me that an extension is currently needed to try to fix this bug.
As for "questionable features",well I stand by my definition:I suppose you too will agree that a fully functional,robust and versatile (think:queries) history & bookmarks database (on which I reckon you are working) is way more of a core function than social integrations or sponsored ads,of which you can have plenty with no need to bury them right into the browser.

> Moreover the behavior here is still undefined, when you click on a history
> link, in a unique-uri list, that link gets moved up into the list (the view
> doesn't allow duplicates and you are viewing by-last-visited), after it
> moves it gets reselected and correctly the code scrolls to it, otherwise you
> would have a selection out of the view.
> the alternative is to select the next entry in the list, while that may be
> correct for this specific view, it may be wrong for many others. So it's
> possible we need options to define the selection behavior for each specific
> view, that makes the fix non-trivial.

I didn't realize the fix had to be so complex,all I've noticed is that starting with Firefox 22 the usual behavior of the history sidebar was broken-BTW,I've tried the addon but apparently it doesn't fix the issue for this kind of visualization *by-last-visited*
Unfortunately,finding a fix is way beyond my reach,so I'll just be patient-thanks.
i confirm it msth, & the fix's author tells me "it works for me". so there's nothing we can do at this level.
by the way msth, you must have installed v1.1 of the addon, i listed the issues about the given addon above for 1.0, but it still works up to a level & its better than nothing, try not to update to v1.1, it seems to work for the author only for some reason. just keep that version:

https://addons.cdn.mozilla.net/_files/463298/bug892485_preventscrollonhistory-1.0-fx.xpi

until something new's offered.
(In reply to msth67 from comment #13)
> I didn't realize the fix had to be so complex,all I've noticed is that
> starting with Firefox 22 the usual behavior of the history sidebar was
> broken-BTW,

yes the behavior changed to what was originally designed (so the previous behavior was actually a bug), the fact it may not be what the user expects is another story that requires something more than a trivial patch.
Duplicate of this bug: 977460
(In reply to Marco Bonardo [:mak] from comment #16)
> yes the behavior changed to what was originally designed (so the previous
> behavior was actually a bug), the fact it may not be what the user expects
> is another story that requires something more than a trivial patch.

Could you share the details about why the original design called for this behavior to begin with?  (Alternatively, do you have a bug ID handy for the bug that "fixed" this?)
Summary: History sidebar/Library scrolls to top when a history entry clicked → History sidebar/Library scrolls to top when selected history entry is revisited
(In reply to Colby Russell :crussell from comment #18)
> Could you share the details about why the original design called for this
> behavior to begin with?  (Alternatively, do you have a bug ID handy for the
> bug that "fixed" this?)

Not very specific details, just that the views try to always keep visible the selected node. As I said, the fact it should be applied here is another story.

Updated

4 years ago
See Also: → 924028

Updated

3 years ago
Duplicate of this bug: 1129527
Priority: -- → P3
Duplicate of this bug: 1445806
Duplicate of this bug: 924028
You need to log in before you can comment on or make changes to this bug.