906617 - Change Gaia keyboard app to use the new composition methods in IME WebAPI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

After Bug 904530 is landed, before the word suggestion is not confirmed by the user, we need use composition related methods instead of directly sending keys to the input field.

The related changes reside in the latin IME engine of Gaia keyboard app.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Screenshot

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 802794 [details]
Screenshot

Hi Xulei,
I'm testing the setComposition API and found that there is no underline on it.
Is it the current design?

Comment 3

[Yuan Xulei [:yxl] (Leave from May 18)]

It is a bug with the setComposition API, which only occurs on device.

Comment 4

[Yuan Xulei [:yxl] (Leave from May 18)]

Bug 915079 was filed to track the composition text style issue.

Comment 5

[Luke Chang [:lchang] (inactive)]

Thanks, Xulei.

I have an additional question that I can't set the cursor of composition text to the beginning.
It will set the cursor position to the rear if I set the second argument of "setComposition" to 0.

Comment 6

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request

The Firefox nightly build appears to haven't supported the setComposition/endComposition APIs yet so I kept the original method as a fallback mechanism.

Comment 7

[Ivan Tsay (:ITsay)]

Nominate it to be a blocker due to functional issue

Comment 8

[Yuan Xulei [:yxl] (Leave from May 18)]

Firefox nightly build has supported |setComposition/endComposition|.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 803528 [details]
Pull Request

r=me with some nits/questions addressed.
Please refer to github pull request for details.

Luke, thanks.

Comment 10

[Luke Chang [:lchang] (inactive)]

Hi Xulei, I have two questions and need your help.

1. Firefox nightly 27.0a1 (2013-10-24) still appears not to support "setComposition / endComposition".
2. I can't just use "endComposition" to send a string if I don't call "setComposition" prior to it. Is it by design?

Thanks.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Luke, please help land this first and open another bug for tracking the question in comment 10.
Thanks.

Comment 12

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/13026103

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/f72cdd166202d6dafa084dfa12ab8ce292842750

Rudy, thanks for your review!

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Please help set the status so that this will get uplifted to v1.2 branch as well.
Thanks.

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f72cdd166202d6dafa084dfa12ab8ce292842750 to:
v1.2: 7685e70805e92f68e4c5d1773b5ce608256a1ee9

Comment 15

[Yuan Xulei [:yxl] (Leave from May 18)]

(In reply to Luke Chang [:lchang] from comment #10)
> Hi Xulei, I have two questions and need your help.
> 
> 1. Firefox nightly 27.0a1 (2013-10-24) still appears not to support
> "setComposition / endComposition".
The API has been exposed and supported, but bug 911951 broke it.
Thanks for reporting the bug. I'll fixed it soon.

> 2. I can't just use "endComposition" to send a string if I don't call
> "setComposition" prior to it. Is it by design?
Yes, it is by design. Though we don't suggest, you can use "replaceSurroundingText" instead of 
"endComposition" to commit text with or without calling "setComposition"
in advance.