90707 - mfcembed missing scroll bars

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect)

Description

[Tracy Walker [:tracy]]

seen on windows mfcembed for build 2001-07-13-07-trunk

-launch the app.

no scroll bars appear. The keyboard arrow keys scroll through the page

Comment 1

[Adam Lock]

This is an odd one. The classic skin is there but the browser isn't reading its 
contents.rdf and registering it as a skin. The net result is no scrollbars.

Looking at the code right now...

Comment 2

[Adam Lock]

The problem appears to be a weird rdf / chrome issue. Scroll bars aren't
appearing because 'chrome://global/skin/scrollbars.css can't be loaded. And
scrollbars.css can't be loaded because the skin/class/global/contents.rdf is not
read and registered, so it can't be found. 

I don't understand this one at all. All the files for skin/classic/global are
there (including contents.rdf), the installed-chrome.txt points to it, yet it
doesn't get registered into all-skins.rdf even when I delete the rdf files to
force it to happen. Instead I see an error like this when I start winEmbed:

*** Chrome Registration of skin: Checking for contents.rdf at jar:resource:/chro
me/embed.jar!/skin/classic/global/
WARNING: Trying old-style manifest.rdf. Please update to contents.rdf., file d:\
m\source_clean\mozilla\rdf\chrome\src\nsChromeRegistry.cpp, line 2017

There is a contents.rdf and to my untrained eye, it seems fine.

The weird thing is that skin/classic/global *does* get registered properly on
Linux so gtkEmbed has scrollbars.

As I am on vacation from now for 3 weeks I will reassign to the rdf people in
the hope of shedding some light on the issue. Why doesn't the
skin/classic/global/contents.rdf load in embed.jar? 

Comment 3

[:deanis74]

*** Bug 90748 has been marked as a duplicate of this bug. ***

Comment 4

[:deanis74]

Adding blocker and CC:s from duplicate bug.

Comment 5

[Chris McAfee]

*** Bug 92460 has been marked as a duplicate of this bug. ***

Comment 6

[Chris McAfee]

This shows up in TestGtkEmbed as well, marking all.

Comment 7

[Adam Lock]

*** Bug 95042 has been marked as a duplicate of this bug. ***

Comment 8

[Adam Lock]

Jeff Doozan spotted the problem, a line in embed-jar.mn spells "clasic" instead
of "classic". Thanks Jeff!

Patch follows. Can I have a review please?

Comment 9

[Adam Lock]

Attachment: Patch for the typo and another missing line added. Review please

Comment 10

[Chris McAfee]

r=mcafee

Comment 11

[Scott Collins]

sr=scc

Comment 12

[Adam Lock]

Fix is checked in.

Comment 13

[:deanis74]

*** Bug 95207 has been marked as a duplicate of this bug. ***

Comment 14

[Tracy Walker [:tracy]]

verified fixed on embed builds:

windows mfcembed 2001-08-14-06-trunk
linux TestGtkEmbed 2001-08-14-07-trunk