907977 - Link tapping broken in the b2g browser app.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[[:fabrice] Fabrice Desré]

I had no time to bisect, but tapping any link in the browser app is currently broken: I always get the "open in a new link" dialog that should only be triggered by a long tab leading to a context menu event.

That does not happen in apps so I suspect an azpc bug.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Device, version, changeset?

Comment 2

[[:fabrice] Fabrice Desré]

I only tested on keon, current gaia master (58be0d12c96cbc9f2c9b1b83adad4ce5d92bee65) and current b2g-inbound (317c2317495d)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Sorry, I think I broke this in bug 898443 as part of addressing a review comment and rebasing. Patch coming shortly.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Pretty simple patch - I was nulling out the variable too early, before doing the event processing. This was the accidental result of removing a local variable that I had in an earlier version.

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 794177 [details] [diff] [review]
Patch

Review of attachment 794177 [details] [diff] [review]:
-----------------------------------------------------------------

I can confirm that this patch fixes the issue, but I don't feel qualified to review. Bouncing to bgirard.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/b2g-inbound/rev/008abc8720e4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/008abc8720e4