Closed Bug 910354 Opened 12 years ago Closed 12 years ago

[e.me][feature] Add Collections

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sonmarce, Assigned: amirn)

References

Details

Attachments

(2 files)

Specs
115.54 KB, image/png
Details
redirect to PR 12546.html
210 bytes, text/html
crdlc
: review+
Details
No description provided.
Blocks: 1.3-e.me
Additional information: This is the flow: 1. Click on empty grid space. 2. A menu with 3 options come up. We were asked to unify the 2 options "add collections" and "custom collection". So now the flow should be like this: 1. Click on empty grid space. Click "add collection". (no change) 2. List comes up with suggestions (no change) 3. First item is "custom...". Click it. 4. Screen changes to custom collection naming (same as before) 5. When done (whether custom or from list) icon/s appear in currently displayed page.
Attachment #797318 - Attachment description: Smart Collections - Creating a custom Smart Collection.png → Specs
Assignee: nobody → amirn
Status: NEW → ASSIGNED
branch rebased on stg-pr, work still needed https://github.com/EverythingMe/gaia/tree/911234-add-collection-contextmenu
Summary: [e.me][feature] Change add Collection flow → [e.me][feature] Add Collection
Attachment #811947 - Flags: review?(crdlc)
Summary: [e.me][feature] Add Collection → [e.me][feature] Add Collections
Hi Amir, you have all my review ready on github
Thanks Cristian, I made fixes per your comments, PR updated.
Depends on: 922726
Comment on attachment 811947 [details] redirect to PR 12546.html Great work!! We have to work on adding a custom collection when we are offline. Please fill a follow-up. Thanks a lot
Attachment #811947 - Flags: review?(crdlc) → review+
the new follow-up will depend on this one, thanks a lot for your work done
Blocks: 923177
landed in master https://github.com/mozilla-b2g/gaia/commit/70969d4486afbabfac30ba62a9dc9df435fe4751
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
blocking-b2g: --- → koi?
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
Blocks: 930538
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: