923396 - Use source maps in the profiler

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P5)

Description

[Carl Sutherland]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.71 Safari/537.36

Steps to reproduce:

Enable source maps.
Run a profiler.
Navigate the tree (combined js files are listed)
Click the arrow to navigate to source.


Actual results:

It switches to the debugging console with no file selected.
Debugging console shows only source maps.


Expected results:

It would be nice if it displayed source maps in the tree.
At the very least, it should translate from the combined file to the source map in the debugging console.

Comment 1

[Nickolay_Ponomarev]

From dup bug 923858:
> Nick Fitzgerald [:fitzgen], comment 0:
> We should use source maps to get the original url/line/column/name of each
> function call in the profiler.

Comment 2

[Nickolay_Ponomarev]

Also copying the P3 assigned by Anton Kovalyov (:anton, @valueof) in the other bug...

Comment 6

[Tom Tromey :tromey]

I have a WIP patch from a while back that I'm going to attach.
Haven't really tried it and didn't write a test case.

Comment 7

[Tom Tromey :tromey]

Attachment: Bug 923396 - use source maps in performance tool

Change the performance tool to pass the sourceMapService down to the
Frame component, and to use the correct onClick binding.

Review commit: https://reviewboard.mozilla.org/r/182316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182316/

Comment 8

[Greg Tatum [:gregtatum] (REO Fx132)]

We're not planning on completing this work. Source maps will most likely be handled differently in the new recording panel. We'll file new bugs once we have the work figured out for how to implement that.