923548 - Australis: Sizing issues with completed download icon on OSX and Linux

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[anshin]

There are various issues with the new icons on Linux.
The address bar slightly overlaps the back button (but not the forward button).
The downloads icon is missing the tip of the arrow when there are unchecked downloads (the icon is green).

Here's a screencast showcasing both: http://i.wonoes.com/z7whprjcg.gif

Comment 1

[:Gijs (he/him)]

The star button also seems to have an issue where the star overlaps its menu button, if you hover the menu button and then move left over the star button.

Comment 2

[:Gijs (he/him)]

Bug 925710 has updated the back/fwd button stuff, that should be fixed now. I think the star button thing depends on bug 875479. I'll fix the downloads button here - it's also wrong on OS X.

Comment 3

[:Gijs (he/him)]

Stephen, could we have an updated completed-download icon (download-glow.png) for Linux and OSX that's 18x18? (ie matches the toolbar.png sizes; so 36x36 on OS X retina)

(if I should redirect this request elsewhere, please let me know, and feel free to reassign to you / someone else who could get us icons)

Comment 5

[:Gijs (he/him)]

Note that we should probably also have such an icon in the size that'd match the panel... see bug 930984. Assigning to Stephen pending new assets.

Comment 13

[Michael Maslaney [:mmaslaney] ([e-mail])]

Do you need the Download glyphs solo or in the toolbar.png sprites?

Comment 14

[:Gijs (he/him)]

(In reply to mmaslaney from comment #13)
> Do you need the Download glyphs solo or in the toolbar.png sprites?

They have always been solo before, so for simplicity, let's keep it like that. If we add them to the sprite, I'm afraid that at least on Windows/Linux (no hover styles), we'll need a new row just for that, which would be sadfaces.

Comment 15

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: Download-glow.zip

Contains the following:

• Download-glow - 18px OSX

• Download-glow - 36px OSX

• Download-glow - 18px Linux 

Based on Stephen's source files, toolbar icons for Linux are either 16px or 24px; providing the 18px as requested.

Comment 16

[:Gijs (he/him)]

Taking to integrate these assets. :-)

Comment 17

[:Gijs (he/him)]

Attachment: fix Australis download glow assets,

Patch with the new files, and the unused small version on linux removed.

Comment 18

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/b7d469a149e9

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7d469a149e9

Comment 20

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this issue on the latest Aurora (Build ID: 20140309004003) and latest Nightly (Build ID: 20140309030204), using:
- Ubuntu 13.10 64-bit [1]
- Mac OS X 10.9.1 [2]

1. Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0
2. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0