929230 - [B2G] [1.2] [l10n] [SIM Lock] All locales: Untranslated text when attempting to launch Cost control without unlocking the SIM

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of untranslated error message text

Description:
The error message that appears when the user attempts to launch the Costi (Cost control) app without unlocking the SIM is partially untranslated if the device is set to show the Italian language.

Repro Steps:
1) Update Buri to Build ID: 20131021004006
2) Set the device language to Italian and activate the SIM Lock.
3) Restart the device.
4) Launch the Costi app, closing all Inserire il PIN pages that appear.
5) Observe the error page that appears as the Costi app launches.

Actual:
The text of the error message above the dividing line is untranslated.

Expected:
The entire text of the error message is shown in the device's language.

Environmental Variables
Device: Buri 1.2 commercial RIL
Build ID: 20131021004006
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/d585fe28cd55
Gaia: 1fd315337d8ae891c3024e4c682c4c50797ea40e
Platform Version: 26.0a2
RIL Version: 01.02.00.019.082

Notes:
Repro frequency: 100%
See attached screenshot

Comment 1

[Francesco Lodolo [:flod]]

I'll need to check but I'm pretty sure this is not an Italian bug. Could be related to B2G strings missing (e.g. error pages).

Comment 2

[Francesco Lodolo [:flod]]

The only similar string I can find around is in toolkit
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/commonDialogs.properties#20

ScriptDlgHeading=The page at %S says:

@pike
Is this bug 893802 again?

Comment 3

[Axel Hecht [:Pike]]

Yeah. I guess using window.alert isn't great UX to begin with. It talks about app://costcontrol urls, which I think is confusing.

Moving over to Firefox OS, ux needed.

Comment 4

[Stephany Wilkes]

Axel, what is the UI need exactly? Is the question what the string of the error message should be?

Comment 5

[Axel Hecht [:Pike]]

The UI I'm concerned about the "The page at app://communications.gaiamobile.org/ says:"

Comment 6

[Chris Kreinbring [:CKreinbring]]

Also seen on the Bluetooth failed pairing error page.  The easiet way to repro is to attempt to pair to another device, then have that other device turn off their Bluetooth.

Comment 7

[Stephany Wilkes]

Axel, is it that you do not want the URL to be shown?

Comment 8

[Francesco Lodolo [:flod]]

I guess what Axel means is that we need a fully localized alert window (UI), not just a JavaScript alert which relies on strings that are not localized (or even fully localizable at the moment, considering repos, storage space, etc.).

Comment 9

[Axel Hecht [:Pike]]

And yes, I don't think we should show the URL. It's an internal implementation detail and doesn't help users to figure out what the problem is.

Comment 10

[Chris Kreinbring [:CKreinbring]]

Also seen when the user attempts to add an Everything.me app to the homescreen that is already present on the homescreen.

Comment 11

[Stephany Wilkes]

OK. So if I understand this correctly, this bug includes the following:
1) A request for a new string, without a URL.
2) To ensure the new string can be, and subsequently is, fully translated (I don't know if this is on L10N or dev side in terms of who is expected to do this work, or a bit of both, just that it's not UX).
3) To ensure the newly translated string fits the UI/vice versa (visual design).

To this end, I am flagging Matej to advise a new, URL-free string (per comment #3, and to suit the contexts noted in comment #6 and comment #10).

After this, we'll need to find someone for implementation and translation and then do a visual design check. Sound good? If not, please say so. Thanks!

Comment 13

[Matej Novak [:matej]]

Can someone give me an example of a similar error message that this could follow? I'm having a hard time understanding why we even need the top message. The one below seems sufficient.

If something is required there, could it just be the name of the app? Or maybe something like "Cost control encountered an error:" or "There was a problem opening Cost Control:"

(Either of those could also work as generic error messages for other apps.)

Comment 14

[Axel Hecht [:Pike]]

I'd be with you with just using the main message.

The real bug is that the code that triggers this message uses window.alert(l10n('sim locked')), and the alert code features the URL of the origin of that call. That part is hard-coded in gecko.

Comment 16

[Delphine Lebédel]

Nominating for koi? as this is an important issue

Comment 17

[Preeti Raghunath(:Preeti)]

Pike,

Can you please articulate why we wouldn't use the top message per comment 13?

Also, are we touching any strings?

Comment 18

[Wayne Chang [:wchang]]

Adding this to bug 893802. I think we should triage 893802 as a whole on if gecko translation should block?

Comment 19

[Francesco Lodolo [:flod]]

Not really sure about the dependency, considering that the current approach seems to be to just use non Gecko strings.

Comment 20

[Axel Hecht [:Pike]]

(In reply to Preeti Raghunath(:Preeti) from comment #17)
> Pike,
> 
> Can you please articulate why we wouldn't use the top message per comment 13?

Because it's not needed.

> Also, are we touching any strings?

No, we'd just be removing UI. It does involve adding code to replace the prompt popup, but that doesn't require new strings.

Comment 21

[Axel Hecht [:Pike]]

PS: Yes, I've removed the dependency on the gecko string l10n, as that string shouldn't really be shown to begin with.

Comment 22

[Tony Chung [:tchung]]

Here's what i understand.   Please correct me if i'm wrong, and renom koi? if its more important than we interpret this.

The error message that describes the cost control error is translated correctly.   
The header of the message (the URL part) is not translated.
** however, the URL part is a alert dialog and not translatable (per comment 8)

Therefore, what really should happen is a decision on:
1) convert the alert dialog to a translatable string -- which means code change
or 2) rip out the alert dialog portion and leave the already tranlated string (also code change)

Both 1 and 2 does not justify a koi+ argument at this time.  The user can see the translated error message, understand what to do about it, and move on.    

As for 1 and 2, perhaps someone should file a new bug on what to implement and punt to 1.3+.

Comment 23

[Francesco Lodolo [:flod]]

(In reply to Tony Chung [:tchung] from comment #22)
> Both 1 and 2 does not justify a koi+ argument at this time.  The user can
> see the translated error message, understand what to do about it, and move
> on.    

The user will see a mixed message: "The page at" and "says" will remain in English.
This is so evident that QA opened this a bug in my localization as "missing string".

Comment 25

[Francesco Lodolo [:flod]]

Can someone test this on a device where Usage works (i.e. not a Geeksphone)? Code doesn't seem to use an alert.

https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/widget.js#L242

I tracked the changes to bug 863778.

Comment 26

[Delphine Lebédel]

The SIM pins I have been given by IT are wrong, and therefore I have blocked all the sims I would need to verify this. They are getting back to me on Monday. Sorry for not being able to verify this sooner.

Comment 27

[Delphine Lebédel]

In the meantime, asking gbennett if possible to verify, please?
thanks

Comment 28

[Marina Rodríguez [:mai]]

Closed as worksforme, because of the app does not use alerts anymore. Since the Bug 963682 '[B2G] The user is given a message to input the SIM PIN just after entering the SIM PIN' was landed, the app uses an own screen to show the messages.

Regards.