Closed Bug 940844 Opened 6 years ago Closed 6 years ago

Australis: sync busy icon (sync pending) in menu is low quality/missing

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 31
Tracking Status
firefox29 --- verified
firefox30 --- verified
firefox31 --- verified

People

(Reporter: soeren.hentzschel, Assigned: Gijs)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [Australis:P3-])

Attachments

(3 files, 5 obsolete files)

Attached image sync-icon.png
STR:

1. move sync widget to new australis menu
2. click sync icon in menu
3. open menu while Firefox is syncing

Result:

see attached screenshot
Blocks: australis
Blocks: australis-merge, australis-cust
No longer blocks: australis
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(shorlander)
Summary: Australis: sync icon in menu is low quality → Australis: sync busy icon (sync pending) in menu is low quality
Assignee: nobody → shorlander
Flags: needinfo?(shorlander)
In Linux, the icon disappears entirely while Firefox is syncing.
This is with today's nightly & fresh profile, just configured to do a first-time sync. During that first sync, the Sync button (placed either in Australis menu or on toolbar) renders without any icon. (just as a transparent button, basically)
OS: Mac OS X → All
Summary: Australis: sync busy icon (sync pending) in menu is low quality → Australis: sync busy icon (sync pending) in menu is low quality/missing
Whiteboard: [Australis:P3]
Duplicate of this bug: 944462
Duplicate of this bug: 947915
Bug 947915 was not about the menu panel, but the tab toolbar. If duped it should be made clear that both locations need to be fixed!
I think this should get a higher priority since the "new Sync" and Firefox Accounts are a "top priority project" [1] and also planned for Firefox 29.

[1] https://wiki.mozilla.org/User_Services/Sync/Relaunch
I'm not sure if this is still going to be used by new sync. Tim?

Also, Michael, should this be yours as it's about the icon?

In the meantime, I almost wonder if we could just CSS animate the icon... that'd probably have its own set of issues. :-\
Flags: needinfo?(ttaubert)
Flags: needinfo?(mmaslaney)
Attached file Sync_Progress.zip (obsolete) —
Assets attached.

Sync progress interaction:
http://people.mozilla.org/~mmaslaney/Prototype/Sync_Progress.html
Flags: needinfo?(mmaslaney)
(In reply to mmaslaney from comment #8)
> Created attachment 8368553 [details]
> Sync_Progress.zip
> 
> Assets attached.

There's no "Linux" folder in that zip file -- just WinXP, 7, 8, OSX.  Presumably we need linux icons here as well? (or does Linux share another platform's sync icons?)
Flags: needinfo?(mmaslaney)
Daniel, I believe we are using OSX's glyph library for Linux.
Flags: needinfo?(mmaslaney)
(In reply to mmaslaney from comment #10)
> Daniel, I believe we are using OSX's glyph library for Linux.

Windows, but yes.
Attached file Sync_Progress.zip (obsolete) —
The Sync-busy interaction should be consistent across the UI, which means we will need it for not just the menu panel, but for the tool bar and horizontal bar (beneath the menu panel) as well. 

Updated animation to show the transition between busy and default.
http://people.mozilla.org/~mmaslaney/prototype/Sync_Progress.html

js file to follow.
(In reply to :Gijs Kruitbosch from comment #7)
> I'm not sure if this is still going to be used by new sync. Tim?

AFAIK we don't plan to touch the sync toolbar button. We're just replacing the identity provider so the button will still serve its current purpose.
Flags: needinfo?(ttaubert)
Whiteboard: [Australis:P3] → [Australis:P3-]
Is the screenshot in attachment 8335085 [details] still accurate? IIRC for a while we didn't even have a decent icon for the inactive state, but that seems ok now. So presumably the icon only looks crappy when the button is in the active state (ie, Sync is doing it's syncy stuff)?
(In reply to Justin Dolske [:Dolske] from comment #15)
> Is the screenshot in attachment 8335085 [details] still accurate? IIRC for a
> while we didn't even have a decent icon for the inactive state, but that
> seems ok now. So presumably the icon only looks crappy when the button is in
> the active state (ie, Sync is doing it's syncy stuff)?

Yes.
I'll take this the rest of the way, thanks Michael.
Assignee: mmaslaney → jaws
Status: NEW → ASSIGNED
Darrin, do you think you could take this?
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(dhenein)
Duplicate of this bug: 974329
(The current low-quality image is chrome://browser/skin/sync-throbber.png)
This supplies APNG throbbers for:
- Toolbar
- Menu Panel
- Horizontal Menu Panel Sync Button

The existing sync-throbber.png image can be replaced and removed.
Attachment #8368553 - Attachment is obsolete: true
Attachment #8370280 - Attachment is obsolete: true
Attachment #8370281 - Attachment is obsolete: true
Assignee: nobody → gavin.sharp
Assignee: gavin.sharp → nobody
Assignee: nobody → shorlander
QA Contact: shorlander
Attached patch update-sync-progress-icon.patch (obsolete) — Splinter Review
Updates the icon used when Syncing is active.

* Add icons for:
  - Toolbar
  - Toolbar Inverted
  - Menu Panel Grid
  - Sync Footer in Menu Panel
* Updates all syncProgress icons to be blue
* Removes the old sync button rules and moved sync=active rule with the rest of the toolbar button rules
Attachment #8393086 - Flags: review?(jaws)
Comment on attachment 8393086 [details] [diff] [review]
update-sync-progress-icon.patch

Review of attachment 8393086 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/osx/browser.css
@@ +1106,5 @@
>    toolbarpaletteitem[place="palette"] > #sync-button {
>      -moz-image-region: rect(0px, 768px, 64px, 704px);
>    }
> +  
> +  #sync-button[cui-areatype="menu-panel"][status="active"] {

nit, whitespace

::: browser/themes/osx/jar.mn
@@ +415,5 @@
>    skin/classic/browser/syncQuota.css
>    skin/classic/browser/syncProgress.css
>    skin/classic/browser/syncProgress-horizontalbar.png
>    skin/classic/browser/syncProgress-horizontalbar@2x.png
> +  skin/classic/browser/syncProgress-menuPanel.png

There is a syncProgress-menuPanel@2x.png image added as part of this patch and referenced in the osx/browser.css but it's not in the jar.mn.

::: browser/themes/windows/jar.mn
@@ +328,5 @@
>          skin/classic/browser/syncProgress-horizontalbar-XPVista7.png
> +        skin/classic/browser/syncProgress-menuPanel.png
> +        skin/classic/browser/syncProgress-toolbar.png
> +        skin/classic/browser/syncProgress-toolbar-inverted.png
> +        skin/classic/browser/syncProgress-toolbar-XPVista7.png

Can you please include @2x images for Windows too?
Attachment #8393086 - Flags: review?(jaws) → review-
Attached patch update-sync-progress-icon.patch (obsolete) — Splinter Review
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #24)
> Comment on attachment 8393086 [details] [diff] [review]
> Can you please include @2x images for Windows too?

I don't think we should add individual hidpi images for now. We can figure out a complete solution for bug 820679.
Attachment #8393086 - Attachment is obsolete: true
Attachment #8393109 - Flags: review?(jaws)
This patch doesn't deal with inverting the icon in the menubar on glassy Windows, or with Windows Classic themes. I'll add selectors for that when checking this in.
(In reply to :Gijs Kruitbosch from comment #26)
> This patch doesn't deal with inverting the icon in the menubar on glassy
> Windows, or with Windows Classic themes. I'll add selectors for that when
> checking this in.

This sounds like a code change that's significant enough that it would be subject to our code review guidelines. Can you please post an updated patch and get it reviewed by e.g. jaws?
Attachment #8393708 - Flags: review?(jaws)
Attachment #8393109 - Attachment is obsolete: true
Assignee: shorlander → gijskruitbosch+bugs
Status: NEW → ASSIGNED
remote:   https://hg.mozilla.org/integration/fx-team/rev/37d19c0c4411
Whiteboard: [Australis:P3-] → [Australis:P3-][fixed-in-fx-team]
Backed out in https://hg.mozilla.org/integration/fx-team/rev/45c0c5427302 for a build failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=36470197&tree=Fx-Team
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [Australis:P3-][fixed-in-fx-team] → [Australis:P3-]
Relanded with the missing Linux asset copied from Windows. :-|

remote:   https://hg.mozilla.org/integration/fx-team/rev/20c6f1700ebf
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [Australis:P3-] → [Australis:P3-][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/20c6f1700ebf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3-][fixed-in-fx-team] → [Australis:P3-]
Target Milestone: --- → Firefox 31
Comment on attachment 8393708 [details] [diff] [review]
Update Sync Progress Icon,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: sync icon looks bad in the menu when you're syncing
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low: mostly asset swap and new assets, couple of CSS changes
String or IDL/UUID changes made by this patch: none
Attachment #8393708 - Flags: approval-mozilla-beta?
Attachment #8393708 - Flags: approval-mozilla-aurora?
Attachment #8393708 - Flags: approval-mozilla-beta?
Attachment #8393708 - Flags: approval-mozilla-beta+
Attachment #8393708 - Flags: approval-mozilla-aurora?
Attachment #8393708 - Flags: approval-mozilla-aurora+
Verified that the sync icons are implemented accordingly to design on Windows 7 64bit, Ubuntu 12.04 and Mac OS X 10.9 using:
- Firefox 29 beta 2 (build ID: 20140324101726)
- latest Aurora (build ID: 20140324150430)
- latest Nightly (build ID: 20140324030203).
You need to log in before you can comment on or make changes to this bug.