948362 - [Gaia][Gallery] gallery application: handle data transfer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect, P1)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

+++ This bug was initially created as a clone of Bug #903253 +++

During the image sharing via NFC, data transfer needs to be handle.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

This is a cloned bug for gallery app. We don't need to depend on bug 903253

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

According to bug 933093, what we need to do is to put the following code at the correct place:
window.navigator.mozNfc.onpeerfound = function(nfcPeer) {
  // Negotiates WiFi or BT connection, presenting UI 
  nfcPeer.sendFile(blob); 
};

The correct place means where the app is under single file sharable context.

Comment 3

[Ken Chang[:kenkai]]

Bug 952217 is a blocker for this bug.

Comment 4

[Garner Lee]

Does gallery have nfc-manager permissions? If so, why does it need it?

952217 only hides a manager interface from the app, but the app level usage should not be changing, and should not block. The interface in question is:

    * Users of this API should have valid permissions 'nfc-manager'
    * and 'nfc-write'
    */
   DOMRequest checkP2PRegistration(DOMString manifestUrl);

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Diego, 
are you on top of this?

Comment 6

[Diego Marcos [:dmarcos]]

No. I'm not working on this at the moment. Do you want to take it?

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Actually I'm not a developer. Just trying to see if we can have a estimated time of landing. Let me initiate the schedule discussion offline.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

As offline discussion with Hema, I am taking over this bug.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch to share file through nfc

only upload this patch but not set review because this patch is tested in real workable device.

Comment 10

[saminath]

Attachment: 15682[1]

Hi John,

Find the patch for sharing Gallery Image/Video files. Necessary functions and handlers added.
Implementation Details:

1. Add/Remove the nfcpeerready_handler
2. Get the Current file from the opened Index
3. Check the file info either Video or Image
4. Get the Blob image of the File
5. Get the NFC peer connectivity
6. Send the File content
7. Handle the response of the transmission.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8364154 [details] [review]
patch to share file through nfc

1. add "onpeerready" callback when the video is in player view
2. remove "onpeerready" callback when the video is not in player view

To test this patch, we need to have the patch of the following bugs: bug 963471 (add this.doFileTransfer.bind(this) to nfc_handover_manager.js), bug 964672 (remove the doPair call in doFileTransfer), and bug 962310 (gecko).

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: gallery - NFC photo sharing

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: gallery - NFC video sharing

Comment 14

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/e6b5fc463f060b90615440c789378c11942e728c