903253 - [Gaia][Video] Video application: handle data transfer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect, P1)

Description

[Francis Lee [:frlee]]

During the video/image sharing via NFC, data transfer needs to be handle.

Comment 1

[Ken Chang[:kenkai]]

Hi dale, are you available to handle this bug?

Comment 2

[Dale Harvey (:daleharvey)]

We arent picking up bugs individually these days, the feature requests go in the product backlog so we can properly estimate and prioritise them and will be picked up during sprints

Comment 3

[Ken Chang[:kenkai]]

(In reply to Dale Harvey (:daleharvey) PTO - 28th Oct from comment #2)
> We arent picking up bugs individually these days, the feature requests go in
> the product backlog so we can properly estimate and prioritise them and will
> be picked up during sprints
Francis, can you please find a assignee for this bug.

Comment 4

[Francis Lee [:frlee]]

hi Dietrich,

are you working on Media functional team? if so, may you please let me know who can help on this issue?

Comment 5

[Kai-Chih Hu [:khu]]

Hi, Candice, can you help? Thanks!

Comment 6

[Kai-Chih Hu [:khu]]

Should we separate gallery and video into 2 different bugs(unless it belongs to the same developer)? 
Francis, what do you think?

Comment 7

[Kai-Chih Hu [:khu]]

John, are you the best person to help this bug? Thanks.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

We need to define the scope of this bug. If this is just to return the blob to the callback onpeerfound, it's me. If this is transferring the blob from onpeerfound to bluetooth, it's alive.

In NFC, I may have two parts: 1. hook onpeerfound API when our context is ready to share, 2. implement onpeerfound callback to return the context blob. Others are handled by system app.

Comment 9

[Francis Lee [:frlee]]

hi Kevin,

i have no objection to separate it into 2 bugs, but i know gallery,Video share same section of code in this case. i think John is in a better position to comment.

hi John,

what's your opinion for comment#6 ?

Comment 10

[Ken Chang[:kenkai]]

It seems better to finish this bug before sprint5. If you think it isn't reasonable, please update target milestone.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sorry for late replying, I also suggest to separate this bug into two bugs.

Comment 12

[Jason Smith [:jsmith]]

NFC is not a committed feature for 1.3, so this should not block the release.

Comment 13

[Jason Smith [:jsmith]]

Moving this over to the Video app component as the code changes being made here on the Gaia video app, not the NFC codebase.

Comment 14

[Hema Koka [:hema]]

Moving this to 1.4

Comment 16

[John Hu [:johnhu][:johu][:醬糊小弟]]

moves the dependency of 903252 to here.

Comment 17

[John Hu [:johnhu][:johu][:醬糊小弟]]

According to bug 933093, what we need to do is to put the following code at the correct place:
window.navigator.mozNfc.onpeerfound = function(nfcPeer) {
  // Negotiates WiFi or BT connection, presenting UI 
  nfcPeer.sendFile(blob); 
};

The correct place means where the app is under single file sharable context.

Comment 18

[John Hu [:johnhu][:johu][:醬糊小弟]]

A WIP patch can be found here:
https://github.com/huchengtw-moz/gaia/commit/de87f2706e01f91a3a6e30c11856f1530e230fc7

Comment 19

[Ken Chang[:kenkai]]

Bug 952217 is a blocker for this bugs.

Comment 20

[John Hu [:johnhu][:johu][:醬糊小弟]]

The feature detection had added to WIP patch:
https://github.com/huchengtw-moz/gaia/commit/fa9e3f3833316ff39a897e8135ed435a2bb50e64

(console.log still exists for debugging)

Comment 21

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: the patch for NFC

I just upload the patch but not set review because I haven't done the end to end test. No workable device now.

Comment 22

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8364131 [details] [review]
the patch for NFC

1. add "onpeerready" callback when the video is in player view
2. remove "onpeerready" callback when the video is not in player view

To test this patch, we need to have the patch of the following bugs: bug 963471 (add this.doFileTransfer.bind(this) to nfc_handover_manager.js), bug 964672 (remove the doPair call in doFileTransfer), and bug 962310 (gecko).

The video of a workable NFC sharing may be found at bug 948362.

Comment 23

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8364131 [details] [review]
the patch for NFC

Since David is too busy on other 1.3+ issue, transfer this review to George Duan who had read and write some patches for video apps.

Comment 24

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8364131 [details] [review]
the patch for NFC

This patch can successfully trigger nfc transfer when player shows.

r=gduan

Comment 25

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: video for nfc sharing

This video is record at offline reviewing for demonstrating the whole procedure to George.

Comment 26

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/d128d034bc0c2f53ee9f056b1aa28f0f3edbe5b2