960906 - [B2G] [Buri] Need system properties specifying the supported network types

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Arthur Chen [:arthurcc][inactive after 6/30]]

For all supported devices, we need system properties specifying the supported network types. Please refer to this comment[1] for the format.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=952043#c12

Comment 1

[Preeti Raghunath(:Preeti)]

Arthur,

What is the expectation here?

Should this be part of version notes?

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

We should have system properties as described in https://bugzilla.mozilla.org/show_bug.cgi?id=952043#c63 in the build, so that we can display correct network types in the list. Based on the comment the properties should be added by the partners.

Comment 3

[Preeti Raghunath(:Preeti)]

1.3+ - blocking a blocker

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Marco, can this be done by the device team or need help from the partners?

Comment 5

[Marco Chen [:mchen]]

Hi Shawn,

As we discussed, could you help to follow up this bug?

Thanks.

Comment 6

[shawn ku [:sku]]

Hi Arthur,
 Please let me know which projects still needing me to inform partner?
I believe codeaurora and SPRD are already aware of this.

See https://bugzilla.mozilla.org/show_bug.cgi?id=952043#c63

Thanks!!
Shawn

Comment 7

[shawn ku [:sku]]

Please check Comment 6.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for communicating this, Shawn! All devices should have these properties.

As the blocked bug 950185 was reported on Buri. How can we get the base image of Buri with the properties?

Comment 9

[shawn ku [:sku]]

Hi Arthur:
 I think Buri partner is also aware of this too.
(See https://bugzilla.mozilla.org/show_bug.cgi?id=952043#c58)

Add "[e-mail]" into CC list.
Thanks!!
Shawn

Comment 10

[Jason Smith [:jsmith]]

Is this a POVB bug (i.e. vendor bug)?

Comment 11

[Jason Smith [:jsmith]]

Unblocking this as this is a vendor bug.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

We need to have the following new property added into the base image:

ro.moz.ril.0.network_types=gsm,wcdma

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Vance, could you please communicate this with our partner?

Comment 14

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #13)
> Hi Vance, could you please communicate this with our partner?

Sure, and also let me check with QCT to see if they already integrated this into 7x27/8x10 1.3 release.

Dear Anshul, could you help to check if you have added the following property into the 1.3 release of 7x27 and 8x10?

ro.moz.ril.0.network_types=gsm,wcdma

Thanks

Vance

Comment 15

[Anshul]

(In reply to Vance Chen [:vchen][[e-mail]] from comment #14)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #13)
> > Hi Vance, could you please communicate this with our partner?
> 
> Sure, and also let me check with QCT to see if they already integrated this
> into 7x27/8x10 1.3 release.
> 
> Dear Anshul, could you help to check if you have added the following
> property into the 1.3 release of 7x27 and 8x10?
> 
> ro.moz.ril.0.network_types=gsm,wcdma
> 
> Thanks
> 
> Vance
What's the need for this property when there already exist an RIL API RIL:GetSupportedNetworkTypes that we already support?

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Anshul from comment #15)
> (In reply to Vance Chen [:vchen][[e-mail]] from comment #14)
> > (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #13)
> > > Hi Vance, could you please communicate this with our partner?
> > 
> > Sure, and also let me check with QCT to see if they already integrated this
> > into 7x27/8x10 1.3 release.
> > 
> > Dear Anshul, could you help to check if you have added the following
> > property into the 1.3 release of 7x27 and 8x10?
> > 
> > ro.moz.ril.0.network_types=gsm,wcdma
> > 
> > Thanks
> > 
> > Vance
> What's the need for this property when there already exist an RIL API
> RIL:GetSupportedNetworkTypes that we already support?

Hi Anshul, correct, gaia gets the supportedNetworkTypes through the RIL API. But gecko depends on correct hardware configuration to expose the types to gaia. That's why we are asking for this. Does that make sense?

Comment 17

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

per Comment#16, ni Anshul for feedback

Comment 18

[Anshul]

Vance, we don't support this property as the name looks very specific to moz ril.

Comment 19

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

(In reply to Anshul from comment #18)
> Vance, we don't support this property as the name looks very specific to moz
> ril.

Thanks for the feedback Anshul

Dear Hsin-Yi -

Is this property specific for Moz RIL only? if so, we need to ask partners to add this property to each device in order to make that device working with Moz RIL

Thanks

Vance

Comment 20

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Vance Chen [:vchen][[e-mail]] from comment #19)
> (In reply to Anshul from comment #18)
> > Vance, we don't support this property as the name looks very specific to moz
> > ril.
> 
> Thanks for the feedback Anshul
> 
> Dear Hsin-Yi -
> 
> Is this property specific for Moz RIL only? if so, we need to ask partners
> to add this property to each device in order to make that device working
> with Moz RIL
> 

Yes, this is for MozRIL. Per my understanding, we've asked tarako, fugu, madai to add this.
For Buri case, I think we are fine to set our default value as "wcdma/gsm" instead of the world phone types. That is, we should be fine without buri base image updated. Please see Bug 990383.

> Thanks
> 
> Vance

Comment 21

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

For today's Tarako build : 
adb shell getprop ro.moz.ril.0.network_types
gsm

Gaia      33025a8b1e458ef48cb8b7fb81bdaba28c86b183
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/161d4b0448c6
BuildID   20140606014002
Version   28.1
ro.build.version.incremental=eng.cltbld.20140606.050809
ro.build.date=Fri Jun  6 05:08:16 EDT 2014
Tarako

I would think this needs to block ship if the configuration isn't set right...

Comment 22

[Joe Cheng [:jcheng] (please needinfo)]

hsinyi, does it impact tarako? and what is the end user impact of this if any? thanks

Comment 23

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Joe Cheng [:jcheng] from comment #22)
> hsinyi, does it impact tarako? and what is the end user impact of this if
> any? thanks

Tarako needs different configurations. We already have the right configuration for tarako.
See https://bugzilla.mozilla.org/show_bug.cgi?id=980831, so this shouldn't block 1.3T.

Comment 24

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I close this bug as WONTFIX since we provided a gecko solution on bug 990383 so buri doesn't have any problem now. But note that if any other device needs particular configurations, then bask.mk still needs modification.

Comment 25

[[:RJ]]

Not enough information with current STR to write test case to address bug.

Comment 26

[KTucker [:KTucker][Inactive 3/4/2016]]

No test case added. We don't know how we could test this properly and the bug has been resolved as WNF.