966224 - [VDR][Contacts] Apply Buttons and Input areas [BB]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[José Vittone]

Attachment: contact-detail-changes.png

Contact's detail should:

1. Have white background.
2. Align icon inside buttons to the right.
3. Use by default colors in buttons, don't force them to white.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: After patch: contact_details_1

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: After patch: contact_details_2.png

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: After patch: edit_contact_1.png

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: After patch: edit_contact_2.png

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Thanks Vicky ;)

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8372284 [details] [review]
patch in github

Looks OK for me :)

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Please do not merge this, as this feature could be for 1.5

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 530b6671255e50b8f9b45c2ef96c468e3a374422

Comment 10

[Gabriele Svelto [:gsvelto]]

A quick heads up on this, the new files that were added in this commit have not been properly re-compressed before inclusion. Please do so in a follow-up or on this bug as it provides significant space savings. You can re-compress then new assets with the following command from gaia's root directory:

./tools/png_recompress.sh -v \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/call.png \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/link.png \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/location.png \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/mail.png \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/plus_sign.png \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/sms.png \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/buttons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/forms/add.png \
    apps/communications/contacts/style/gphx/bitmap/default/forms/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/forms/delete.png \
    apps/communications/contacts/style/gphx/bitmap/default/forms/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/forms/undo.png \
    apps/communications/contacts/style/gphx/bitmap/default/forms/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/vw-header/icons/fav-star.png \
    apps/communications/contacts/style/gphx/bitmap/default/vw-header/icons/[e-mail] \
    apps/communications/contacts/style/gphx/bitmap/default/vw-header/icons/[e-mail] \
    apps/communications/contacts/style/images/findandmerge.png \
    apps/communications/contacts/style/images/[e-mail] \
    apps/communications/contacts/style/images/[e-mail] \
    apps/communications/contacts/style/images/icon-fav-button-off.png \
    apps/communications/contacts/style/images/[e-mail] \
    apps/communications/contacts/style/images/[e-mail] \
    apps/communications/contacts/style/images/icon-fav-button-on.png \
    apps/communications/contacts/style/images/[e-mail] \
    apps/communications/contacts/style/images/[e-mail]

You'll need the advancecomp and optipng 0.7+ packages installed for the script to work. Feel free to ping me if you need assistance.

Also the [e-mail], [e-mail] and [e-mail] files seem to be missing, is that expected or were they forgotten?

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Another point, could we have a contacts peer just to sign off the patches?

I know this is quite simple and just related to UX but still, we should follow the same rules.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Francisco Jordano [:arcturus] from comment #11)
> Another point, could we have a contacts peer just to sign off the patches?
> 
> I know this is quite simple and just related to UX but still, we should
> follow the same rules.

By simple I mean the process of sign off the patch, cause the real validation comes from Arnau, IMHO.

Comment 13

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Sorry guys, I didn't ask you for review as all code was css/html and Pavel is one of the few experts in the project. I'll ask module owners/peers in future.

About png compression, I trusted the VD member who gave me the assets and did not double check.
At the moment of creating this PR he told me @2x files were not required.
I will create a new patch to add/compress them.

Comment 16

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Note for QA:
Please note that current UI could differ from the attached captures with the ui-review, as building blocks for inputs have changed in bug 981882: https://bug981882.bugzilla.mozilla.org/attachment.cgi?id=8392901

Now inputs have full border, and colors may be slightly different.
You can reach me in case of UI inconsistencies :)

Comment 17

[Loli (:lolimartinezcr)]

Tested and fine
2.0
Hamachi
Gecko: 4939134
Gaia: 32a9e3d
Platform version: 31.0a1
Build ID: 20140428080023
Git commit: 473dd9f3