972833 - [Dialer][Conference call] One to one call page after multiconference is wrong

Status: RESOLVED DUPLICATE of bug 1003846

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

This issue reproduces in master (Gecko-b921aba.Gaia-3d01dbc). The issue DOES NOT reproduce in v1.3 (Gecko-98d7015.Gaia-22e065f).

STR:
1. Using the DuT, make a call to any phone number.
2. Take the call in the called phone.
2'. The DuT shows the 1 to 1 on call page depicted in "Attachment 1 [details] [diff]".
3. In the DuT, make a second call using the "phone +" button to a second phone number.
4. Take the call in the second called phone.
4'. The DuT shows the ongoing group call page depicted in "Attachment 2 [details] [diff]".
5. In the DuT, merge both calls (the on hold and the ongoing one).
5'. The DuT shows the ongoing conference call page depicted in "Attachment 3 [details] [diff]".
6. Hang the call on any of the 2 called phones. Not on the DuT.

OBSERVED.
6'. The DuT shows what seem to be an ongoing "conference call" but only with one party (the one which did not hang up) as depicted in "Attachment 4 [details] [diff]". NOK!

EXPECTED
6'. The DuT shows the ongoing one to one call page depicted in "Attachment 5 [details]". OK!

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Attachment 1

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Attachment 2

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Attachment 3

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Attachment 4

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Attachment 5

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

MENTAL NOTE TO MYSELF: Do not use the text "Attachment N" on comments in Bugzilla unless N is the id (number) of the attachment as generated by Bugzilla. Use "Screenshot N" or "Image N" :-p Sorry about that! ;-)

Comment 7

[Noemí Freire (:noemi)]

Per comment 0 regression in master so nominating to v1.4?

Comment 8

[Matthew Vaughan]

I am actually able to reproduce this issue on the 1.3 build on a Buri, and therefore have found a regression window for said version.

This issue appears to have started reproducing on the 11/21/13 1.3 build.

- Works -
Device: Buri v1.3 MOZ RIL
BuildID: 20131120040202
Gaia: c26480b22ce28c812c347290dd4bad090d83db6f
Gecko: 4f993fa378eb
Version: 28.0a1
Firmware Version: V1.2-device.cfg

- Broken -
Device: Buri v1.3 MOZ RIL
BuildID: 20131121040202
Gaia: 71063dd91bc8cbb15ba335236ed67a1c5058bd58
Gecko: cf378dddfac8
Version: 28.0a1
Firmware Version: V1.2-device.cfg

Comment 9

[Jason Smith [:jsmith]]

While this is a regression, I think this is a minor. The information is all there available to the user, even though the visual design isn't fully correct. Not blocking for 1.3.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

rik, is this something that can be fixed easily? with low risk? thanks

Comment 11

[Anthony Ricaud (:rik)]

It looks like a case where updateSingleLine is either not called or not giving the proper answer. If it's updateSingleLine not being called, it's a non-risky patch. If it's a case of not giving the proper answer, it might be a bit risky but we'll see with the patch.

Running |git log --no-merges c26480b22ce28c812c347290dd4bad090d83db6f...71063dd91bc8cbb15ba335236ed67a1c5058bd58 -- apps/communications/dialer|

It's either a regression of bug 920414 (621cd71f48c0bbd5bf76e5a0b8eb67a7cf4dc0e7) or bug 923646 (f9255a5eff06bf4890d7043b439e315ba4d4bb76).

Comment 12

[Noemí Freire (:noemi)]

Hi,

Attaching 2 screenshots showing the visual gap between the UX proposal and the current implementation for the following scenarios:
scenario a- one to one call screen after conference call (existing contacts)
1. Wrong font size
2. Ellipsis issue (see Bug 974320)
3. Wrong background size
4. Wrong layout
 
 
scenario b- one to one call screen after conference call (non-existing contacts)
1. Wrong background size
2. Wrong font size and color
3. Wrong layout

Comment 13

[Noemí Freire (:noemi)]

Attachment: a- one to one call after conference call (existing contact)

Comment 14

[Noemí Freire (:noemi)]

Attachment: b- one to one call after conference call (non-existing contact)

Comment 15

[Noemí Freire (:noemi)]

Triage: regression, so blocking, the issue reported in the description should be solved for v1.4, we will open an independent bug gathering the VR changes (Comment 12, 13 and 14). thanks!

Comment 16

[Noemí Freire (:noemi)]

(In reply to Noemí Freire (:noemi) from comment #15)
> Triage: regression, so blocking, the issue reported in the description
> should be solved for v1.4, we will open an independent bug gathering the VR
> changes (Comment 12, 13 and 14). thanks!

Once solved the issue reported in https://bugzilla.mozilla.org/show_bug.cgi?id=972833#c0, the VR part for one to one call scenario will be completed within bug 976512.

Comment 17

[Jason Smith [:jsmith]]

The question I'd like to understand here:

Why would we block on this if this already exists on 1.3?

Renoming to answer that question.

Comment 18

[Preeti Raghunath(:Preeti)]

Moving to backlog and consider for Dialer top 10 issues to fix

Comment 19

[Germán Toro del Valle (:gtorodelvalle)]

This bug has been solved in bug 1003846 when including the call duration ;-)