97310 - offline: messages deleted, while offline, with the delete model 'remove immediately', reappear when going back online

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[Jack Angel]

I have IMAP account. I have selected to download messages for off-line use. I
think when they download it could be more informational (I don't know which are
downloaded and which are not yet). In the status bar is the number of messages.
Then "Document: Done" is displayed, I disconnect from the net, look through the
messages and find that not all of them are downloaded. This is the first.
Then, I delete some of the messages. When I connect and press get messages again
these, should be deleted messages, are downloaded again! It seems that messages
on servers are not deleted. I receive big messages so would like to have an
option to have messages deleted from server immediately after download to my
local folders.

Comment 1

[grylchan]

Reporter we need more information please.

First what is the build Id you are using (including date)
and platform?

For Imap, what type of deletion model are you using?
  -move it to trash
  -remove it immediately
  -mark as deletd

Could you give a little bit more detailed steps in what your
exact steps are? new or old profile?
I'll try to answer some of your statements:

>think when they download it could be more informational (I don't know which are
>downloaded and which are not yet).

 I assume you are in classic theme mode and not modern?
 Modern theme you can tell by the envelope in thread pane (in the subject
 column). A white envelope means it's downloaded. A dark gray means it
 hasn't been downloaded.
 There are 2 bugs on this
   1. change icons to something more distinguishable bug 86897
   2. need icons for classic theme bug 67359

>In the status bar is the number of messages.
>Then "Document: Done" is displayed, I disconnect from the net, look through the
>messages and find that not all of them are downloaded.

 Do you have disk space pref "do not download msgs locally that are larger
 than x kb" set? There is bug that even if this not checked mesgs greater
 than x kb will not get downloaded, bug 96335

And in terms of mesgs not being deleted when you are offline from server,
it works fine for the 'move it to trash can' mode. Other 2 modes I'm not
sure. 

I assume you have trash mode set to remove it immediately?
If that is case, you are correct about deleted mesgs coming back with
a 'get mesg'.

Comment 2

[Jack Angel]

Build is 2001080104 under linux (kernel 2.4.9).

I tried move to trash, and it does absolutely nothing. I press delete and
nothing happens. Well, maybe it tries to start connecting to server but after a
few next seconds message is still in the message pane, and I'd like to have full
control on it, e.g., when I say delete, it must be deleted immediately. I don't
like mark as deleted in the same way. I just don't want to see deleted message
if I deleted it. Not even with the red cross. So I use remove immediately. Well,
it'd fix problem of messages getting again after deletion if you add an option
such as "Don't leave messages on server". Most programs I have seen have option
"Leave messages on server", and it's by default off in most of them, so I don't
know why mozilla's mail doesn't have that option and automatically leaves messages.
I'm in modern theme. But until you said, I haven' noticed the letters. Maybe
display downloaded messages with italic font? That part of my message may be
considered as dupe of bug 86897, but not other parts.

I don't have option not to download msg greater than x kb, but two of my
messages (bigger than others) re-download each time I want to re-read them.
Yeah, it should be same as bug 96335.

So, this bug now only covers deletion of messages and coordination of such
deletion with msgs on server. I personally want just one thing, to have "Don't
leave messages on server" option enabled. Don't thing it's hard programming
task. But I think, for others' sake, that bug with instant deletion and then
getting deleted msgs
again should be fixed too.

Comment 3

[grylchan]

Reporter, there is no IMAP option for "Don't leave messages on server".

If you have a POP account there is a pref "Leaves messages on server".

If remove immediately were working properly than I don't think
your request for a pref like "don't leave messages on server"  is
needed.

Italic font for downloaded messages was in previous builds,
you SHOULD NOT see it with any of the recent trunk builds.

Since this bug is now only a problem with deleted mesgs
on server using 'remove immediately' trash mode,
I'm changing the summary line to be more descriptive.

Old summary line was: Not all messages downloads for off-line, also message 
deletion doesn't reflects on messages on server

Steps to reproduce:

1.Create a imap mail account
2.Edit|Mail/News Account settings
3.Go to your imap mail account and select 'Server Settings'
4.Change drop down box for When I delete a message to
   'Remove it immediately'
5.click ok.
6.Download few mail messages
7.Go offline
8.Delete some downloaded/non-downloaded messages
9.Messages are removed immediately from folder
10.Go online
11.Do a "Get Mesg" or click on account, then click read messages on the 
   account central web page

Result: the messaages you just deleted, reappear in your folder as brand
        new messages
Expected: the deleted messages to not reappear

Tested current 4.x build and it works correctly. Messages don't reappear
when you do a get mesg.

Changing status from uncofirmed to new.

Comment 4

[Jack Angel]

why you removed italic font stuff?
it should be great idea!

yeah, there's no such option in IMAP mode, and it's bad. 
imagine person who have 20mb allowed space in his mailbox and 1mb mail arrives
each day
mailbox'll get overwhelmed in 20 days and he should be manually flushing it
say he also like "delete immediately" mode and has IMAP mailbox

when that 4.x build will get released?
i thought i was using the latest version 0.9.3 (build id 2001080104) ?!

Comment 5

[grylchan]

Italics were a temporary solution. The envelope icon is now
being used to distinguish between downloaded/non-downloaded
mail messages.

4.x refers the old Netscape Communicator browser, currently
at version 4.78. You already have the 'current' browser.

Comment 6

[Jack Angel]

that means there wasn't such a big in earlier version and now it is happening?
it'd be cool to have an OPTION in preferences to have both envelope icons and
italics/only icons/only italics
i personally liked italics because it's quite more distinguishable than some
small similar icons

Comment 7

[grylchan]

Marking as dupe of bug 96631.

*** This bug has been marked as a duplicate of 96631 ***

Comment 8

[David :Bienvenu]

reopening, appears not to be a duplicate since it still happens though the other
bug is fixed.

Comment 9

[castagna]

Let me add my two cents' worth.

I have the same problem, different configuration:
RedHat 7.0, kernel 2.2.19, Ximian Gnome 1.4, use Imap server and  Mozilla 0.9.5
and nightly 2001101611 I just cut and paste the way to reproduce it:


Steps to reproduce:

1.Create a imap mail account
2.Edit|Mail/News Account settings
3.Go to your imap mail account and select 'Server Settings'
4.Change drop down box for When I delete a message to
   'Remove it immediately'
5.click ok.
6.Download few mail messages
7.Go offline
8.Delete some downloaded/non-downloaded messages
9.Messages are removed immediately from folder
10.Go online
11.Do a "Get Mesg" or click on account, then click read messages on the 
   account central web page


Also, if you use remove from trash and mark it as deleted, then no problem.

For what it concern italics for downloaded messages ... well it was great as I
really cannot see the differences on my LCD laptop screen.

Comment 10

[Christopher Hoess (gone)]

milestone->0.9.7

Comment 11

[David :Bienvenu]

moving out tfv

Comment 12

[David :Bienvenu]

change summary

Comment 13

[David :Bienvenu]

nominating - this would be a pain if you had that delete model.

Comment 14

[David :Bienvenu]

Attachment: proposed fix

only get flags from existing hdr, ignore if we don't have the header (which
means the msg has been deleted). 4.x GetMsgHdrFromKey would only return hdr if
it existed.

Comment 15

[David :Bienvenu]

cc'ing Navin for review.

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 68006 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 17

[Navin Gupta]

So in both cases we will get null header, right? I am missing something.

Comment 18

[Navin Gupta]

Comment on attachment 68006 [details] [diff] [review]
proposed fix

Now I know, GetMsgHdrForKey
will create the hdr
if it doesn't find one.

r=naving

Comment 19

[David :Bienvenu]

fix checked in.

Comment 20

[David :Bienvenu]

Gary, could you see if this works for you? It works for me now with today's
build but I have reports from one user that it's still not working for him.

Comment 21

[grylchan]

David,
Using 2002020603 commercial trunk on NT 4.0 it works for me.
I downloaded few mesgs (dif sizes, w/attach), went offline
deleted some downloaded and non-downloaded mesgs and when I went back
online they did not reappear. Exited mozilla and relogged in and
still no 'deleted mesgs' mysteriously reappearing.

looks ok. still need to test other os's/little more extensive testing.

Comment 22

[grylchan]

Using commercial builds:
2002-02-13-10-trunk/ nt 4.0
2002-02-13-08-trunk/ linux 2.2
2002-02-13-09-trunk mac 9.1

Tried deleting downloaded/nondownloaded mail from imap or webmail
acts with trash mode 'mark as deleted'. Tried different
sized mesgs also.

It appears to work fine. When I go online and the deleted
mesgs do not appear. I tried get mesg, read mesgs from account
central and couldn't make the deleted mesgs reappear.

Verified on Windows and Linux.

David,
I can't mark as verified.  I can't verify this on mac builds
at all. I am running into bug 119592. What happens is:
  - i go offline and delete mail
  - i go back online then the application hangs
    and since it hangs, it can't sync w/server to say
    oh i've deleted some mail
  result: I have to quit application and when I relogin
          the mesgs reappear again.

Should I put a dependency aka bug 119592 blocks this bug?

Comment 23

[David :Bienvenu]

I guess you could, but could change the summary to reflect that it's mac only,
and simply not verified on the mac (i.e., possibly fixed even on the mac). My
inclination would be to verify it, and leave a note in that other bug to go back
and reverify this on the mac when the other bug gets fixed.

Comment 24

[David :Bienvenu]

also, you could try shutting down the app after you go offline, and restarting
it online on the mac - does it still spin in that situation?

Comment 25

[grylchan]

After deleting msgs while offline and then exiting the application
while still offline and then restarting it these are the results:
On Mac os 10.1.2 or Mac 9.2.2, it doesn't 'spin' but the mesgs
don't stay deletd either as they reappear.


I will take your advice David and note on bug 119592 
to verify this bug again when that bug gets fixed.

Marking as verified.

Comment 26

[(not reading, please use [e-mail] instead)]

supplimental fix, from bienvenu.  this has r/sr=bienvenu,sspitzer.

Index: nsMsgOfflineImapOperation.cpp
=========================================================
==========
RCS file: 
/cvsroot/mozilla/mailnews/db/msgdb/src/nsMsgOfflineImapOperation.cpp,
v
retrieving revision 1.10
diff -u -2 -r1.10 nsMsgOfflineImapOperation.cpp
--- nsMsgOfflineImapOperation.cpp	1 Feb 2002 01:52:54 -0000	1.10
+++ nsMsgOfflineImapOperation.cpp	15 Feb 2002 21:39:07 -0000
@@ -147,6 +147,7 @@
 {
   NS_ENSURE_ARG(aNewFlags);
-  nsresult rv = m_mdb->GetUint32Property(m_mdbRow, 
PROP_NEW_FLAGS, (PRUint32 *) &m_newFlags, 0);
-  *aNewFlags = m_newFlags;
+  PRUint32 flags;
+  nsresult rv = m_mdb->GetUint32Property(m_mdbRow, 
PROP_NEW_FLAGS, &flags, 0);
+  *aNewFlags = m_newFlags = (imapMessageFlagsType) flags;
   return NS_OK;
 }

Comment 27

[David :Bienvenu]

reopening for the mac issue - I believe this was also causing problems on
solaris. If you repeat this test:

also, you could try shutting down the app after you go offline, and restarting
it online on the mac - does it still spin in that situation?

after the fix is checked in, you should see the X's remain.

Comment 28

[grylchan]

David,
Are you saying now 'mark as deleted' is fixed in this bug (for the
mac) along with remove immediatly?

If so, should I mark this bug 101069 (mark as deleted for mac)
as dupe of this bug?

Comment 29

[David :Bienvenu]

ah, good one, Gary. Yes, that's right.

Comment 30

[grylchan]

ok will mark the other bug as dupe. thnx.

Comment 31

[grylchan]

*** Bug 101069 has been marked as a duplicate of this bug. ***

Comment 32

[David :Bienvenu]

marking this fixed, since I reopened bug 101069 - bug 101069 was a better
description of the remaining problem, and is what Seth and my latest fix is for.

Comment 33

[grylchan]

David, so just to double check. Then nothing has changed
for this bug? The fix in comment 26 will instead be
attached to bug 101069. And since I marked verified
in comment 22, I can remark as verified now since nothing
changed?

Comment 34

[David :Bienvenu]

yes, this is still fixed.

Comment 35

[grylchan]

Ok Marking as verified based on comment 22.
Note still need to test on mac still.

Comment 36

[Kenneth Herron]

*** Bug 123413 has been marked as a duplicate of this bug. ***