982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

To land bug 946866, we had to temporarily load a card index from SimSettingsHelper if it wasn't passed into call(), since the required UI work is fairly massive to support these properly. We should remove it.

Comment 1

[Anthony Ricaud (:rik)]

We have 2 call sites in dialer.js left to remove this. Those are bluetooth actions, we'll need UX input to know what to do in those cases. I haven't looked into bluetooth a lot so I can't properly articulate the question for UX yet.

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()

PR: https://github.com/mozilla-b2g/gaia/pull/22428

Carrie, what should we do when a Bluetooth device dials a specific number (not one in the call log), but the user-preferred SIM is set to "always ask"? For now, I chose to ignore the call, but we can change this fairly easily.

Comment 3

[Carrie Wang [New account: [e-mail]]]

Hi Doug, 

If it's not from call log, we can display the SIM picker and wait for users take actions. 
I think this is the quickest solution for the case. Of course, I think we should provide a section in SIM manager to let users choose a SIM for these BT cases, but I'd like to know is it doable in this timeframe and is BT the only special case we need to consider about? Thanks!

Comment 4

[Doug Sherk (:drs) (inactive)]

(In reply to Carrie Wang [:carrie] from comment #3)
> If it's not from call log, we can display the SIM picker and wait for users
> take actions. 

Ok, that makes sense to me. I'll go ahead and fix up this patch to do that.

> I think this is the quickest solution for the case. Of course, I think we
> should provide a section in SIM manager to let users choose a SIM for these
> BT cases

This could be a followup. It would fall under one of the system or settings components, though. Once they add that, we could fairly easily add support for it as well within the dialer.

Is this just an idea that you're throwing out, or do you want to go ahead with it? I'm not really convinced on its value. I suggested this as well in bug 1021478 comment 7, but I don't really like it anymore. It seems like it's solving a problem that doesn't exist at this point, and is adding more unnecessary baggage to the UI.

> but I'd like to know is it doable in this timeframe

There's no real timeframe for this bug. I'm going to stick it in this sprint, though. In the case of the "outgoing BT calls" settings option, we'd need input from the system or settings teams. That should be done in a different bug, though.

> and is BT the only special case we need to consider about? Thanks!

Yeah, in this case, it's only a BT device dialing a number directly that we need to worry about.

Comment 5

[Doug Sherk (:drs) (inactive)]

Attachment: Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()

Better patch based on discussion.

Updated PR.

Comment 6

[Anthony Ricaud (:rik)]

This is demoable by the way :)

Comment 7

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/7de5f193237cf94734630a21754852daf797bd77

Do a demo.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/b5843cbdf5e16e0b732b3e825f4d8557a2eab73a