991025 - Enable WiFi test on emulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

We do need wifi API test on emulator. This is a bug for tracking necessary modification on different repos and different versions of emulator.

Comment 1

[Henry Chang [:hchang]]

Attachment: wifi.c.patch

Comment 2

[Henry Chang [:hchang]]

WIP on ICS emulator:

$ git clone https://github.com/mozilla-b2g/B2G b2g-emu-wifi
$ cd b2g-emu-wifi
$ GITREPO=git://github.com/elefant/b2g-manifest BRANCH=dev/emu-wifi ./config.sh emulator

Patch attachment 8400557 [details] [diff] [review] on hardware/libhardware_legacy/wifi/wifi.c

$ ./build.sh
$ ./mach marionette-webapi gecko/dom/wifi/test/marionette/test_wifi.js

Comment 3

[Henry Chang [:hchang]]

(In reply to Henry Chang [:henry] from comment #2)
> WIP on ICS emulator:
> 
> $ git clone https://github.com/mozilla-b2g/B2G b2g-emu-wifi
> $ cd b2g-emu-wifi
> $ GITREPO=git://github.com/elefant/b2g-manifest BRANCH=dev/emu-wifi
> ./config.sh emulator
> 
> Patch attachment 8400557 [details] [diff] [review] on
> hardware/libhardware_legacy/wifi/wifi.c
> 
> $ ./build.sh
> $ ./mach marionette-webapi gecko/dom/wifi/test/marionette/test_wifi.js

Patching wifi.c is no longer needed because of 

https://github.com/elefant/device_generic_goldfish/commit/b39af9d668b0e612af85dade4b75312258b07b02

So the steps become:

$ git clone https://github.com/mozilla-b2g/B2G b2g-emu-wifi
$ cd b2g-emu-wifi
$ GITREPO=git://github.com/elefant/b2g-manifest BRANCH=dev/emu-wifi
> ./config.sh emulator
$ ./build.sh
$ ./mach marionette-webapi gecko/dom/wifi/test/marionette/test_wifi.js

Comment 4

[Henry Chang [:hchang]]

The third step should be 

$ GITREPO=git://github.com/elefant/b2g-manifest BRANCH=dev/emu-wifi ./config.sh emulator

Comment 5

[Henry Chang [:hchang]]

Attachment: gecko-mod.patch

Gecko's patch if you are using custom gecko.

Comment 6

[Henry Chang [:hchang]]

Try server result with modified test case and qemu patch.

https://tbpl.mozilla.org/?tree=Try&rev=f538b5f8cf49

Comment 7

[Henry Chang [:hchang]]

Try server result with no qemu patch: https://tbpl.mozilla.org/?tree=Try&rev=3ae1de1ffc76

Comment 9

[Henry Chang [:hchang]]

Latest try server result:
https://tbpl.mozilla.org/?tree=Try&rev=db3cc1883852

Comment 10

[Henry Chang [:hchang]]

Attachment: Part 1: b2g-manifest - Add hostap to emulator.xml

Comment 11

[Henry Chang [:hchang]]

Attachment: Part 2: platform_build - Modify BoradConfig.mk to build wpa_supplicant and hostapd

Comment 12

[Henry Chang [:hchang]]

Attachment: Part 3: device_generic_goldfish - Add wpa_supplicant service and related scripts

Comment 13

[Henry Chang [:hchang]]

Attachment: Part 4: qemu - Add network interface "wlan0"

Comment 14

[Henry Chang [:hchang]]

All the PRs for wifi test on ICS emulator:

#1: https://github.com/mozilla-b2g/b2g-manifest/pull/166:
#2: https://github.com/mozilla-b2g/platform_build/pull/46
#3: https://github.com/mozilla-b2g/device_generic_goldfish/pull/13
#4: https://github.com/mozilla-b2g/platform_external_qemu/pull/71 

#1 works with #2 for ICS emulator to checkout and build "hostap", where #1 add
repo "hostap" to emulator.xml and #2 add build config to BoardConfig.mk to build 
wpa_supplicant and hostapd with test driver.

#3 adds services and creates directories we need while #4 modifies qemu to add an
additional network interface "wlan0" for wifi and DHCP use.

Comment 15

[Vicamo Yang [:vicamo][:vyang]]

Depends on bug 871475 because part 4 (attachment 8407618 [details] [review]) needs that.

Comment 20

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8407613 [details] [review]
Part 1: b2g-manifest - Add hostap to emulator.xml

We can reuse existing external/wpa_supplicant_8.

Comment 21

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8407615 [details] [review]
Part 2: platform_build - Modify BoradConfig.mk to build wpa_supplicant and hostapd

nit: WPA_SUPPLICANT_VERSION := VER_0_8_X

Comment 22

[Henry Chang [:hchang]]

Attachment: Sample configuration file for hostapd

How to use:

$ adb push ap1.conf /data/misc/wifi/hostapd && adb shell hostapd -B /data/misc/wifi/hostapd/ap1.conf

Comment 23

[Vicamo Yang [:vicamo][:vyang]]

Try emulator all: https://tbpl.mozilla.org/?tree=Try&rev=44bb1d8b72f2

Comment 24

[Vicamo Yang [:vicamo][:vyang]]

Attachment: crash-mochitest-chunk-4.txt

Comment 25

[Vicamo Yang [:vicamo][:vyang]]

mochitest-4 again with m-c tip: https://tbpl.mozilla.org/?tree=Try&rev=db003e978d6c

Comment 26

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #24)
> Created attachment 8409503 [details]
> crash-mochitest-chunk-4.txt

Can't replicate locally.

Comment 27

[Henry Chang [:hchang]]

The log appears that all failed cases have a running wpa_supplicant....

Comment 28

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #25)
> mochitest-4 again with m-c tip:
> https://tbpl.mozilla.org/?tree=Try&rev=db003e978d6c

Looks like it's really the known intermittent failure bug 996487.  Going to land.

Comment 29

[Vicamo Yang [:vicamo][:vyang]]

https://github.com/mozilla-b2g/platform_external_qemu/commit/52720b94a4f709d5f96c23b2d63c398e7002ecb9
https://github.com/mozilla-b2g/device_generic_goldfish/commit/2fee3bbbfc236b883ef8507e27d88b17b203fe25
https://github.com/mozilla-b2g/platform_build/commit/2a165bebfa19b11b697837409f9550dd2917c46c

Comment 30

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f4cdabe207e9
https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=f4cdabe207e9

Comment 31

[Ethan Tseng [:ethan]]

Hi Henry,
I suppose once this bug is landed, we could connect to the "goldfish" Wifi AP in the emulator, right?

My question is, do we still have to set the first DNS server to enable network connectivity to the Internet on the emulator?
e.g.
adb shell setprop net.dns1 10.0.2.3
or
adb shell ndc resolver setifdns eth0 10.0.0.0 10.0.2.3

Comment 32

[Henry Chang [:hchang]]

(In reply to Ethan Tseng [:ethan] from comment #31)
> Hi Henry,
> I suppose once this bug is landed, we could connect to the "goldfish" Wifi
> AP in the emulator, right?
> 
> My question is, do we still have to set the first DNS server to enable
> network connectivity to the Internet on the emulator?
> e.g.
> adb shell setprop net.dns1 10.0.2.3
> or
> adb shell ndc resolver setifdns eth0 10.0.0.0 10.0.2.3

If we successfully connect to a wifi AP or 3G network, the B2G network management component would set DNS for you. Therefore you don't need to do it by yourself!

Comment 33

[Ethan Tseng [:ethan]]

(In reply to Henry Chang [:henry] from comment #32)
> If we successfully connect to a wifi AP or 3G network, the B2G network
> management component would set DNS for you. Therefore you don't need to do
> it by yourself!
That's great!
This information is helpful to update our MDN article. :)
https://developer.mozilla.org/en-US/Firefox_OS/Using_the_B2G_emulators#Network_Connectivity

Comment 34

[Vicamo Yang [:vicamo][:vyang]]

http://hg.mozilla.org/mozilla-central/rev/1d0496e30feb