Closed Bug 593690 Opened 14 years ago Closed 14 years ago

Tabview button and other toolbarbuttons increase the tab bar height

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b7

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
2.35 KB, patch
ventnor.bugzilla
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
see bug 593570 comment 2
Attachment #472271 - Flags: review?(gavin.sharp)
Blocks: 594013
Blocks: 595286
Blocks: 58901
No longer blocks: 595286
Blocks: 589010
No longer blocks: 58901
Dāo, does the Panorama button still do this with the latest version of bug 589010?
(In reply to comment #2)
> Dāo, does the Panorama button still do this with the latest version of bug
> 589010?

Yes.
Fixing this will most likely also fix bug #594013, because currently the app tabs look fine as long as there is no action button added to the tab bar (like tab candy etc)

This goes even further as explained in bug #594922 which has a lot of dupe information but issue a is still valid after this patch I think. Maybe also the persona issue.
Attached patch patch — — Splinter Review 
updated to tip
Attachment #472271 - Attachment is obsolete: true
Attachment #474356 - Flags: review?(gavin.sharp)
Attachment #472271 - Flags: review?(gavin.sharp)
Attachment #474356 - Flags: review?(ventnor.bugzilla)
Attachment #474356 - Flags: review?(ventnor.bugzilla) → review+
Attachment #474356 - Flags: review?(gavin.sharp) → approval2.0?
Tested the patch, does what it says and also fixes bug #594013. I will update #594922 accordingly.
http://hg.mozilla.org/mozilla-central/rev/d90e28f6e38f
Blocks: 593967
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Attachment #474356 - Flags: approval2.0?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: