Closed
Bug 1017360
Opened 10 years ago
Closed 10 years ago
[Vertical] Dragdrop improvements
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=3],[systemsfe])
Attachments
(1 file)
We're seeing a lot of little issues with dragdrop. I think with some refactoring we can solve them all in one go.
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [p=3],[systemsfe]
Target Milestone: --- → 2.0 S3 (6june)
|
|
Assignee | |
Comment 1•10 years ago
|
||
Hi Cristian - thoughts on this? After playing with it a bit it solves a lot of dragdrop problems. The idea is that we fill *every* slot on the grid now, so we can always calculate an item. Before we would sometimes calculate that we are near a divider when dropping on an empty space, and this would cause problems. Adding placeholders in also mean that we can maintain a section so it does not immediately collapse when you are dragging an icon. I'm not adverse to refactoring this file, so if you have a better idea please let me know.
Attachment #8430588 -
Flags: review?(crdlc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8430588 [details] [review] Github pull request Some minor comments, good job as usual, thanks a lot Kevin
Attachment #8430588 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/4f196086ae1d230dd650fdf2425bb31eb501fcb1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•10 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•