Closed Bug 1017360 Opened 5 years ago Closed 5 years ago
[Vertical] Dragdrop improvements
We're seeing a lot of little issues with dragdrop. I think with some refactoring we can solve them all in one go.
Target Milestone: --- → 2.0 S3 (6june)
Hi Cristian - thoughts on this? After playing with it a bit it solves a lot of dragdrop problems. The idea is that we fill *every* slot on the grid now, so we can always calculate an item. Before we would sometimes calculate that we are near a divider when dropping on an empty space, and this would cause problems. Adding placeholders in also mean that we can maintain a section so it does not immediately collapse when you are dragging an icon. I'm not adverse to refactoring this file, so if you have a better idea please let me know.
Attachment #8430588 - Flags: review?(crdlc)
Comment on attachment 8430588 [details] [review] Github pull request Some minor comments, good job as usual, thanks a lot Kevin
Attachment #8430588 - Flags: review?(crdlc) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
You need to log in before you can comment on or make changes to this bug.