Closed Bug 1022339 (tamil-keyboard) Opened 6 years ago Closed 3 years ago

[ta]Tamil Keyboard for Firefox OS

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, major)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: arunprakash.pts, Assigned: arunprakash.pts, NeedInfo)

References

Details

Attachments

(13 files, 1 obsolete file)

This is tracking bug for Tamil Keyboard for Firefox OS.

We are expecting tamil99 to be included in the build.
This is depending on Bug 944641
I think we can use this files to do the layout for Tamil keyboard for Firefox OS.
yes these would be good starting points.
Just noticed we now have tamil keyboard in gaia. This is not enabled by default. 

https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/ta.js
Status: NEW → UNCONFIRMED
Ever confirmed: false
Is there anyway by chance, that i can test this keyboard by making myself a custom build ?
Yep, run:

GAIA_KEYBOARD_LAYOUTS=en,ta APP=keyboard make install-gaia && adb shell stop b2g && adb shell start b2g

Will only flash the keyboard app with the new layout.
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(arunprakash.pts)
Resolution: --- → FIXED
Resolution: FIXED → DUPLICATE
Duplicate of bug: 991509
(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #9)
> 
> *** This bug has been marked as a duplicate of bug 991509 ***

Is it possible to enable Tamil Keyboard layout for FirefoxOS daily build ? If can not why ?
Since Tamil Translation is 100%.

http://mozilla.locamotion.org/ta/firefoxos/
What kind of daily builds? GeeksPhone? If so, create a new thread on their forums asking to add Tamil to their builds. They're pretty quick generally.
Flags: needinfo?(thangam.arunx)
At the moment keyboards are enabled with build time configuration. After some discussion with keyboard module owner we filed a new bug to track this work. 

Please continue this discussion here. 

Bug 1029314 - Also Opt-in keyboard layouts that are required by default locale
https://bugzilla.mozilla.org/show_bug.cgi?id=1029314

Thanks!
Flags: needinfo?(thangam.arunx)
Flags: needinfo?(arunprakash.pts)
We also need to file separate bugs to enabled Tamil (ta) locale for Geekphone and Flame nightly builds.
(In reply to arky [:arky] from comment #13)
> Geekphone and Flame nightly builds.
I have filed new bug for the same. Bug - 1029935.
Verified the keyboard layout and it is not working properly. Unable to type some letters. Also i dont know what is this layout.
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: DUPLICATE → ---
Attached image Fx layout default
Attached image Fx layout shift
This layout is not good, I am trying to fix this one. Also the letters at upper case is not working.
(In reply to Arun Prakash from comment #18)

Arun, did you try to build your own as suggested above, or how are you trying to fix ?
First i am changing the layout and then try to make it work. Takes time, i am taking other layouts for reference.
Attached image 99 front
Attached image 99 shift
As you see in the two layouts, the layout seems to be long. If there is anyway to fix this, we can proceed with this. Or we should change to any other layout. The above one is standard keyboard for tamil, which tamil 99.

@thangamani arun: comment on this.
(In reply to Arun Prakash from comment #23)
> As you see in the two layouts, the layout seems to be long. If there is
> anyway to fix this, we can proceed with this. Or we should change to any
> other layout. The above one is standard keyboard for tamil, which tamil 99.
> 
> @thangamani arun: comment on this.

You could specify "width" in the layout file, if you want more than 10 keys in a row. e.g.,
https://github.com/mozilla-b2g/gaia/blob/24fe85863d7828e9414ee1ed72454d92a301dbe1/apps/keyboard/js/layouts/ar.js#L10

BTW, are you creating another layout for Tamil or you're going to replace the orignal one with your implementation?
Flags: needinfo?(arunprakash.pts)
> 
> You could specify "width" in the layout file, if you want more than 10 keys
> in a row. e.g.,
> https://github.com/mozilla-b2g/gaia/blob/
> 24fe85863d7828e9414ee1ed72454d92a301dbe1/apps/keyboard/js/layouts/ar.js#L10

Let me try this.
> 
> BTW, are you creating another layout for Tamil or you're going to replace
> the orignal one with your implementation?

I am trying to replace the original.
Flags: needinfo?(arunprakash.pts)
(In reply to Arun Prakash from comment #23)
> As you see in the two layouts, the layout seems to be long. If there is
> anyway to fix this, we can proceed with this. Or we should change to any
> other layout. The above one is standard keyboard for tamil, which tamil 99.


Arun, We can use the ios7 Tamil 99 layout as the reference. Since its looks perfect. 
I will attach the screenshots now.

please refer the attachements.
iOS Tamil99 Layout - Default
Attached image iOS7-Tamil99-SHIFT.png
iOS Tamil99 Layout - SHIFT
> 
> You could specify "width" in the layout file, if you want more than 10 keys
> in a row. e.g.,
> https://github.com/mozilla-b2g/gaia/blob/
> 24fe85863d7828e9414ee1ed72454d92a301dbe1/apps/keyboard/js/layouts/ar.js#L10
> 
> 
Thanks, this helps.
Attached image FX at IOS style default
Attached image FX at IOS style shift
Shift layout seems to be more packed! We are able to type now. But the next question is ime? I want to map it to characters, if anybody can help me it will be good.Now the layout file is here : https://github.com/arunprakash/gaia/commit/896f64a3572b6a6af08a27effb52e4a569d1e0ce
(In reply to Arun Prakash from comment #32)
> Shift layout seems to be more packed!

Nice Work Arun! I appreciate your effort.
It looks very good. Lets keep this layout.
Blocks: 1034210
Attached image default.png
Attached image shift.png
Just got an idea when looking into the keyboard layout provided in 
https://play.google.com/store/apps/details?id=org.smc.inputmethod.indic
https://play.google.com/store/apps/details?id=in.androidtweak.inputmethod.indic
based on inscript.

The result is success, as i am able to type all character in tamil. I am amazed with the support provided to tamil in Firefox OS. Hats off to developers.

@thangamani arun: The recent layout works like charm. Tamil99 layout requires ime, which needs to be hardcoded, which i dont have any clue. What shall we do? shall we stick to this and make the tamil99 as another layout later?
Flags: needinfo?(thangam.arunx)
(In reply to Arun Prakash from comment #36)
> @thangamani arun: The recent layout works like charm. Tamil99 layout
> requires ime, which needs to be hardcoded, which i dont have any clue. What
> shall we do? shall we stick to this and make the tamil99 as another layout
> later?

Arun, Congrats on your effort in bringing the layout.

Let us use Indic Keyboard layout, since the FireofxOS Mobile release in India is nearing.
Later, when we get some support from other developers then we can bring Tamil99 along with this.
Flags: needinfo?(thangam.arunx)
(In reply to Arun Prakash from comment #37)
> Latest working layout is here : 
> https://github.com/arunprakash/gaia/commit/
> 07a3debfde3c3599228ffb10d681fd21542c3707

Did you merge these changes to Mozilla Main Repository ?
(In reply to அருண் குமார்-Arun Kumar from comment #39)
> (In reply to Arun Prakash from comment #37)
> > Latest working layout is here : 
> > https://github.com/arunprakash/gaia/commit/
> > 07a3debfde3c3599228ffb10d681fd21542c3707
> 
> Did you merge these changes to Mozilla Main Repository ?

Still now no. now i am giving pull request, let us see.
Concerned people kindly approve the pull request.
Pull request created : https://github.com/mozilla-b2g/gaia/pull/21408
Once this pull request is accepted, we can close this bug.
Great job with the layout! Sorry I was not in the loop. I'll chip in with the mappings for tamil99 as a separate layout if needed.
(In reply to Arun Prakash from comment #41)
> Pull request created : https://github.com/mozilla-b2g/gaia/pull/21408

Arun, thanks for your effort.
In general, we paste the pull request link into an attachment and ask for review.
BTW, I would second Preveen's opinion on making this another layout for Tamil, so may need to name it as ta-99.js or something.
Thanks.
Flags: needinfo?(arunprakash.pts)
Attached file Patch to add Tamil 99 (obsolete) —
I'll attach an attachment for your pull request as an example.
Is this ready for review?
Attached file Tamil Layout
(In reply to Rudy Lu [:rudyl] from comment #45)
> Created attachment 8454316 [details] [review]
> Patch to add Tamil 99
> 
> I'll attach an attachment for your pull request as an example.
> Is this ready for review?

This is not tamil99 keyboard. This is normal layout for tamil. We want this to be replaced with the current one, so it is named as ta.js. 

It is ready for review.
Flags: needinfo?(arunprakash.pts)
Is it reviewed?
Flags: needinfo?(rlu)
Comment on attachment 8454316 [details] [review]
Patch to add Tamil 99

Not Tamil 99, thanks for the clarification.
Attachment #8454316 - Attachment is obsolete: true
Comment on attachment 8454351 [details] [review]
Tamil Layout

I have one question,

 -  Can't this layout co-exist with our current Tamil layout? 
    I am not sure if we need to replace it.
    Also ni Luke since he is the author of the original Tamil layout. 

(If we want to supply 2 layouts for Tamil, we might need 2 different names for these layouts.) 

Besides, please address the comments I made on github pull request.

--
Arun Kumar,

Could you please help review the UI of this patch, since you know Tamil, right?
Thanks.
Attachment #8454351 - Flags: ui-review?(thangam.arunx)
Flags: needinfo?(rlu) → needinfo?(lchang)
Hi Rudy,

I had reviewd the layout and found that there are 2 letters missing and removed the repeating letters from the layout file with pull request: https://github.com/arunprakash/gaia/pull/1

Arun Praksh: Please check once again and commit my pull request.
Flags: needinfo?(rlu)
Flags: needinfo?(arunprakash.pts)
Hi Rudy,

AFAIK, there are more than one common type of Tamil keyboard layout that can be found from internet [1]. The current layout we implemented in Gaia is based on the feature request from Tarako [2]. As you can see, Google Input Tools [3] also make five types of Tamil virtual keyboard coexist there.

According to above, although I'm not a native user of Tamil language, I personally prefer leaving these two layouts coexist in FxOS to let users have choice.


[1] http://tamil.indiatyping.com/index.php/tamil-keyboard
[2] Bug 991509 attachment 8403958 [details] and attachment 8403959 [details]
[3] http://www.google.com/intl/en/inputtools/try/
Flags: needinfo?(lchang)
There are many layouts available for Tamil. The reason we are asking for replacement of existing layout is, there Grantha letters which we use very very less frequently in the default layout. The layout which we are proposing is the alteration of current one as per Inscript layout(Indian Government Standard).

Another reason is that, we have to include two more layouts (Tamil99 and phonetic). These layouts are more actively used by Tamil Community. These keyboards are onhold because we have some problem with writing ime as of now. So too many layout will not be good.
Arun, Luke,

Thanks for the feedback.
As we have build time configuration to determine which keyboard layout we should include in the build, I don' think "too many layouts" would be an issue.

I would second Luke on we should keep the original Tamil layout as is, and make your patch as a new layout of Tamil.
For this to happen, we would need to have proper names for these layouts.
Could you or Arun Kumar help think of good naming for these layouts?

Thanks a lot.
Status: REOPENED → ASSIGNED
Flags: needinfo?(rlu)
Assignee: nobody → arunprakash.pts
@thangam : pull request merged.
@Rudyl : What should we do for making this as separate layout?
Flags: needinfo?(arunprakash.pts) → needinfo?(rlu)
Assignee: arunprakash.pts → rlu
(In reply to Arun Prakash from comment #54)
> @thangam : pull request merged.
> @Rudyl : What should we do for making this as separate layout?
You would need to create another file under apps/keyboard/js/layouts/.
Flags: needinfo?(rlu)
Assignee: rlu → nobody
Praveen, any chance you know how to make this bug move forward?
I am flagging you for help because I think you worked on adding more keyboard support for India languages, and Tamil is one of them.

I guess the main question would be:
Is it reasonable to keep more than one layouts for Tamil?
    If yes, how could we name these layouts so that the user would know which layout is which?
    If no, then how could we choose the better one that is default to our OS?

Thanks.
Flags: needinfo?(prvn431)
Hi Rudy,

I can help you in providing the layout names for Tamil keyboards.

The existing layout named as "Tamil - Inscript"
Recent layout can be named as "Tamil - Typewriter"

Please keep the recent layout as Deafult layout(Tamil - Typewriter) for Tamil.

@ArunPrakash: Act quick on this to proceed further. Still we do not have keyboard on FxOS for Tamil.

Thanks
Arun Kumar
Flags: needinfo?(arunprakash.pts)
(In reply to Rudy Lu [:rudyl] from comment #56)
> Is it reasonable to keep more than one layouts for Tamil?

I think it is reasonable to have more than one layouts beacause that is exactly the case with keyboards in other platforms. It is always good to give users a choice, so that they can use the layout they're comfortable with.

>     If yes, how could we name these layouts so that the user would know
> which layout is which?

As Arun has suggested, we can use a good naming format, suggested by the community.

>     If no, then how could we choose the better one that is default to our OS?

The decision for the default layout IMHO should rest with the local mozillian community, since they will be in touch with the users of the layout and can get quick feedback.
Flags: needinfo?(prvn431)
Hi,

To my knowledge, the most used Tamil layouts **on desktops** are phonetic(which requires IME as there are some rules) and Tamil 99(which also needs IME ideally for some combinations, but bare minimal T99 doesn't need one). 

I want to have these 2 layouts for Tamil. If someone can point me to links which tells me

1. How to test modified layout js files using emulator 
2. How to test the same using a real phone. (I have a Intex Cloud FX)
3. How to get started with writing IMEs

I can be of some help in getting these layouts. Thanks
Go to http://janjongboom.com/gaia-keyboard-demo/ and you can load a layout file to test in the browser. For full IMEs you'll have to look at the current implementations in https://github.com/mozilla-b2g/gaia/tree/master/apps/keyboard/js/imes. We don't have any guides for that in place.
Flags: needinfo?(srik.lak)
This is long time pending. Will work with Thangamani Arun and fix it soon.
Removing need info for now.
Flags: needinfo?(arunprakash.pts)
Assignee: nobody → arunprakash.pts
Hello! Any progress on this? Tamil keyboard has been requested on 1.4 and onwards (2.0, 2.1 and master). Thanks!
[Blocking Requested - why for this release]:
Tamil has been requested by partners on 1.4 and onwards. Putting the blocking flag for 2.0 since there's no more blocking flag 1.4
Please get into 1.4 branch and onwards. Thanks!
blocking-b2g: --- → 2.0?
Flags: needinfo?(bbajaj)
[Blocking Requested - why for this release]:

[Triage] Considering current 2.0 timing and the need from partner, nom. to 2.1 (or even 2.2?) instead for consideration.
blocking-b2g: 2.0? → 2.1?
Clearing blocking nom, refer to comment in : https://bugzilla.mozilla.org/show_bug.cgi?id=1114866
blocking-b2g: 2.1? → ---
Flags: needinfo?(bbajaj)
Alias: tamil-keyboard
Status: ASSIGNED → RESOLVED
Closed: 6 years ago3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.