1038635 - zoom doesn't work in the email composer

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Mihai Sucan [:msucan]]

Starting with Thunderbird 30 (IIRc) zoom fails to work in the email composition window. This is making it hard for me to write emails.

I would really appreciate a fix.

Comment 1

[Thomas D. (:thomas8)]

Confirming as a bug in TB31 beta 20140704014635

STR

1 compose (HTML) msg, type "Hello world"
2a Press Ctrl++ or Ctrl+- or Ctrl+0
2b Alternatively, use menu: View > Zoom > Zoom in/out/reset

Actual result

2a) and 2b) nothing (zoom does not change)

Expected result

zoom should change accordingly

Comment 2

[Thomas D. (:thomas8)]

Having no composition zoom at all is a major accessability bug which should block release of TB31.

Comment 3

[Magnus Melin [:mkmelin]]

good: 2013-12-31
broken: 2014-01-22

Comment 4

[Ian Neal]

(In reply to Magnus Melin from comment #3)
> good: 2013-12-31
> broken: 2014-01-22

Could it be the landing of bug 691614 ?

This was fixed for SeaMonkey in bug 965057 with changeset http://hg.mozilla.org/comm-central/rev/efa3650fd3b7

Comment 5

[Magnus Melin [:mkmelin]]

Indeed, this is from bug 691614. Thx Ian!

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Add needed attributes to editor.xml

Comment 7

[[e-mail]]

Comment on attachment 8457927 [details] [diff] [review]
proposed fix

I had to add Zoom support to composer to test this out ;-)

Comment 8

[Ian Neal]

(In reply to [e-mail] from comment #7)
> Comment on attachment 8457927 [details] [diff] [review]
> proposed fix
> 
> I had to add Zoom support to composer to test this out ;-)

Is that another patch somewhere (in bug 233513) ? ;-)

Comment 9

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1ddceb19abc

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c1ddceb19abc

Comment 11

[Mihai Sucan [:msucan]]

Thank you very much for the fix. Can this patch be backported to aurora and beta? Pretty please. :)

Comment 12

[Thomas D. (:thomas8)]

(In reply to Mihai Sucan [:msucan] from comment #11)
> Thank you very much for the fix. Can this patch be backported to aurora and
> beta? Pretty please. :)

+1, see my comment 2:
> Having no composition zoom at all is a major accessability bug which should
> block release of TB31.

Comment 13

[Magnus Melin [:mkmelin]]

Comment on attachment 8457927 [details] [diff] [review]
proposed fix

Approval Request Comment
[Feature/regressing bug #]: 691614
[User impact if declined]: can't zoom in thunderbird compose window. The same goes for any <editor> element where zooming is used. Our next general release is Thunderbird 38 so waiting until then would leave compose zooming broken for a long time, causing serious problems for people with disabilities. Therefore it is needed for esr31.
[Describe test coverage new/current, TBPL]: tested on trunk
[Risks and why]: low risk, it's just adding missing attributes that were added in bug 691614 
[String/UUID change made/needed]: none

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8457927 [details] [diff] [review]
proposed fix

Is it possible to test that on Firefox?

Comment 16

[Magnus Melin [:mkmelin]]

I don't think it's easily testable in firefox, that's probably why it went unnoticed for quote some time.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Changing this to a core component since the fix wasn't specific to c-c (and it makes uplift tracking a lot easier).

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8457927 [details] [diff] [review]
proposed fix

This landed on trunk when it was still 33, so not sure why this is being marked as needing landing on Aurora...

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f9b0de65c69d
https://hg.mozilla.org/releases/mozilla-esr31/rev/aa0755233d7e

Comment 23

[Charles]

So... ESR users are stuck for a full year with a broken ZOOM in compose...?

That really sucks...

Comment 24

[Charles]

Scratch  that... no more ESR, but Thunderbird won't be updated until the next Firefox ESR relase for a year, so basically the same thing...

:(

Comment 25

[Magnus Melin [:mkmelin]]

No, this got backported to the esr branch, so the next security update will fix it, due in what, 4 weeks.

Comment 26

[Charles]

<whew>


Thanks... I was envisioning having to downgrade everyone back to 24.7 and stay there until the next release.

I really like most everything else in the new 31, so this is a relief...

Thanks!