1071942 - [Rocketbar] Rocketbar disappears after user brings up rocketbar with gallery app in landscape mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[[:SalvadorR]]

Attachment: logcat_20140923_1426.txt

Description:
When user brings up Rocket bar with gallery app in landscape mode, if user touches the black background, the rocketbar will disappear
   
Repro Steps:
1) Update a Flame device to BuildID: 20140923003005
2) Open gallery app in landscape mode
3) Access Rocketbar and type anything
4) Touch the black background 
5) Observe Rocketbar
  
Actual:
Rocketbar disappears
  
Expected: 
Rocketbar displays properly
  
Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140923003005
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 5/5
See attached: Screenshot, logcat

Comment 1

[[:SalvadorR]]

This issue also occurs on Flame KK 2.1 (512mb), Flame KK 2.2, Flame JB 2.1(319mb) , Flame JB 2.2, Open C 2.1 and Open C 2.2

Actual:
Rocketbar disappears

Flame 2.1 KitKat Base (512mb)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140923003005
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 KitKat Base (319mb)

Environmental Variables:
Device:  Flame 2.2 Master
BuildID: 20140923073003
Gaia: 37b8a812c642ca616bf9457cb9b71e45261cdfa8
Gecko: 9e193395b912
Version: 35.0a1 (2.2)
Firmware: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 Jelly Bean Base (319mb)

Enviromental Variables:
Device: Flame 2.1
BuildID: 20140923000204
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Flame 2.2 Jelly Bean Base (319mb)

Enviromental Variables:
Device: Flame 2.2 Master
BuildID: 20140923040203
Gaia: 3c898380b47f298cd3b7a0dacb3a6529e94322d4
Gecko: 790f41c631cc
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

2.1 Open C

Environmental Variables:
Device: Open_C 2.1
Build ID: 20140923000204
Gaia: 3742913e11f69e789dcb0aa0dedf2e5572da0129
Gecko: df42b05782aa
Version: 34.0a2 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


2.2 Open C

Environmental Variables:
Device: Open_C Master
Build ID: 20140923040203
Gaia: 3c898380b47f298cd3b7a0dacb3a6529e94322d4
Gecko: 790f41c631cc
Version: 35.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
------------------------------------------------------------------------------------------------------------

This feature is not implemented on Flame 2.0 KK (319mb), Flame 2.0 JB (319mb), Open_C 2.0

Flame 2.0 KitKat Base (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140923063014
Gaia: 6449cc35a8f0704d95acac374ba857bde4b86d6c
Gecko: b930730dba81
Version: 32.0 (2.0)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.0 Jelly Bean Base (319mb)

Environmental Variables:
Device: Flame 2.0
Build ID: 20140923000205
Gaia: 8d7f2ac85f3154bdb149d67e5c2f9b035f5e4105
Gecko: 6dd19beda1c2
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Environmental Variables:
Device: Open_C 2.0
BuildID: 20140923000205
Gaia: 8d7f2ac85f3154bdb149d67e5c2f9b035f5e4105
Gecko: 6dd19beda1c2
Version: 32.0 (2.0)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[[:SalvadorR]]

Attachment: rocketbar.png

Comment 3

[[:SalvadorR]]

Attachment: rocketbar1.png

Comment 4

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: This breaks rocketbar in landscape when accessed from a fullscreen app.

Seems like this might be a regression, so let's bisect!

git bisect start
git bisect good f4b1dbb7e3a44455ea33a7cc8e00c4006126816e
git bisect bad b542080231bb9cdbdb282ab926965ad3f91f7460

Bisecting: 122 revisions left to test after this (roughly 7 steps)
[88ee9446d8605ef829e237465a11f0c17bbcc49b] Bug 1065658 - [Rocketbar] Do not hide search window if app launches in background r=alive

git bisect bad
Bisecting: 60 revisions left to test after this (roughly 6 steps)
[90812662b9e0d3aba88882290c08971fdff98515] Revert "Bug 1062527 - [Homescreen] Unable to launch apps after changing the date to a previous one"

git bisect good
Bisecting: 30 revisions left to test after this (roughly 5 steps)
[5dffc00ca1769919689253c722ea224dff27bb27] Bug 1061941 - [Contacts] Editing visible information (name) is not reflected in 'Contacts' until page/app refreshes for newly created contacts

git bisect good
Bisecting: 15 revisions left to test after this (roughly 4 steps)
[d4de4123c678b198692af256254a26507e9c9a08] Bug 1061854 - Dismiss notifications

git bisect good
Bisecting: 7 revisions left to test after this (roughly 3 steps)
[ec3dab745668e34a487aea78a920fbd043ee5925] Bug 1061127 - [Lockscreen] The time of notification in lockscreen keeps display just now as time elapsed

git bisect good
Bisecting: 3 revisions left to test after this (roughly 2 steps)
[dcf16872b4447d03d414199908394abc3836633c] Bug 1062989 - Add header localizable strings for screen reader and color filter sections.

git bisect good
Bisecting: 1 revision left to test after this (roughly 1 step)
[f7927d1b4bcfddf97125ae09e9a0efda0f5329ea] Bug 1045017 - fixing screen reader status bar accessibility. Statusbar improvements during app transitions.

git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[5b009c0624d28889c5dd41ed2e4f48c174e3c41c] Bug 1065516 - [System] Remove window.self in appWindow to reflect the dependency r=alive

git bisect good
f7927d1b4bcfddf97125ae09e9a0efda0f5329ea is the first bad commit
commit f7927d1b4bcfddf97125ae09e9a0efda0f5329ea
Author: Yura Zenevich <[e-mail]>
Date:   Tue Sep 9 15:41:28 2014 -0400

    Bug 1045017 - fixing screen reader status bar accessibility. Statusbar improvements during app transitions.

:040000 040000 58b35d70ccdfa79e34dedfb2e3a581ce58fa03de 18158d493280127b9e92a579ca4e0cf7d4b750d1 M	apps


Caused by bug 1045017.

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Yura - Could you review this to make sure this jives well with your accessibility efforts in bug 1045017?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8494108 [details]
Github pull request

Looks good to me, I can't see any a11y regressions with the status bar. I can't r+ it since I'm not a peer, forwarding to Alive. a11y-r+ me though!

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8494108 [details]
Github pull request

Not sure what happened but the link to PR links to https://bugzilla.mozilla.org/show_bug.cgi?id=1071942 again...

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8494108 [details]
Github pull request

https://github.com/mozilla-b2g/gaia/pull/24359 if this one.

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Yes, that was a bit silly of me. Replacing the invalid attachment with the actual pull request.

Comment 10

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/eb0fb5e0c6788da74a0936916c3abd1cae750070

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8494566 [details] [review]
Github pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): This was caused by some accessibility work, but unfortunately breaks rocketbar in some cases for sighted users.
[User impact] if declined: Rocketbar behavior is broken for fullscreen apps.
[Testing completed]: Manual testing. Unit testing is extremely difficult due to this being a CSS change.
[Risk to taking this patch] (and alternatives if risky): Low risk, one-liner CSS change.
[String changes made]: No.

Comment 12

[Gregor Wagner [:gwagner]]

Broken for fullscreen apps.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/8222610f9d9a8075831e115a00cf51f4a7844884

Comment 14

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2 and 2.1:

Flame 2.2 KitKat Base (319mb)(Full Flash)
  
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141002093155
Gaia: 191d805f4911628d37a8a90a1e23a6013995138f
Gecko: 5d6ec4dddf14
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
  
Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141002000202
Gaia: 94dcc25f2e34a4900ea58310c26be52bcb089161
Gecko: baaa0c3ab8fd
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Rocket bar stays on the screen properly.

Comment 15

[Kevin Grandon :kgrandon]

Setting testsuite- for bugs which depend on landscape b2g desktop for testing. This list will be re-triaged once support is added.