Closed Bug 109629 Opened 22 years ago Closed 22 years ago

[prefs] can't add languages

Categories

(SeaMonkey :: Preferences, defect, P2)

Product:
SeaMonkey
Component:
Preferences
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: chado_moz, Assigned: samir_bugzilla)

References

Details

(Keywords: intl)

Attachments

(2 files)

Specify ondialogaccept handler.
939 bytes, patch
Details | Diff | Splinter Review
Patch rev 2: *return* AddAvailableLanguage so false is propagated in alert conditions. Thanks to Blake for pointing this out.
946 bytes, patch
bryner
: review+
bugzilla
: superreview+
Details | Diff | Splinter Review 
reproduce:
 1. Open Preferences | Navigator | Languages.
 2. Click "Add..." button.
 3. Choose any language, then click "OK".

expected result:
 Choosen language appears in "Languages in order..." area.

actual result:
 Choosen language doesn't appear.

reproducible: always.

build:
 mac 2001-11-05-16-trunk and after can't add languages.
 mac 2001-11-01-08-trunk and before can add languages.
 win 2001-11-05-03-trunk and after can't add languages.
 win 2001-11-01-03-trunk and before can add lanfuages.

additional info: 
 I tried to try on win 2001-11-02-09-trunk, 
 but opening pref for lang caused crash. 

theme:
 On both of classic and modern.
I see this as well using Mozilla/2001110603 on Win2000.

However, if I double click on a language instead of pressing OK, then it works 
as expected.
ccing hewitt since this may be fallout from the <dialog> landing.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: intl, polish
The call to doSetOKCancel(AddAvailableLanguage) was removed from
pref-languages.js but is not called from anywhere now.  Patch coming up.
Status: NEW → ASSIGNED
Keywords: polish

    
    

    
  
hewitt, please r.
blake, please sr.
Keywords: patch, 
          
            review
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7

    
    

    
  
Comment on attachment 57870 [details] [diff] [review]
Patch rev 2: *return* AddAvailableLanguage so false is propagated in alert conditions.  Thanks to Blake for pointing this out.

sr=blake

        Attachment #57870 -
        Flags: superreview+

    
    

    
  
Comment on attachment 57870 [details] [diff] [review]
Patch rev 2: *return* AddAvailableLanguage so false is propagated in alert conditions.  Thanks to Blake for pointing this out.

r=bryner

        Attachment #57870 -
        Flags: review+

    
    

    
  
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
*** Bug 110481 has been marked as a duplicate of this bug. ***

    
    

    
  
Did this make it into 0.9.6? bug 111566 and bug 111570 were just filed

    
    

    
  
*** Bug 111566 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 111668 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 111721 has been marked as a duplicate of this bug. ***

    
    

    
  
vrfy fixed using 2001.11.28.0x-comm bits on linux rh7.2, mac 10.1.1 and winNT.
Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 112594 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 113040 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 113135 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 113379 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 114417 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 115062 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey

    
  
No longer blocks: 1111089

          You need to log in
          before you can comment on or make changes to this bug.