Closed
Bug 1125445
Opened 6 years ago
Closed 6 years ago
VertexTexture demo renders incorrectly with ANGLE
Categories
(Core :: Canvas: WebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jgilbert, Assigned: jgilbert)
References
()
Details
(Keywords: regression, site-compat)
Attachments
(2 files, 1 obsolete file)
990 bytes,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
841 bytes,
patch
|
jgilbert
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-release-
|
Details | Diff | Splinter Review |
http://floooh.github.io/oryol/VertexTexture.html Works fine if you disable ANGLE, and fall back to native GL.
Assignee | ||
Updated•6 years ago
|
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
status-firefox38:
--- → affected
status-firefox-esr31:
--- → unaffected
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Man, past-me was obviously an idiot. :)
Attachment #8554956 -
Flags: review?(dglastonbury)
Comment on attachment 8554956 [details] [diff] [review] 0002-Only-do-backbuffer-workaround-if-against-backbuffer.patch Review of attachment 8554956 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLContext.h @@ +1524,4 @@ > const bool mNeedsChange; > > static bool NeedsChange(WebGLContext& webgl) { > + return !webgl.mBoundDrawFramebuffer && Can you right a quick comment to explain what the check is here?
Attachment #8554956 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 3•6 years ago
|
||
r=kamidphish
Attachment #8554956 -
Attachment is obsolete: true
Attachment #8554980 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Severity: normal → major
Comment 4•6 years ago
|
||
Are there tests for this?
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4) > Are there tests for this? There will be, but I'm not going to hold up landing this for tests. I'll make some tests to prevent us from backsliding, though.
Assignee | ||
Comment 6•6 years ago
|
||
I should note that there are tests for this code, but I only tested the case where we're rendering into the webgl backbuffer.
Assignee | ||
Comment 7•6 years ago
|
||
Approval Request Comment [Feature/regressing bug #]: Bug 1048108 [User impact if declined]: Bad rendering WebGL content that relies on intermediate techniques. (rendering to the alpha channel in a draw call against a framebuffer) [Describe test coverage new/current, TreeHerder]: Planned. [Risks and why]: No risk. It's a one-line correction of clear, but incorrect logic. [String/UUID change made/needed]: none
Attachment #8555477 -
Flags: review+
Attachment #8555477 -
Flags: approval-mozilla-release?
Attachment #8555477 -
Flags: approval-mozilla-beta?
Attachment #8555477 -
Flags: approval-mozilla-b2g37?
Attachment #8555477 -
Flags: approval-mozilla-aurora?
Comment 11•6 years ago
|
||
[Tracking Requested - why for this release]: recent regression since FF35
Blocks: 1048108
tracking-firefox35:
--- → ?
tracking-firefox36:
--- → ?
tracking-firefox37:
--- → ?
tracking-firefox38:
--- → ?
Keywords: regression
Version: unspecified → 35 Branch
(In reply to Jeff Gilbert [:jgilbert] from comment #6) > I should note that there are tests for this code, but I only tested the case > where we're rendering into the webgl backbuffer. Can we add the test that would have caught this?
Assignee | ||
Comment 13•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfe54b1d8ac2
Assignee | ||
Comment 14•6 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #12) > (In reply to Jeff Gilbert [:jgilbert] from comment #6) > > I should note that there are tests for this code, but I only tested the case > > where we're rendering into the webgl backbuffer. > > Can we add the test that would have caught this? Yes, comment #5 has me committing to adding tests for this, but not holding up the roll-out of the regression fix on producing tests.
Updated•6 years ago
|
Updated•6 years ago
|
Keywords: dev-doc-needed,
site-compat
Comment 15•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dfe54b1d8ac2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•6 years ago
|
Attachment #8555477 -
Flags: approval-mozilla-beta?
Attachment #8555477 -
Flags: approval-mozilla-beta+
Attachment #8555477 -
Flags: approval-mozilla-aurora?
Attachment #8555477 -
Flags: approval-mozilla-aurora+
Updated•6 years ago
|
Attachment #8555477 -
Flags: approval-mozilla-b2g37?
Comment 18•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/1a8e41dad9fe https://hg.mozilla.org/releases/mozilla-beta/rev/eea6117858b5
Comment 19•6 years ago
|
||
This fix only worked for my Nvidia GTX 650, but did not resolve the issue on older hardware. See Bug 1109708. On my older laptop and desktop with older ATI hardware in Nightly 38.0a1 (2015-01-29), the following duplicates of this bug only display a black window: http://floooh.github.io/oryol/VertexTexture.html http://codepen.io/anon/pen/XJMQwV http://jsfiddle.net/f17Lz5ux/1316/
Assignee | ||
Comment 20•6 years ago
|
||
(In reply to Luke from comment #19) > This fix only worked for my Nvidia GTX 650, but did not resolve the issue on > older hardware. See Bug 1109708. > > On my older laptop and desktop with older ATI hardware in Nightly 38.0a1 > (2015-01-29), the following duplicates of this bug only display a black > window: > > http://floooh.github.io/oryol/VertexTexture.html > http://codepen.io/anon/pen/XJMQwV > http://jsfiddle.net/f17Lz5ux/1316/ Ok, this is a different bug then. Can you open a new one, or link to an existing bug for this?
Comment 23•6 years ago
|
||
Comment on attachment 8555477 [details] [diff] [review] alpha-read.diff (37 and older) Clearing the uplift flags as we are working on the 36 release now.
Attachment #8555477 -
Flags: approval-mozilla-release? → approval-mozilla-release-
Updated•5 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•