113027 - menu icon size CSS rule problem (checkmark, bullet)

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Robert John Churchill]

Hey Ben, with the favicon CSS changes, I've noticed a problem.  On Linux (and
I'd expect Win32 as well), other icons such as checkmarks are now scaled to
16x16 as well. Example: the check next to View->Sidebar when the sidebar is open.

Can you come up with a better rule than

.menu-iconic-icon {
  width: 16px;
  height: 16px;
}

in mozilla/themes/{modern|classic}/global/menu.css

Comment 1

[Jason A.]

Behaviour confirmed on win32 as well

Build ID: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.6+) Gecko/20011201

This wasn't happening on yesterday's build.

btw, where is this CSS file on win32 systems? I did a serach but couldn't find
it anywhere.

Comment 2

[Neil Pryde]

Jason, lxr is your friend, just look at this link:
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/menu.css#246

rjc, what if we add something like this to menu.css#131?

menuitem[checked="true"] 
{
  width: 16px;
  height: 16px;
 list-style-image      : url("chrome://global/skin/menu-check.gif");
}

-Neil.

Comment 3

[Neil Pryde]

But, you better replace 16px with 12px or whatever that should be!

Comment 4

[Neil Pryde]

note:

chrome://global/skin/menu/menu-radio.gif and
chrome://global/skin/menu/menu-check.gif are both 7px by 7px

Comment 5

[R.K.Aa.]

need to cure bug 113102 as well - arrow gifs in link toolbar grew

Comment 6

[R.K.Aa.]

*** Bug 113145 has been marked as a duplicate of this bug. ***

Comment 7

[R.K.Aa.]

*** Bug 113151 has been marked as a duplicate of this bug. ***

Comment 8

[John Morrison]

*** Bug 113165 has been marked as a duplicate of this bug. ***

Comment 9

[R.K.Aa.]

*** Bug 113246 has been marked as a duplicate of this bug. ***

Comment 10

[Luke Koleszar]

Can we add checkmarks and bullets to summary line to avoid dupes, just got two more.

Comment 11

[R.K.Aa.]

*** Bug 113263 has been marked as a duplicate of this bug. ***

Comment 12

[R.K.Aa.]

*** Bug 113262 has been marked as a duplicate of this bug. ***

Comment 13

[Luke Koleszar]

Attachment: Hacked version of modern with 16x16 checkmarks and bullets as a workaround

Comment 14

[Tracy Walker [:tracy]]

*** Bug 113270 has been marked as a duplicate of this bug. ***

Comment 15

[Chris Brien]

Attachment: Patch to the 3 menu.css's

This patch changes the menu-iconic-icon to 7x7 pixels, so the image is the
right size. It also centres (sorta :) the image within the same 16x16px box.

Comment 16

[Chris Brien]

Please add the patch keyword

Comment 17

[Chris Brien]

Attachment: New patch to menu.css's

Actually, that patch causes the bookmark menu icons to shrink to 7px - I never
thought of that unitl I found another bug which said that the addition of
bookmark menu icons caused this bug!

Anyway, this patch works a lot better. Let me know if I've broken anything
else!

(Sorry for all the spam)

Comment 18

[lohphat]

Will this also correct the checkmark bullets in the search dialog dropdowns?

Comment 19

[Chris Brien]

Yes. I had no idea of that bug's existence, but this patch does fix it. (I
assume you mean the "using" combobox in the search sidebar)

Comment 20

[lohphat]

No, the select search header field (to the left of the comparison dropdown).

Comment 21

[Chris Brien]

So, you must mean the search dialog in mail&news? That's fixed, too.
If that's still not what you mean, then please post a screenshot...

Comment 22

[sairuh (rarely reading bugmail)]

olga, are you seeing this? perhaps bug 113340 might be this issue...

Comment 23

[Olga]

No, it's different issue in bug 113340.
This one is about increased size of checkmark.

Comment 24

[Boris Zbarsky [:bzbarsky]]

*** Bug 113472 has been marked as a duplicate of this bug. ***

Comment 25

[R.K.Aa.]

*** Bug 113485 has been marked as a duplicate of this bug. ***

Comment 26

[Scott MacGregor]

adding some keywords.

Comment 27

[R.K.Aa.]

forget comment #5. It's bug 113100 that also needs fixing - same cause.

Comment 28

[Boris Zbarsky [:bzbarsky]]

*** Bug 113512 has been marked as a duplicate of this bug. ***

Comment 29

[alge]

Will this fix checkmark in searchsidebar dropdownbox too?

Comment 30

[Alexander Skwar]

Using build 2001120504 on Windows 2000, the checkmarks are still way ugly.

Comment 31

[André Dahlqvist]

*** Bug 113644 has been marked as a duplicate of this bug. ***

Comment 32

[Alexander Skwar]

In 2001120508 on Linux it's also ugly.

Comment 33

[Chris Brien]

Just to clear a few things up.

My patch isn't in the tree yet (it hasn't even got a review yet), so any builds 
will still show horrid checkmarks. To speed this process, someone may add the 
patch keyword to this bug (because I can't :o( )
If you would like to build from source, you may add this patch by 
running "patch -p0 < '/path/to/downloaded/patch'" before running make.

My patch moves the 16px size from the checkmark image to it's containing box, 
so that any image smaller will _not_ be stretched, but no image will be bigger 
than 16px.

Finally, this fixes _all_ instances of checkmarks (and bullets) in the dropdown 
menus. This includes
1) the window menus (&View and &Tasks etc)
2) xul dropdowns, including those in the search sidebar, the tabs dropdown, and 
in the mail&news search dialog.

Comment 34

[Markus Gerstel]

Have you already notified Ben ? This will speed things up even more =)

Comment 35

[John Morrison]

*** Bug 113762 has been marked as a duplicate of this bug. ***

Comment 36

[R.K.Aa.]

*** Bug 113822 has been marked as a duplicate of this bug. ***

Comment 37

[Stephen Walker]

*** Bug 114099 has been marked as a duplicate of this bug. ***

Comment 38

[Matthias Versen [:Matti]]

*** Bug 114186 has been marked as a duplicate of this bug. ***

Comment 39

[Asa Dotzler [:asa]]

rjc, beng, can you all take a look at this. It's a high profile bug that's
wasting a lot of reporting and triage time. A contributor has come up with a
patch and it's been sitting for a few days now with no comment. 

Comment 40

[Boris Zbarsky [:bzbarsky]]

*** Bug 114294 has been marked as a duplicate of this bug. ***

Comment 41

[Joe Hewitt (gone)]

This patch fixes the oversized checkmark bug, but it reverts the intended
behavior of rjc's favicon patch.  The reason the icon has a width/height of 16px
is to prevent oversized favicons from making the menuitem grow.  

So, in addition to the current patch, you should put max-width: 16px and
max-height 16px; on .menu-iconic-icon

Comment 42

[Boris Zbarsky [:bzbarsky]]

*** Bug 114313 has been marked as a duplicate of this bug. ***

Comment 43

[Chris Brien]

Attachment: icon for testcase (72x72px)

Comment 44

[Chris Brien]

Attachment: testcase

This testpage uses attachment 61019 [details] as it's favicon. That icon has only a
72x72px image, so it is usable to check that no favicons are being stretched
(see bug 109862 for why I can't just use any icon).
If you add this page to your favourites, it stretches the menu widthways (but
not heightways).
I'll then see if I can fix this bug without causing these favicons to break...

Comment 45

[:deanis74]

*** Bug 114567 has been marked as a duplicate of this bug. ***

Comment 46

[Lucas MacBride]

*** Bug 114683 has been marked as a duplicate of this bug. ***

Comment 47

[Boris Zbarsky [:bzbarsky]]

*** Bug 114735 has been marked as a duplicate of this bug. ***

Comment 48

[Joe Hewitt (gone)]

Just needed to make the checkbox/radio images 16x16, this saves us from needed
an extra box around the image (which I will remove soon).  

Comment 49

[Neil Pryde]

It's always great to see the patch attached to a bug, so that we don't have to
search for it :)

Comment 50

[Neil Pryde]

I guess you changed the images, used in menu.css, because it's a faster way of
doing things:

http://lxr.mozilla.org/seamonkey/source/themes/modern/global/menu.css#178-202

But i'm not 100% sure, did you change more?

Comment 51

[R.K.Aa.]

checkmarks in preferences/fonts (dropdown menus) still large in classic theme

Comment 52

[R.K.Aa.]

*** Bug 114966 has been marked as a duplicate of this bug. ***

Comment 53

[eberry]

*** Bug 114977 has been marked as a duplicate of this bug. ***

Comment 54

[Asa Dotzler [:asa]]

this isn't fixed. classic images are still too large. 

Comment 55

[Boris Zbarsky [:bzbarsky]]

The link toolbar images have also not been fixed.

Comment 56

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 57

[Joe Hewitt (gone)]

mine

Comment 58

[[not reading bugmail]]

Joe, looks like another bug Ben has (ie bug 113100) is also for this.

Comment 59

[[e-mail]]

Don't forget that the alignment menulist in EdImageProps.xul uses large images.

Wouldn't it be easier to set the icon size only on bookmark items i.e.

.bookmark-item > .menu-iconic-left > image /* should put class on that image */
{
  width: 16px;
  height: 16px;
}

Comment 60

[Joe Hewitt (gone)]

fixed on trunk and branch

Comment 61

[Sébastien Delahaye]

Icons are not fixed. They're still too large.
Go there : 
http://bugzilla.mozilla.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&email1=&emailtype1=substring&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&bugidtype=include&bug_id=&changedin=1&votes=&chfield=%5BBug+creation%5D&chfieldfrom=&chfieldto=Now&chfieldvalue=&product=Browser&product=MailNews&short_desc=&short_desc_type=substring&long_desc=&long_desc_type=substring&bug_file_loc=&bug_file_loc_type=substring&status_whiteboard=&status_whiteboard_type=substring&keywords=&keywords_type=anywords&field0-0-0=noop&type0-0-0=noop&value0-0-0=&cmdtype=doit&newqueryname=&order=Reuse+same+sort+as+last+time
and look at the First / Next / Last icons. They're still ugly.

Comment 62

[Luke Koleszar]

Link toolbar icons are now the correct size in classic, but still stretched in
modern.
Build 2001121909 WinME

I think all the remaining issues are covered by bug 113100.

Comment 63

[Patty Mac]

Verified (2001-12-28-08-trunk)

Comment 64

[Sébastien Delahaye]

The bug still exists with the modern theme, for the Site Navigation bar, with
build 2001122803 on w2k.

Comment 65

[Markus Gerstel]

Please read "Additional Comment #62 From Luke Koleszar 2001-12-19 16:13"

Thank you.

Comment 66

[Sébastien Delahaye]

Attachment: Site nav bar in modern theme

As requested by [e-mail], here is a screenshot of the site nav bar in
modern theme. I've modified it to show the images when it's active and when
it's not.

Most are still very aliased.

Comment 67

[Patty Mac]

 Sébastien, I don't see it anymore. If you still see it in current build, please
reopen. Verified (2002-01-29-06-trunk)

Comment 68

[Sébastien Delahaye]

Works nice now.