Open Bug 1166829 Opened 4 years ago Updated Last year

Reader mode does not work for local pages

Categories

(Toolkit :: Reader Mode, defect, P5)

defect

Tracking

()

People

(Reporter: bugzilla_account, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reader-mode-firefox-integration])

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150513174244

Steps to reproduce:

Open any webpage in Firefox which is stored locally and click on the book icon.


Actual results:

Firefox would open an empty page with title "New Tab" instead of reader view.
Component: Untriaged → Reading List
I con confirm this bug for:

Application Basics
------------------

Name: Firefox
Version: 38.0.1
Build ID: 20150513174244
Update Channel: release
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Firefox/38.0
Multiprocess Windows: 0/1 (default: false)

Crash Reports for the Last 3 Days
---------------------------------

All Crash Reports

Extensions
----------

Name: Firebug
Version: 2.0.9.1-signed
Enabled: true
ID: firebug@software.joehewitt.com

Name: YSlow
Version: 3.1.8.1-signed
Enabled: true
ID: yslow@yahoo-inc.com

Name: ADB Helper
Version: 0.7.4
Enabled: false
ID: adbhelper@mozilla.org

Name: Adblock Edge
Version: 2.1.9.1-signed
Enabled: false
ID: {fe272bd1-5f76-4ea4-8501-a05d35d823fc}

Name: After the Deadline
Version: 1.51.1-signed
Enabled: false
ID: afterthedeadline@afterthedeadline.com

Name: Calomel SSL Validation
Version: 0.75.1-signed
Enabled: false
ID: calomelsslvalidation@calomel.org

Name: DuckDuckGo Plus
Version: 0.4.6.1-signed
Enabled: false
ID: jid1-ZAdIEUB7XOzOJw@jetpack

Name: FireShot
Version: 0.98.70.1-signed
Enabled: false
ID: {0b457cAA-602d-484a-8fe7-c1d894a011ba}

Name: Ghostery
Version: 5.4.5.1-signed
Enabled: false
ID: firefox@ghostery.com

Name: Live HTTP headers
Version: 0.17.1-signed
Enabled: false
ID: {8f8fe09b-0bd3-4470-bc1b-8cad42b8203a}

Name: NoDoFollow
Version: 1.1.1-signed
Enabled: false
ID: {c2b1f3ae-5cd5-49b7-8a0c-2c3bcbbbb294}

Name: NoScript
Version: 2.6.9.25.1-signed
Enabled: false
ID: {73a6fe31-595d-460b-a920-fcc0f8843232}

Name: Places Maintenance
Version: 1.3.1-signed
Enabled: false
ID: places-maintenance@bonardo.net

Name: QuickJava
Version: 2.0.6.1-signed
Enabled: false
ID: {E6C1199F-E687-42da-8C24-E7770CC3AE66}

Name: RequestPolicy
Version: 0.5.28.1-signed
Enabled: false
ID: requestpolicy@requestpolicy.com

Name: SQLite Manager
Version: 0.8.3.1-signed
Enabled: false
ID: SQLiteManager@mrinalkant.blogspot.com

Name: uBlock
Version: 0.9.1.0.1-signed
Enabled: false
ID: {2b10c1c8-a11f-4bad-fe9c-1c11e82cac42}

Name: Zotero
Version: 4.0.26.4
Enabled: false
ID: zotero@chnm.gmu.edu

Graphics
--------

Device ID: 0x 8a0
GPU Accelerated Windows: 1/1 OpenGL (OMTC)
Vendor ID: 0x10de
WebGL Renderer: NVIDIA Corporation -- NVIDIA GeForce 320M OpenGL Engine
windowLayerManagerRemote: true
AzureCanvasBackend: quartz
AzureContentBackend: quartz
AzureFallbackCanvasBackend: none
AzureSkiaAccelerated: 0

Important Modified Preferences
------------------------------

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 358400
browser.cache.disk.smart_size_cached_value: 358400
browser.cache.disk.smart_size.first_run: false
browser.cache.disk.smart_size.use_old_max: false
browser.cache.frecency_experiment: 1
browser.download.importedFromSqlite: true
browser.download.useDownloadDir: false
browser.history_expire_days.mirror: 180
browser.places.importBookmarksHTML: false
browser.places.smartBookmarksVersion: 7
browser.search.useDBForOrder: true
browser.sessionstore.upgradeBackup.latestBuildID: 20150513174244
browser.startup.homepage: about:blank
browser.startup.homepage_override.buildID: 20150513174244
browser.startup.homepage_override.mstone: 38.0.1
browser.tabs.warnOnClose: false
browser.urlbar.autocomplete.enabled: false
browser.urlbar.suggest.bookmark: false
browser.urlbar.suggest.history: false
browser.urlbar.suggest.openpage: false
dom.max_chrome_script_run_time: 0
dom.mozApps.used: true
dom.w3c_touch_events.expose: false
extensions.lastAppVersion: 38.0.1
font.internaluseonly.changed: true
media.gmp-gmpopenh264.lastUpdate: 1432066884
media.gmp-gmpopenh264.version: 1.4
media.gmp-manager.buildID: 20150513174244
media.gmp-manager.lastCheck: 1432848253
network.cookie.lifetimePolicy: 2
network.cookie.prefsMigrated: true
network.predictor.cleaned-up: true
places.database.lastMaintenance: 1432848925
places.history.expiration.transient_current_max_pages: 100664
places.last_vacuum: 1351617651
plugin.disable_full_page_plugin_for_types: application/pdf
plugin.importedState: true
plugin.state.java: 2
print.print_bgcolor: true
print.print_bgimages: true
print.print_colorspace:
print.print_command:
print.print_downloadfonts: false
print.print_duplex: 0
print.print_evenpages: true
print.print_footerleft:
print.print_footerright:
print.print_headerleft:
print.print_headerright:
print.print_in_color: true
print.print_margin_bottom: 0.5
print.print_margin_left: 0.5
print.print_margin_right: 0.5
print.print_margin_top: 0.5
print.print_oddpages: true
print.print_orientation: 0
print.print_page_delay: 50
print.print_paper_data: 0
print.print_paper_height: 11.00
print.print_paper_name:
print.print_paper_size_type: 1
print.print_paper_size_unit: 0
print.print_paper_width: 8.50
print.print_plex_name:
print.print_resolution: 0
print.print_resolution_name:
print.print_reversed: false
print.print_scaling: 1.00
print.print_shrink_to_fit: false
print.print_to_file: false
print.print_unwriteable_margin_bottom: 13
print.print_unwriteable_margin_left: 13
print.print_unwriteable_margin_right: 13
print.print_unwriteable_margin_top: 13
privacy.cpd.offlineApps: true
privacy.cpd.siteSettings: true
privacy.sanitize.migrateFx3Prefs: true
privacy.sanitize.timeSpan: 0
security.disable_button.openCertManager: false
security.warn_viewing_mixed: false
storage.vacuum.last.index: 0
storage.vacuum.last.places.sqlite: 1432848883

Important Locked Preferences
----------------------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.10.8
Version in use: 4.10.8

NSS
Expected minimum version: 3.18.1 Basic ECC
Version in use: 3.18.1 Basic ECC

NSSSMIME
Expected minimum version: 3.18.1 Basic ECC
Version in use: 3.18.1 Basic ECC

NSSSSL
Expected minimum version: 3.18.1 Basic ECC
Version in use: 3.18.1 Basic ECC

NSSUTIL
Expected minimum version: 3.18.1
Version in use: 3.18.1

Experimental Features
---------------------
The reader view itself is actually aware of this restriction: The browser log shows

  16:56:32.267 Only http:// and https:// URLs can be loaded in about:reader1 AboutReader.jsm:26:0

However, the UI does not relay this error (just blanking the tab, even the URL is lost), and it is blissfully unaware of the restriction and hence offers the reader view icon even for local files. (And maybe for ftp:// and other protocols as well?).
Btw, I think the component for this bug is wrong. Shouldn't it be "Reader Mode" instead of "Reading List"?
(In reply to Ralf Jung from comment #3)
> Btw, I think the component for this bug is wrong. Shouldn't it be "Reader
> Mode" instead of "Reading List"?

I don't see reader mode in the list.
I saw some other bugs being tagged with it, e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=800305
(In reply to Dave W. from comment #4)
> (In reply to Ralf Jung from comment #3)
> > Btw, I think the component for this bug is wrong. Shouldn't it be "Reader
> > Mode" instead of "Reading List"?
> 
> I don't see reader mode in the list.

It is under the Product=Toolkit
Duplicate of this bug: 1184132
Component: Reading List → Reader Mode
OS: Unspecified → All
Product: Firefox → Toolkit
Hardware: Unspecified → All
Version: 41 Branch → Trunk
@new users: don't set the component when you are writing a bug if you're not sure, someone will triage for you. :)
Would like to add that this issue affects me too. I save HTML-format eBooks locally for later reading away from internet access, and I'm unable to use reader mode on them for easier viewing. 

Application Basics
------------------

Name: Firefox
Version: 40.0
Build ID: 20150728132422
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Multiprocess Windows: 0/1 (default: false)
Status: UNCONFIRMED → NEW
Ever confirmed: true
We purposefully did this for security reasons:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/AboutReader.jsm?force=1#24

Gijs disabled the reader view icon for local pages in bug 1172009, so that should handle the problem of the button not working as expected.

However, it seems like this could be a valid use case, so perhaps we should revisit the decision to prevent reader view from loading local pages.
(In reply to :Margaret Leibovic from comment #11)
> We purposefully did this for security reasons:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/
> AboutReader.jsm?force=1#24
> 
> Gijs disabled the reader view icon for local pages in bug 1172009, so that
> should handle the problem of the button not working as expected.
> 
> However, it seems like this could be a valid use case, so perhaps we should
> revisit the decision to prevent reader view from loading local pages.

I *think* that considering about:reader is now unlinkable, file might be OK? dveditz, given the background in bug 1147597 / bug 1150862, what do you think?
Flags: needinfo?(dveditz)
As long as web content can't link to or otherwise open an about:reader local file I don't see a problem allowing a user viewing a file:/// page to hit the readability button to see it in about:reader.
Flags: needinfo?(dveditz)
I'll just add my use case:
  - I save snapshots of news articles, blog posts etc. with Zotero. 
  - If I'm offline later and want to revisit an article I open the snapshot, at which point I'd want to enable reader mode.
Blocks: 957912
Priority: -- → P5
Blocks: 1184134
Duplicate of this bug: 1184134
Whiteboard: [reader-mode-firefox-integration]
Hello, 

I would like to kindly ask you, if it is possible to allow / enable this GREAT feature "Reader Mode" also for local html pages. This feature is really great and works super well and it can be useful for many purposes, especially if somebody saves the original page from internet to local disk and wants to read it offline.
Duplicate of this bug: 1312305
Just ran into this today after laboriously cleaning up a short story using view-source: since  firefox mobile still prevents saving the html of a page, then trying to open it locally.  I guess I can add more styling to get something decent to view locally but it'd be nice to not have to do that to all the files I've collected over the years.  Reading the bug comments it seems the original reason for disabling it is no longer appropriate so it'd just be necessary to every the patch from bug 1172009 right?
You need to log in before you can comment on or make changes to this bug.