Closed Bug 120113 Opened 23 years ago Closed 23 years ago

files with unknown content type trigger horked download dialog

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dbaron, Assigned: rpotts)

References

(
URL
)

Details

(4 keywords)

Attachments

(1 file)

oops...
1.63 KB, patch
Details | Diff | Splinter Review 
Due to rpotts' nsURILoader.cpp (rev 1.94) checkin yesterday, files without
extensions or with unknown extensions loaded via FTP are no longer being
displayed as text, but instead, a download dialog (somewhat mangled) is shown.

Steps to reproduce:
 * load ftp://ftp.mozilla.org/README

Expected results:
 * file displayed as text

Actual results:
 * download dialog, with stuff about the type being #1 (#2) is displayed
Severity: normal → major
(This is what caused the leak increase on tinderbox, since the dialog is never
closed (until app shutdown), and thus leaks.  I think it would manage not to
leak if it were closed.)
This causes problems on http://www.netflix.com/ too (which blizzard reports
doesn't send a 'Content-Type' header).  And now I'm seeing the problem on
ftp://ftp.mozilla.org/ in addition to ftp://ftp.mozilla.org/README .
Summary: FTP files without / with unknown extensions trigger download dialog → files with unknown content type trigger horked download dialog
Attached patch oops... — — Splinter Review 
It turns out that the MIME service destroys the contents of the [out] parameter
passed into GetTypeFromURI(...) in failure cases :-(

-- rikc
getter_Copies destroys the original value.
Keywords: mlk, regression
rpotts, are we close to fixing this?  The huge leak # on tbox
is going to hide other leaks, we need to move on this quickly.
Either come up with a fix or back it out.

*** Bug 120216 has been marked as a duplicate of this bug. ***
anyway, shouldn't this be file handling?

*** Bug 120137 has been marked as a duplicate of this bug. ***
Keywords: top100
All ebay dynamic pages come without a content-type header. This bug makes ebay
completely unusable.  Adding top100 keyword.
*** Bug 120227 has been marked as a duplicate of this bug. ***
Marking OS: all. In bug 120227, the ebay bug, marked as a duplicate of this bug,
the problem affected my Windows 98 machine, 0.9.7, Build ID: 2002011503.
OS: Linux → All
*** Bug 120283 has been marked as a duplicate of this bug. ***
ebay?!?  upgrading to blocker.
Severity: major → blocker
Keywords: smoketest
the dups are coming in, we need to fix this today.
ok... i've just backed out the patch that was causing the problem...

-- rick

*** Bug 120335 has been marked as a duplicate of this bug. ***
looking at one of the dupes [bug 120335]: the error there reminds me of what i
had seen in bug 79837 [original comment]...not sure if it's related at all, though.
*** Bug 120320 has been marked as a duplicate of this bug. ***
*** Bug 120346 has been marked as a duplicate of this bug. ***
Since the patch was backed out, no longer a smoketest blocker.
Severity: blocker → major
thanks for backing this out rick.  should we mark this fixed?

*** Bug 120496 has been marked as a duplicate of this bug. ***
*** Bug 120569 has been marked as a duplicate of this bug. ***
I'm closing this bug out.  I've opened up bug #120590 to track the mime-service
issues on the trunk.

-- rick
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
*** Bug 120567 has been marked as a duplicate of this bug. ***
*** Bug 121961 has been marked as a duplicate of this bug. ***
-> file handling & qa.
Component: Networking → File Handling
QA Contact: benc → sairuh
vrfy'd fixed using 2002.01.29.xx comm bits on linux rh7.2, mac 10.1.2 and win2k.
Status: RESOLVED → VERIFIED
It's not quite over yet.

Saving as a web page does not work because of this. I just files a new bug:

bug #128162
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: