Closed Bug 1240804 Opened 8 years ago Closed 8 years ago

[meta] Re-enable unhandled promise rejection tracking in DevTools

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox46 wontfix, firefox47 wontfix, firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: jryans, Unassigned)

References

Details

(Keywords: meta)

Attachments

(2 files, 2 obsolete files)

Unhandled promise rejection tracking was accidentally disabled in DevTools tests ~6 months ago by bug 1164564.

This meta-bug tracks the work to fix tests and finally re-enable unhandled rejection tracking.
Depends on: 1240778, 1240793
This patch can be used to re-enable unhandled promise rejection tracking, so that test fixes can be verified.
Depends on: 1240813
Depends on: 1241527
Depends on: 1242570
:jlong suggests re-testing bug 1149910 before landing to ensure stepping in browser debugger doesn't trap you in promises after the proposed change.
Rebasing patch now that srcdir loader was removed.
Attachment #8709510 - Attachment is obsolete: true
We're very close now.  I'd like to see if it's acceptable to whitelist the two remaining failures, which are both in the debugger, so I'll post patches for review.
Attachment #8735509 - Flags: review?(poirot.alex) → review+
Comment on attachment 8735509 [details]
MozReview Request: Bug 1240804 - Use common instance of Promise.jsm for test harness promise rejection handling. r=ochameau

https://reviewboard.mozilla.org/r/42809/#review39453

Thanks for improving our tests!!
I'd love to review these, but apparently I cannot log in to reviewboard. I'm being redirected to bugzilla to log in, at which point I'm seeing the following error:

"Auth delegation received an HTTP response other than 200 OK from auth consumer. Code: 500"

That's an internal server error, so I don't know what the problem is, or how to work around it.

Jryans, any advice?

In the meantime, you can consider this patch r+'d. I agree we should whitelist these tests. Sorry that I wasn't able to look into them yet.
Flags: needinfo?(jryans)
Sounds like we sorted out MozReview access on IRC.
Flags: needinfo?(jryans)
Comment on attachment 8735510 [details]
MozReview Request: Bug 1240804 - Allow remaining unhandled rejections. r=ejpbruel

https://reviewboard.mozilla.org/r/42811/#review39485

LGTM
Attachment #8735510 - Flags: review?(ejpbruel) → review+
That's the third time now that I've used mozreview, and the third time that I forgot to check the 'ship it' checkbox after giving a positive review.

I wonder if we could make this more idiot proof? I can serve as test idiot, if necessary.
(In reply to Eddy Bruel [:ejpbruel] from comment #14)
> That's the third time now that I've used mozreview, and the third time that
> I forgot to check the 'ship it' checkbox after giving a positive review.

Take a look at Bug 1246611 and also Bug 1197879, they are addressing this part of the UI
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.