Bug 1250708 (saved-screenshots)

[meta] Let "snapshotted pages"/saved screenshots ride the trains

NEW
Unassigned

Status

()

3 years ago
2 days ago

People

(Reporter: mcomella, Unassigned)

Tracking

(Depends on: 19 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Initial implementation behind a nightly flag will occur in bug 1243558. Requirements:
* Smart folder
* Url association

To let it ride the trains (this bug):
* Probes
* Time/date timestamp
* Change the favicon
* Update the snackbar confirmation text (i.e. indicate offline and button to show bookmarks list)
* Display screenshot w/ intent

v2 (if we decide to move forward with this):
* Associate screenshots w/ full-page screenshots (e.g. PDFs)
* Syncing
* Clean up our references to the screenshots when they change on disk

Bugs to implement to follow! :)
Also:
* Using pages w/ screenshots to increase rating in frecency algo

Updated

3 years ago
Alias: bookmark-screenshots
(In reply to Michael Comella (:mcomella) from comment #1)
> Also:
> * Using pages w/ screenshots to increase rating in frecency algo

To be clear, v2.

Some items from bug 1243558 comment 11 need to ride trains:
  - How to disable this functionality? (e.g. invasion of privacy!)
  - Does removing an item from this smart folder remove the screenshot from disk or just FF's representation of it?
    * initial antlam thoughts: just FF representation
(In reply to Michael Comella (:mcomella) from comment #2)
> (In reply to Michael Comella (:mcomella) from comment #1)
> > Also:
> > * Using pages w/ screenshots to increase rating in frecency algo
> 
> To be clear, v2.

Why is this v2? This is more important than actually displaying things in a smart folder.
I'm of the opinion the folder is important in order to 1) avoid dumping things the user doesn't care about into their bookmarks (though you were talking about "hidden" bookmarks before – what did you mean by that?) and 2) to easily remove this feature if we decide we don't like it.

Perhaps Anthony has a different opinion though?
Flags: needinfo?(alam)

Updated

3 years ago
Depends on: 1251058

Updated

3 years ago
Depends on: 1251060

Updated

3 years ago
Depends on: 1251062
(In reply to Michael Comella (:mcomella) from comment #4)
> I'm of the opinion the folder is important in order to 1) avoid dumping
> things the user doesn't care about into their bookmarks (though you were
> talking about "hidden" bookmarks before – what did you mean by that?) and 2)
> to easily remove this feature if we decide we don't like it.

My point about hidden bookmarks is now moot since these screenshots will be saved in a URL metadata table, not in bookmarks. My "hidden bookmark" comment was about the fact that these bookmarks would never really be visible outside the magic "Screenshots" folder. Using bookmarks was merely a way to get frecency weighting.

Now that we are using URL metadata, it's not relevant. No screenshots would ever be saved into the user's bookmarks. We need to _add_ code to make them visible in a magic folder and _add_ code to make them weight frecency.
Alias: bookmark-screenshots → saved-screenshots
Summary: [meta] Let bookmarks-linked-screenshots ride the trains → [meta] Let "snapshotted pages"/saved screenshots ride the trains
(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Michael Comella (:mcomella) from comment #2)
> > (In reply to Michael Comella (:mcomella) from comment #1)
> > > Also:
> > > * Using pages w/ screenshots to increase rating in frecency algo
> > 
> > To be clear, v2.
> 
> Why is this v2? This is more important than actually displaying things in a
> smart folder.

(In reply to Michael Comella (:mcomella) from comment #4)
> I'm of the opinion the folder is important in order to 1) avoid dumping
> things the user doesn't care about into their bookmarks (though you were
> talking about "hidden" bookmarks before – what did you mean by that?) and 2)
> to easily remove this feature if we decide we don't like it.
> 
> Perhaps Anthony has a different opinion though?

Using the "has been screenshotted" signal to weight the URL differently is likely going to be important. So, it's probably not a "v2" right now.

And yes, I'd also like to have a smart folder of these screenshots rather than have them scattered amongst the Mobile Bookmarks root.
Flags: needinfo?(alam)

Updated

3 years ago
Depends on: 1255146

Updated

3 years ago
Depends on: 1255171

Updated

3 years ago
Depends on: 1256747

Updated

3 years ago
No longer depends on: 1256747

Updated

2 years ago
Depends on: 1261196

Updated

2 years ago
Depends on: 1261200

Updated

2 years ago
Depends on: 1261201
Depends on: 1261765

Updated

2 years ago
Depends on: 1261780

Updated

2 years ago
Depends on: 1262861

Updated

2 years ago
Depends on: 1250355

Updated

2 years ago
Depends on: 1255243

Updated

2 years ago
Depends on: 1258321

Updated

2 years ago
Depends on: 1258323

Updated

2 years ago
Depends on: 1254229

Updated

2 days ago
Duplicate of this bug: 1260072
You need to log in before you can comment on or make changes to this bug.