Closed
Bug 1253312
Opened 9 years ago
Closed 8 years ago
TC Linux 32 debug builds Tier-1
Categories
(Infrastructure & Operations Graveyard :: CIDuty, task)
Infrastructure & Operations Graveyard
CIDuty
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: selenamarie, Assigned: aselagea)
References
Details
Attachments
(6 files, 1 obsolete file)
626 bytes,
patch
|
kmoir
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
993 bytes,
text/plain
|
Details | |
48.09 KB,
text/plain
|
Details | |
1.93 KB,
patch
|
kmoir
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
426 bytes,
patch
|
kmoir
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
729 bytes,
patch
|
gbrown
:
review+
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
This is a planning bug for tracking work related to getting Linux 32 builds Tier-1.
Comment 1•8 years ago
|
||
We're ready to push linux32 debug to tier 1.
Can buildduty please disable the linux32 debug builds and tests in buildbot? You can then make the corresponding changes to treeherder to make the TC linux32 debug jobs show up as tier 1.
Component: Task Configuration → Buildduty
Product: Taskcluster → Release Engineering
QA Contact: bugspam.Callek
Comment 3•8 years ago
|
||
See also notes from bug 1330302
we now have all of the linux32 tests running in taskcluster (currently tier-2, although we can configure this in-tree to be tier-1).
For all trunk branches, we are ready to disable linux32-debug (not opt or pgo) from buildbot scheduling.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aselagea
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8825859 -
Flags: review?(kmoir)
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Comment 6•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8825861 -
Flags: review?(kmoir)
Assignee | ||
Comment 7•8 years ago
|
||
While doing some testing on my test master, I noticed that buildbot linux32 debug tests are missing for some platforms (e.g. ash) - when I do the diff, they're missing from both old and new file.
I even printed the content of BRANCHES['ash']['platforms']['linux']['ubuntu32_vm']['debug_unittest_suites'] and it's empty. But in TH, we seem to have linux32 debug tests running on buildbot:
e.g. https://treeherder.mozilla.org/#/jobs?repo=ash&revision=de7bf784e619d7fa12b47750faaf7c4c22fa95b8
Am I missing something here?
Comment 8•8 years ago
|
||
perhaps something needs to be adjusted in project_branches.py, the platform is included in it
'ash': {
'enable_talos': False,
'lock_platforms': True,
'merge_builds': False,
'periodic_start_hours': [9, 21],
'pgo_strategy': 'periodic',
'platforms': {
'linux': {
'slave_platforms': ['ubuntu32_vm'],
},
'linux-debug': {
'slave_platforms': ['ubuntu32_vm'],
},
Assignee | ||
Comment 9•8 years ago
|
||
Thanks for pointing me to that file! I updated the patch to remove all "linux-debug" entries for the trunk project branches. However, that doesn't affect the difference, as no extra jobs were removed - it seems like mozilla/project_branches.py is not considered at all when computing the total number of jobs.
I even tried to match "master/master_config.json" file for a linux buildbot master, but got the same results.
Attachment #8825861 -
Attachment is obsolete: true
Attachment #8825861 -
Flags: review?(kmoir)
Comment 10•8 years ago
|
||
It looks like there are changes on default that didn't merge to production with respect to the ash branch. So when you test on your master you are testing on default which has the changes. The masters run on the production branches which do not have the changes so the old builders are still triggered and appear on th.
I think this is related to
https://hg.mozilla.org/build/buildbot-configs/rev/fb273fd16706
and
https://bugzilla.mozilla.org/show_bug.cgi?id=1328915
I just merged default to production so a reconfig should fix this up shortly on our masters.
Comment 11•8 years ago
|
||
I verified that master don't show those builders anymore, so you can ask for review on your patches.
Updated•8 years ago
|
Attachment #8825859 -
Flags: review?(kmoir) → review+
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8826187 [details] [diff] [review]
bug_1253312_disable_tests_v2.patch
Thanks for checking Kim!
Maybe I didn't express myself well but my question was not related to the builders - https://bugzilla.mozilla.org/attachment.cgi?id=8825860 shows several "leak" entries (which stand for linux debug builders) being removed, so that looks good.
I was worried about the tests diff on some branches (like "ash"). If I create a test master and try to obtain the initial list of tests (e.g. "old" file), I only get the following thing for "ash":
(disable-l32dbg-test)[aselagea@dev-master2.bb.releng.use1.mozilla.com disable-l32dbg-test]$ cat old | grep "ash " | grep "Ubuntu"
Ubuntu HW 12.04 x64 ash talos g4 ScriptFactory
Ubuntu HW 12.04 x64 ash pgo talos g4 ScriptFactory
Ubuntu HW 12.04 x64 ash talos g4-e10s ScriptFactory
Ubuntu HW 12.04 x64 ash pgo talos g4-e10s ScriptFactory
So only the talos tests which run on HW. Yet Treeherder shows that we have Ubuntu VM tests running on Linux debug on "ash": https://treeherder.mozilla.org/#/jobs?repo=ash&revision=f88b08dee5c92679632f4066c0b66f375c3f3f70
Applying *this* patch will not change anything (the end result is the desired one, as we no longer want those tests), so asking for a review on this patch too :-).
As for the talos tests, they shouldn't be there either: https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/project_branches.py#22. That is being treated in bug 1326471 though.
Attachment #8826187 -
Flags: review?(kmoir)
Updated•8 years ago
|
Attachment #8826187 -
Flags: review?(kmoir) → review+
Comment 13•8 years ago
|
||
We don't have those Ubuntu VM tests running on Linux debug on "ash" since I merged default -> production for the buildbot-configs repo on Friday. See subsequent pushes like this
https://treeherder.mozilla.org/#/jobs?repo=ash&revision=54a50878ea092a81362ea7ede3c68f308450e262
Assignee | ||
Updated•8 years ago
|
Attachment #8825859 -
Flags: checked-in+
Assignee | ||
Updated•8 years ago
|
Attachment #8826187 -
Flags: checked-in+
Assignee | ||
Comment 14•8 years ago
|
||
Also merged to production: https://hg.mozilla.org/build/buildbot-configs/rev/e0a3fb3ebd66
Assignee | ||
Comment 15•8 years ago
|
||
From what I could see, we only need to switch Linux32 debug builders to tier 1 in TC. The corresponding tests will automatically be switched (excepting those which already have a tier level explicitly set).
Attachment #8827445 -
Flags: review?(kmoir)
Updated•8 years ago
|
Attachment #8827445 -
Flags: review?(kmoir) → review+
Comment 16•8 years ago
|
||
Pushed by kmoir@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f04d07ad34
TC Linux 32 debug builds Tier-1 r=kmoir
Comment 17•8 years ago
|
||
Comment on attachment 8827445 [details] [diff] [review]
linux32_debug_tier1.patch
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f04d07ad349627aadabdc232369d83a49e0dcd
Assignee | ||
Updated•8 years ago
|
Attachment #8827445 -
Flags: checked-in+
Comment 18•8 years ago
|
||
(In reply to Alin Selagea [:aselagea][:buildduty] from comment #15)
> From what I could see, we only need to switch Linux32 debug builders to tier
> 1 in TC. The corresponding tests will automatically be switched (excepting
> those which already have a tier level explicitly set).
Perhaps an update to https://dxr.mozilla.org/mozilla-central/rev/3e275d37a06236981bff399b7d7aa0646be3fee7/taskcluster/taskgraph/transforms/tests.py#412 ?
Assignee | ||
Comment 19•8 years ago
|
||
Thanks Geoff! I uploaded a new patch to add linux32/debug in the list of tier 1 platforms as well.
Attachment #8827824 -
Flags: review?(gbrown)
Comment 20•8 years ago
|
||
bugherder |
Updated•8 years ago
|
Attachment #8827824 -
Flags: review?(gbrown) → review+
Comment 21•8 years ago
|
||
Pushed by kmoir@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8cf89eff546
TC Linux 32 debug builds Tier-1 r=gbrown
Comment 22•8 years ago
|
||
Comment on attachment 8827824 [details] [diff] [review]
linux32_debug_tier1_tests.patch
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8cf89eff546edd53a31b54b45c8947693e9d4bb
Attachment #8827824 -
Flags: checked-in+
FWIW, this change got blown away by the patch Callek landed directly to m-c for bug 1331986.
Comment 24•8 years ago
|
||
bugherder |
Updated•7 years ago
|
Product: Release Engineering → Infrastructure & Operations
Updated•5 years ago
|
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•