129346 - Fieldset renders incorrectly with style="float: left;" or any other shrink-wrap situation

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Pavol Vaskovic]

Fieldset seems to have problems rendering legend and calculating width when it
has style="float: left;". See testcase.

Comment 1

[Pavol Vaskovic]

I just noticed that style="float: right;" has also problems in initial load of
the page. Reloading fixes problem with "float: right;", but has no effect on
left one.

Comment 2

[Christopher Hoess (gone)]

*** Bug 129345 has been marked as a duplicate of this bug. ***

Comment 3

[Alexandru Savulov]

heh, i just went over floater bugs and noticed the strange floating point
rounding errors when resizing the testcase
http://pali.sk/mozilla/fieldset_testcase.html.

Comment 4

[Leo Savernik]

Attachment: Floated fieldset also destroys table

A floated fieldset also destroys layout of a table contained inside.

Comment 5

[Garrett Smith]

Attachment: Floated fieldset destroys alignment of nested <table> and <legend> elements

fieldsets 1 & 2:
 Notice how the table cells don't line up correctly.

fieldset 1:
 Notice the gap on the rhs of the table directly proportional to the width of
the col. When the width of the col is changed, the width of the gap is changed
also. The border of the col can be seen behind some of the misaligned cells.

fieldset 2: 
 Notice the legend has the full width of the fieldset. Setting css properties
of the legend "width", "display", and "position" has no effect in any
combination.

Comment 6

[Boris Zbarsky [:bzbarsky]]

This is more of the "only first part of size-finding reflow is done" crap.

We really need a better way of automating this shrink-wrapping stuff a little
more...

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: This patch fixes the bug for me (but DO NOT CHECK THIS IN)

I suspect that the "real fix" would involve munging the availSize a bit more
and maybe calling FinishReflowChild before doing the second Reflow()....

Comment 8

[Pavol Vaskovic]

Resizing testcase in Gecko/20030516 Mozilla Firebird/0.6 window is strange...
the right-floated fieldsets are jumping between correct and incorrect rendering
depending on odd/even window width. Not that it helps to solve the left-floated
ones.. ;-)

Comment 9

[Bernd]

*** Bug 220178 has been marked as a duplicate of this bug. ***

Comment 10

[nucleos]

This bug is present in Firebird too.

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 235509 has been marked as a duplicate of this bug. ***

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 251120 has been marked as a duplicate of this bug. ***

Comment 13

[Martijn Wargers (dead)]

*** Bug 342298 has been marked as a duplicate of this bug. ***

Comment 14

[Asbjørn Ulsberg]

I've made a simple test case that portraits the bug as it affects table cells inside a floating fieldset: http://theinnercircle.no/misc/floating-fieldset.html

Comment 15

[Steve England [:stevee]]

Weirdness observed with:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/2006120606 Minefield/3.0a (pre-reflow branch)
(Fields not lined up nicely)

No weirdness observed with:
- Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/2006120804 Minefield/3.0a1 (post-reflow branch)
(Fields lined up nicely)

-->RESOLVED FIXED (and mark blocking bug 300030) ??

Comment 16

[Mats Palmgren (inactive)]

Bug occurs in SeaMonkey 2006120701 (pre reflow branch) on Linux.
Bug does not occur in SeaMonkey 2006120801 (post reflow branch) on Linux.

(I checked the dupes too)

-> FIXED (by the reflow branch landing)

Comment 17

[Boris Zbarsky [:bzbarsky]]

We need a testcase in the regression suite for this.