Closed
Bug 1313469
Opened 8 years ago
Closed 8 years ago
Convert XPCOM test TestCOMArray to a gtest
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files)
|
2.81 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
|
13.18 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Convert xpcom/tests/TestCOMArray.cpp to a gtest and move to xpcom/tests/gtest/.
|
Assignee | |
Comment 1•8 years ago
|
||
This just splits out the test functions, no logic is changed. MozReview-Commit-ID: KjUA9rQ7iOS
Attachment #8805653 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
MozReview-Commit-ID: CEhXX60lpZ8
Attachment #8805654 -
Flags: review?(nfroyd)
|
||
Updated•8 years ago
|
Attachment #8805653 -
Flags: review?(nfroyd) → review+
|
|
||
Updated•8 years ago
|
Attachment #8805654 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5364fc8db9b0e29c209f58ea6e06fd9d980436d9 Bug 1313469 - Part 1: Split out test functions. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/82bf00ff65052d93ec3dbc337bf223df9bb8b75d Bug 1313469 - Part 2: Convert TestCOMArray to a gtest. r=froydnj
Backout by philringnalda@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/561b87e98ada Backed out 18 changesets (bug 1313469, bug 1313468, bug 1313474, bug 1313472, bug 1313473, bug 1313470, bug 1313471, bug 1313467, bug 1313466) for OS X gtest crashes
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d4477c3e98f5759db56a626a521231f71b0d5e2 Bug 1313469 - Part 1: Split out test functions. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/7b730d2d279442ae03e6f42e7c6141a5a904e9af Bug 1313469 - Part 2: Convert TestCOMArray to a gtest. r=froydnj
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2d4477c3e98f https://hg.mozilla.org/mozilla-central/rev/7b730d2d2794
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•